Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0
    • Labels:
      None
    • Environment:
      Any
    • Assignee Priority:
      P1
    • Affects:
      Compatibility/Configuration

      Description

      Add the Font Awesome font and stylesheet to ACE, so that ACE and MOBI components can make use of its icons.
      1. 42894.PNG
        6 kB
      2. 43064.PNG
        15 kB
      3. group.PNG
        30 kB
      4. hover.png
        7 kB
      5. selected.PNG
        8 kB
      6. unselected.PNG
        8 kB

        Activity

        Hide
        Liana Munroe added a comment -

        Tested with r43088. Issue 1 is resolved however issue 2 still remains. Checkbox buttons inside a group are not visible when inside h:dataTable, ace:dataTable or ui:repeat.
        Test app located at:
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/buttonGroup

        Show
        Liana Munroe added a comment - Tested with r43088. Issue 1 is resolved however issue 2 still remains. Checkbox buttons inside a group are not visible when inside h:dataTable, ace:dataTable or ui:repeat. Test app located at: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/buttonGroup
        Hide
        Arturo Zambrano added a comment -

        For this, you'll have to modify the test app, since it is programmed not to show any label when the button is unchecked. Just remove that condition or dynamically change the label when it's unchecked.

        Show
        Arturo Zambrano added a comment - For this, you'll have to modify the test app, since it is programmed not to show any label when the button is unchecked. Just remove that condition or dynamically change the label when it's unchecked.
        Hide
        Ken Fyten added a comment -

        Basically, the changes made were thinking of the standard case where we render the checkbox icons. When using a label, it is only displayed when the button is checked. So when the button is not checked, it presents no visual cues. Some possible solutions would be to render the label with a lighter shade of gray when not checked, or the unchecked box icon.

        Why wouldn't we want the label rendered all the time, not just when it's selected?

        Show
        Ken Fyten added a comment - Basically, the changes made were thinking of the standard case where we render the checkbox icons. When using a label, it is only displayed when the button is checked. So when the button is not checked, it presents no visual cues. Some possible solutions would be to render the label with a lighter shade of gray when not checked, or the unchecked box icon. Why wouldn't we want the label rendered all the time, not just when it's selected?
        Hide
        Arturo Zambrano added a comment -

        Ok, this is actually not the case. That's what I thought when I used QA's app. The label is always rendered. What happens is that in the QA app, in a number of tests, the pages are programmed not to render any labels when the button is unchecked. See my previous comment.

        Show
        Arturo Zambrano added a comment - Ok, this is actually not the case. That's what I thought when I used QA's app. The label is always rendered. What happens is that in the QA app, in a number of tests, the pages are programmed not to render any labels when the button is unchecked. See my previous comment.
        Hide
        Liana Munroe added a comment -

        QA test applications now updated and buttons are now visible when in a non-selected state. Thanks Art.
        All issues verified ICEfaces 4 trunk r43088. Tomcat 7, IE, 11, FF 33, Chrome 38.

        Show
        Liana Munroe added a comment - QA test applications now updated and buttons are now visible when in a non-selected state. Thanks Art. All issues verified ICEfaces 4 trunk r43088. Tomcat 7, IE, 11, FF 33, Chrome 38.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: