ICEfaces
  1. ICEfaces
  2. ICE-9537

Added 'style' attribute to ace:dialog and ace:confirmationDialog

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0.BETA
    • Fix Version/s: 4.0.BETA, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Cause of failure is ICEfaces3/trunk revision# 37043
    • Assignee Priority:
      P1
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      Some of the ACE input components are not rendering the values of the style attribute(s) properly. See above for range of failing revisions.

      ace:maskedEntry
      The style/styleClass attributes are not being applied.

      ace:autoCompleteEntry
      The style attribute is not being applied.

      **There may be other input components that also show this behaviour**

      To reproduce:
      1) Build / deploy one of the test apps located in http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly
      2) Navigate to the Attribute Test
      The test page contains the component with the style attribute set.

        Activity

        Hide
        Arturo Zambrano added a comment - - edited

        I made a survey of all the components to check whether their 'style' and 'styleClass' attributes are working.

        First of all, the two components reported in this JIRA are working correctly in the latest revision.

        ace:maskedEntry is rendering the 'style' and 'class' attributes on the <input type="text"/> tag.
        ace:autoCompleteEntry is rendering the 'style' attribute on the <input type="text"/> tag as well, and it's rendering the 'class' attribute on the container <div>.

        If certain specified styles aren't actually visible on the page, it could be because those styles are overriden by the theme or some custom, fixed styling applied by the component. For example, in order to actually see the color specified by 'background-color', one would have to also specify 'background-image:none;' so that the theme's background image doesn't override the background color.

        All other components are working as expected. They're rendering their 'style' and 'styleClass' attributes if they support them. Below there are three lists of components that simply don't support one or the two attributes in their TLD's.

        No support for 'style' nor 'styleClass':

        • ace:resizable
        • ace:draggable
        • ace:droppable
        • ace:printer
        • ace:tree
        • ace:node
        • ace:accordionPane
        • ace:tabPane

        The first four components listed above don't render a container themselves, so they definitely don't need to support these attributes.

        No support for 'style' attribute only:

        • ace:submitMonitor
        • ace:confirmationDialog
        • ace:dialog

        ace:confirmationDialog and ace:dialog have never had a 'style' attribute since they were created. The reasons seems to be that the styleClass is passed as an argument to the underlying widget (jQuery UI Dialog), and it is responsible of applying it when the widget is initialized. It has no support for specifying a custom 'style' attribute, but it might be possible to add it with our own code.

        No support 'styleClass' attribute only:

        • ace:chart
        Show
        Arturo Zambrano added a comment - - edited I made a survey of all the components to check whether their 'style' and 'styleClass' attributes are working. First of all, the two components reported in this JIRA are working correctly in the latest revision. ace:maskedEntry is rendering the 'style' and 'class' attributes on the <input type="text"/> tag. ace:autoCompleteEntry is rendering the 'style' attribute on the <input type="text"/> tag as well, and it's rendering the 'class' attribute on the container <div>. If certain specified styles aren't actually visible on the page, it could be because those styles are overriden by the theme or some custom, fixed styling applied by the component. For example, in order to actually see the color specified by 'background-color', one would have to also specify 'background-image:none;' so that the theme's background image doesn't override the background color. All other components are working as expected. They're rendering their 'style' and 'styleClass' attributes if they support them. Below there are three lists of components that simply don't support one or the two attributes in their TLD's. No support for 'style' nor 'styleClass': ace:resizable ace:draggable ace:droppable ace:printer ace:tree ace:node ace:accordionPane ace:tabPane The first four components listed above don't render a container themselves, so they definitely don't need to support these attributes. No support for 'style' attribute only: ace:submitMonitor ace:confirmationDialog ace:dialog ace:confirmationDialog and ace:dialog have never had a 'style' attribute since they were created. The reasons seems to be that the styleClass is passed as an argument to the underlying widget (jQuery UI Dialog), and it is responsible of applying it when the widget is initialized. It has no support for specifying a custom 'style' attribute, but it might be possible to add it with our own code. No support 'styleClass' attribute only: ace:chart
        Hide
        Arturo Zambrano added a comment -

        Added 'style' attribute to ace:dialog and ace:confirmationDialog at revision 37754.

        Show
        Arturo Zambrano added a comment - Added 'style' attribute to ace:dialog and ace:confirmationDialog at revision 37754.
        Hide
        Liana Munroe added a comment -

        Confirmed resolved trunk revision 37756. Tomcat 6, all browsers.

        Show
        Liana Munroe added a comment - Confirmed resolved trunk revision 37756. Tomcat 6, all browsers.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Cruz Miraback
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: