Details
-
Type: Improvement
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: 4.0.BETA
-
Component/s: ACE-Components
-
Labels:None
-
Environment:Cause of failure is ICEfaces3/trunk revision# 37043
-
Assignee Priority:P1
-
Affects:Documentation (User Guide, Ref. Guide, etc.)
Description
Some of the ACE input components are not rendering the values of the style attribute(s) properly. See above for range of failing revisions.
ace:maskedEntry
The style/styleClass attributes are not being applied.
ace:autoCompleteEntry
The style attribute is not being applied.
**There may be other input components that also show this behaviour**
To reproduce:
1) Build / deploy one of the test apps located in http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly
2) Navigate to the Attribute Test
The test page contains the component with the style attribute set.
ace:maskedEntry
The style/styleClass attributes are not being applied.
ace:autoCompleteEntry
The style attribute is not being applied.
**There may be other input components that also show this behaviour**
To reproduce:
1) Build / deploy one of the test apps located in http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly
2) Navigate to the Attribute Test
The test page contains the component with the style attribute set.
Activity
Cruz Miraback
created issue -
Cruz Miraback
made changes -
Field | Original Value | New Value |
---|---|---|
Summary | Regression: ACE Input Component Styling Issues | Regression: ACE Input Component Style Attribute(s) Not Being Applied |
Cruz Miraback
made changes -
Description |
Some of the ACE input components are not rendering the values of the style attribute(s) properly. See above for range of failing revisions.
ace:maskedEntry The style/styleClass attributes are not being applied. ace:autoCompleteEntry The style attribute is not being applied. **There may be other input components affected by the change that also show this behaviour** To reproduce: 1) Build / deploy test app located in http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly 2) Navigate to the Attribute test |
Some of the ACE input components are not rendering the values of the style attribute(s) properly. See above for range of failing revisions.
ace:maskedEntry The style/styleClass attributes are not being applied. ace:autoCompleteEntry The style attribute is not being applied. **There may be other input components that also show this behaviour** To reproduce: 1) Build / deploy test app located in http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly 2) Navigate to the Attribute test |
Ken Fyten
made changes -
Assignee | Arturo Zambrano [ artzambrano ] | |
Fix Version/s | 3.4 [ 10770 ] | |
Assignee Priority | P1 [ 10010 ] |
Cruz Miraback
made changes -
Environment |
Passed at ICEfaces3/trunk revision# 37030
Failed at ICEfaces3/trunk revision# 37045 |
Cause of failure is ICEfaces3/trunk revision# 37043 |
Cruz Miraback
made changes -
Description |
Some of the ACE input components are not rendering the values of the style attribute(s) properly. See above for range of failing revisions.
ace:maskedEntry The style/styleClass attributes are not being applied. ace:autoCompleteEntry The style attribute is not being applied. **There may be other input components that also show this behaviour** To reproduce: 1) Build / deploy test app located in http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly 2) Navigate to the Attribute test |
Some of the ACE input components are not rendering the values of the style attribute(s) properly. See above for range of failing revisions.
ace:maskedEntry The style/styleClass attributes are not being applied. ace:autoCompleteEntry The style attribute is not being applied. **There may be other input components that also show this behaviour** To reproduce: 1) Build / deploy one of the test apps located in http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly 2) Navigate to the Attribute Test The test page contains the component with the style attribute set. |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #37754 | Tue Sep 03 12:19:20 MDT 2013 | art.zambrano | |
Files Changed | ||||
MODIFY
/icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogMeta.java
MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/confirmationdialog/confirmationdialog.js MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/confirmationdialog/ConfirmationDialogMeta.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/confirmationdialog/ConfirmationDialogRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js |
Arturo Zambrano
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Summary | Regression: ACE Input Component Style Attribute(s) Not Being Applied | Added 'style' attribute to ace:dialog and ace:confirmationDialog |
Issue Type | Bug [ 1 ] | Improvement [ 4 ] |
Priority | Major [ 3 ] | Minor [ 4 ] |
Affects | Documentation (User Guide, Ref. Guide, etc.) [ 10003 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #37857 | Wed Sep 11 19:23:06 MDT 2013 | art.zambrano | |
Files Changed | ||||
MODIFY
/icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogRenderer.java
|
Ken Fyten
made changes -
Fix Version/s | 4.0 [ 11382 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
I made a survey of all the components to check whether their 'style' and 'styleClass' attributes are working.
First of all, the two components reported in this JIRA are working correctly in the latest revision.
ace:maskedEntry is rendering the 'style' and 'class' attributes on the <input type="text"/> tag.
ace:autoCompleteEntry is rendering the 'style' attribute on the <input type="text"/> tag as well, and it's rendering the 'class' attribute on the container <div>.
If certain specified styles aren't actually visible on the page, it could be because those styles are overriden by the theme or some custom, fixed styling applied by the component. For example, in order to actually see the color specified by 'background-color', one would have to also specify 'background-image:none;' so that the theme's background image doesn't override the background color.
All other components are working as expected. They're rendering their 'style' and 'styleClass' attributes if they support them. Below there are three lists of components that simply don't support one or the two attributes in their TLD's.
No support for 'style' nor 'styleClass':
The first four components listed above don't render a container themselves, so they definitely don't need to support these attributes.
No support for 'style' attribute only:
ace:confirmationDialog and ace:dialog have never had a 'style' attribute since they were created. The reasons seems to be that the styleClass is passed as an argument to the underlying widget (jQuery UI Dialog), and it is responsible of applying it when the widget is initialized. It has no support for specifying a custom 'style' attribute, but it might be possible to add it with our own code.
No support 'styleClass' attribute only: