ICEfaces
  1. ICEfaces
  2. ICE-9518

Compat Resource Servlet use Servlet 3 @WebServlet annotation for automatic configuration

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Won't Fix
          • Affects Version/s: 3.3
          • Fix Version/s: 4.0.BETA, 4.0
          • Component/s: Framework, ICE-Components
          • Labels:
            None
          • Environment:
            Servlet 3, Compat Resource Servlet
          • Assignee Priority:
            P3
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

            Description

            The Compat Resource Servlet uses specific servlet-mappings that must be configured to set values. As such, it's an ideal candidate for using the Servlet 3 @WebServlet annotation, to allow for automatic configuration.

            Now, in a servlet 2.5 container, that annotation will not exist, so as an implementation detail, we may need to create a sub-class that contains the actual annotation, that otherwise would not be classloaded. And we should test the scenario where the web.xml explicitly configures for it along with the annotation, to ensure no odd duplicate definition problems arise.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Mircea Toma added a comment -

              Implemented auto-registration of CompatResourceServlet in Servlet 3.0 compliant servers (as described above). Tested successfully the case where the servlet is registered using annotations and in web.xml.

              Modified showcase's web.xml to use servlet 3.0 XML schema and removed the configuration for CompatResourceSErvlet.

              Show
              Mircea Toma added a comment - Implemented auto-registration of CompatResourceServlet in Servlet 3.0 compliant servers (as described above). Tested successfully the case where the servlet is registered using annotations and in web.xml. Modified showcase's web.xml to use servlet 3.0 XML schema and removed the configuration for CompatResourceSErvlet.
              Hide
              Permalink
              Ken Fyten added a comment -

              We don't want the default showcase web.xml to use Servlet 3 schema as it must work out of the box on older Servlet 2.5 servers also. Please revert that commit (attach the update web.xml to this JIRA for QA).

              Instead, update the Compat config page to add a section for Servlet 3.0 server configuration: http://www.icesoft.org/wiki/display/ICE/Getting+Started+with+the+ICE+Components

              Show
              Ken Fyten added a comment - We don't want the default showcase web.xml to use Servlet 3 schema as it must work out of the box on older Servlet 2.5 servers also. Please revert that commit (attach the update web.xml to this JIRA for QA). Instead, update the Compat config page to add a section for Servlet 3.0 server configuration: http://www.icesoft.org/wiki/display/ICE/Getting+Started+with+the+ICE+Components
              Hide
              Permalink
              Mircea Toma added a comment -

              Reverted change to showcase application and added Servlet 3.0 configuration section in the wiki documentation page.

              Show
              Mircea Toma added a comment - Reverted change to showcase application and added Servlet 3.0 configuration section in the wiki documentation page.
              Hide
              Permalink
              Mircea Toma added a comment -

              The auto configuring resource servlet was removed to avoid confusing our customers. Compat components is old technology that doesn't need to be updated to use the latest specs. Also the magic mapping might be undesirable when users drop icefaces-compat.jar into the classpath without intenting to use any of the included components.

              Show
              Mircea Toma added a comment - The auto configuring resource servlet was removed to avoid confusing our customers. Compat components is old technology that doesn't need to be updated to use the latest specs. Also the magic mapping might be undesirable when users drop icefaces-compat.jar into the classpath without intenting to use any of the included components.

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: