ICEfaces
  1. ICEfaces
  2. ICE-9294

Showcase - ace:menu component text-styling issues with some ACE ThemeRoller themes

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.0
          • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
          • Component/s: ACE-Components, Sample Apps
          • Labels:
            None
          • Environment:
            ICEfaces 3, ACE menu components, dark ACE ThemeRoller themes.
          • Assignee Priority:
            P2

            Description

            The ACE menu family of components has text styling/coloring issues with any ACE ThemeRoller Themes that use a dark panel/menu background colour. This results in the menu text being invisible or with very low contrast, either in the highlighted or default state.

            The known themes that illustrate the issue are:
            - Eggplant
            - Excite Bike
            - Flick
            - Pepper Grinder
            - South Street
            - Start
            - Vader

            To reproduce, simply run the Showcase sample, select one the themes above, and view one of the menu, menuBar, menuButton, contextMenu demos.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Ken Fyten added a comment -

              Attached screenshots showing typical text colouring issues.

              Show
              Ken Fyten added a comment - Attached screenshots showing typical text colouring issues.
              Hide
              Permalink
              yip.ng added a comment - - edited

              Created minimal HTML test case linking to downloaded eggplant theme and wijmo CDN. Same problem. Therefore, it is a wijmo-wijmenu flaw. See screenshot-01 and screenshot-02.

              The wijmo-wijmenu HTML and CSS structure triggers wrong color/icon/state style rules in some themes. Same dilemma as Art in ICE-9293: there is no way to override to correct the rules outside of theme style sheets. But in ICE-9293, only rime theme is changed, and rime theme is our own theme. Here there are seven jQuery UI themes, and the override rules are more complicated. (At least 6 rules with non-trivial selectors to cover all cases I have found so far for eggplant theme). Plus I have to rebuild (maven build only, no ant build?) and copy/rename theme jar every time, unlike the rime or sam themes.

              All this means a lot more future maintenance work, esp. when upgrading. Proceed with fixing other themes nonetheless? (Apart from the one wijmo-wijmenu specific rule that Art just added to rime/theme.css, I have also found quite a few wijmo-wijmenu specific rules already in sam/theme.css.)

              Show
              yip.ng added a comment - - edited Created minimal HTML test case linking to downloaded eggplant theme and wijmo CDN. Same problem. Therefore, it is a wijmo-wijmenu flaw. See screenshot-01 and screenshot-02 . The wijmo-wijmenu HTML and CSS structure triggers wrong color/icon/state style rules in some themes. Same dilemma as Art in ICE-9293 : there is no way to override to correct the rules outside of theme style sheets. But in ICE-9293 , only rime theme is changed, and rime theme is our own theme. Here there are seven jQuery UI themes, and the override rules are more complicated. (At least 6 rules with non-trivial selectors to cover all cases I have found so far for eggplant theme). Plus I have to rebuild (maven build only, no ant build?) and copy/rename theme jar every time, unlike the rime or sam themes. All this means a lot more future maintenance work, esp. when upgrading. Proceed with fixing other themes nonetheless? (Apart from the one wijmo-wijmenu specific rule that Art just added to rime/theme.css, I have also found quite a few wijmo-wijmenu specific rules already in sam/theme.css.)
              Hide
              Permalink
              yip.ng added a comment - - edited

              Request from meeting: commit eggplant theme changes first for review. Note: must use ant build to include eggplant.jar in showcase.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\eggplant.jar#35659
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-eggplant\src\main\resources\META-INF\resources\ace-eggplant\theme.css#35659

              Show
              yip.ng added a comment - - edited Request from meeting: commit eggplant theme changes first for review. Note : must use ant build to include eggplant.jar in showcase. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\eggplant.jar#35659 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-eggplant\src\main\resources\META-INF\resources\ace-eggplant\theme.css#35659
              Hide
              Permalink
              yip.ng added a comment -

              All done.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\eggplant.jar#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\excite-bike.jar#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\flick.jar#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\pepper-grinder.jar#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\south-street.jar#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\start.jar#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-start\src\main\resources\META-INF\resources\ace-start\theme.css#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-vader\src\main\resources\META-INF\resources\ace-vader\theme.css#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-flick\src\main\resources\META-INF\resources\ace-flick\theme.css#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-pepper-grinder\src\main\resources\META-INF\resources\ace-pepper-grinder\theme.css#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-south-street\src\main\resources\META-INF\resources\ace-south-street\theme.css#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-eggplant\src\main\resources\META-INF\resources\ace-eggplant\theme.css#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-excite-bike\src\main\resources\META-INF\resources\ace-excite-bike\theme.css#35680
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\vader.jar#35680

              Show
              yip.ng added a comment - All done. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\eggplant.jar#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\excite-bike.jar#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\flick.jar#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\pepper-grinder.jar#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\south-street.jar#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\start.jar#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-start\src\main\resources\META-INF\resources\ace-start\theme.css#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-vader\src\main\resources\META-INF\resources\ace-vader\theme.css#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-flick\src\main\resources\META-INF\resources\ace-flick\theme.css#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-pepper-grinder\src\main\resources\META-INF\resources\ace-pepper-grinder\theme.css#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-south-street\src\main\resources\META-INF\resources\ace-south-street\theme.css#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-eggplant\src\main\resources\META-INF\resources\ace-eggplant\theme.css#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\themes\ace-excite-bike\src\main\resources\META-INF\resources\ace-excite-bike\theme.css#35680 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\samples\ace\themes\vader.jar#35680

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: