ICEfaces
  1. ICEfaces
  2. ICE-9293

Showcase - Application specific ACE "Rime"-theme styling issues

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.2
          • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
          • Component/s: ACE-Components, Sample Apps
          • Labels:
            None
          • Environment:
            ICEfaces 3.x, ICEfaces Showcase sample application, "Rime" ACE theme.
          • Assignee Priority:
            P1

            Description

            When using the ACE "Rime" theme in the ICEfaces Showcase there are a couple of application (and "Rime" theme) specific styling issues:

            1) The "Documentation" ace:menuButton text is extremely small.
            2) The Source Code view ace:panel expansion icons (+/-) are not vertically aligned.

            These issues are only present when the ACE "Rime" theme is selected via the themeSelector. All other themes are fine.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Ken Fyten added a comment -

              See the screen shot for an illustration of this issue (captured on Mac Safari).

              Show
              Ken Fyten added a comment - See the screen shot for an illustration of this issue (captured on Mac Safari).
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed fix at revision 35634. Added custom extensions to the rime theme for the showcase application. Since, we don't add a class name of the theme name anywhere on the page, it's not possible to know from the CSS code what theme is being used at the moment, so this couldn't be fixed in the showcase app's custom CSS, so I had to add some CSS rules in the rime theme itself that modify a few stylings for a couple of style classes used in the showcase app.

              Show
              Arturo Zambrano added a comment - Committed fix at revision 35634. Added custom extensions to the rime theme for the showcase application. Since, we don't add a class name of the theme name anywhere on the page, it's not possible to know from the CSS code what theme is being used at the moment, so this couldn't be fixed in the showcase app's custom CSS, so I had to add some CSS rules in the rime theme itself that modify a few stylings for a couple of style classes used in the showcase app.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              At revision 35654... removed custom showcase extensions to the rime theme; added technique to dynamically load rime theme extensions on the page only when such theme is in use.

              Show
              Arturo Zambrano added a comment - At revision 35654... removed custom showcase extensions to the rime theme; added technique to dynamically load rime theme extensions on the page only when such theme is in use.
              Hide
              Permalink
              Ken Fyten added a comment -

              Note that issue #2 is still present:

              2) The Source Code view ace:panel expansion icons (+/-) are not vertically aligned.

              Show
              Ken Fyten added a comment - Note that issue #2 is still present: 2) The Source Code view ace:panel expansion icons (+/-) are not vertically aligned.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Nils committed fix for documentation menu issues at revision 35664: Switched to in-flow layout. Aligns correctly with any font size (though 10pt font is currently set). Doesn't require rime specific style.

              Committed fix for source code panel header buttons at revision 35879. Added a minimum height, which fixed the problem in rime and doesn't affect the other themes.

              Show
              Arturo Zambrano added a comment - Nils committed fix for documentation menu issues at revision 35664: Switched to in-flow layout. Aligns correctly with any font size (though 10pt font is currently set). Doesn't require rime specific style. Committed fix for source code panel header buttons at revision 35879. Added a minimum height, which fixed the problem in rime and doesn't affect the other themes.

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: