ICEfaces
  1. ICEfaces
  2. ICE-9232

ACE generator allow for disinheriting properties from baseMeta

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.3
          • Fix Version/s: 4.0.BETA, EE-3.3.0.GA_P02, 4.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ace:checkboxButton
          • Assignee Priority:
            P1

            Description

            ace:checkboxButton and mobi:flipswitch, much like h:selectBoolanCheckbox and ice:selectBooleanCheckbox, extend from UISelectBoolean which extends from UIInput. But, those four components do not make use of a converter or validator, and required doesn't apply to them either. Therefore the properties for those as well as converterMessage, validatorMessage, requiredMessage do not apply for those components.

            We could take the idea originally conceived in ICE-5837, to allow for specifying a String[]disinheritProperties field in the @Component annotation, or we could tie into the newer @Only annotation, and have a NONE OnlyType that could keep that specific property from inheriting.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-9395 ace:comboBox > on events don't function

              • Major - Major loss of function.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. ICE-9665 Remove unsupported pass-through attributes from ACE *Entry Component TLD docs

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Mark Collette added a comment -

                Ted favours disinheritProperties.

                Show
                Mark Collette added a comment - Ted favours disinheritProperties.
                Hide
                Permalink
                Mark Collette added a comment -

                label might be another unnecessary property, in the absence of any FacesMessages being constructed.

                Show
                Mark Collette added a comment - label might be another unnecessary property, in the absence of any FacesMessages being constructed.
                Hide
                Permalink
                Judy Guglielmin added a comment -

                Use case tested was CheckboxButton....modify Component property as follows:-
                @Component(
                tagName = "checkboxButton",
                componentClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButton",
                rendererClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButtonRenderer",
                generatedClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButtonBase",
                extendsClass = "javax.faces.component.UISelectBoolean",
                componentType = "org.icefaces.ace.component.CheckboxButton",
                rendererType = "org.icefaces.ace.component.CheckboxButtonRenderer",
                componentFamily= "org.icefaces.ace.CheckboxButton",
                disinheritProperties =

                {"validator","validatorMessage", "converter", "converterMessage"}

                ,
                tlddoc="The Checkbox Button is a component that allows entry of a button which "+
                "supports browsers that see checkbox as true or false, "+
                "yes or no, on or off. The Themeroller check icon will be displayed by default when the checkbox is checked. Override the .ui-icon-check class to display a different image." +
                "<p>For more information, see the <a href=\"http://wiki.icefaces.org/display/ICE/CheckboxButton\">CheckboxButton Wiki Documentation</a>."
                )

                Show
                Judy Guglielmin added a comment - Use case tested was CheckboxButton....modify Component property as follows:- @Component( tagName = "checkboxButton", componentClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButton", rendererClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButtonRenderer", generatedClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButtonBase", extendsClass = "javax.faces.component.UISelectBoolean", componentType = "org.icefaces.ace.component.CheckboxButton", rendererType = "org.icefaces.ace.component.CheckboxButtonRenderer", componentFamily= "org.icefaces.ace.CheckboxButton", disinheritProperties = {"validator","validatorMessage", "converter", "converterMessage"} , tlddoc="The Checkbox Button is a component that allows entry of a button which "+ "supports browsers that see checkbox as true or false, "+ "yes or no, on or off. The Themeroller check icon will be displayed by default when the checkbox is checked. Override the .ui-icon-check class to display a different image." + "<p>For more information, see the <a href=\"http://wiki.icefaces.org/display/ICE/CheckboxButton\">CheckboxButton Wiki Documentation</a>." )
                Hide
                Permalink
                Judy Guglielmin added a comment -

                rev. 38535 has ability now to disinherit properties that are inherited from super classes. Does not affect base class or interface. Just the support Tag class.

                Show
                Judy Guglielmin added a comment - rev. 38535 has ability now to disinherit properties that are inherited from super classes. Does not affect base class or interface. Just the support Tag class.
                Hide
                Permalink
                Judy Guglielmin added a comment -

                backport to 3.3.0 mtce branch

                Show
                Judy Guglielmin added a comment - backport to 3.3.0 mtce branch
                Hide
                Permalink
                Judy Guglielmin added a comment -

                rev 40239 for backport to 3.3.0 mtce branch

                Show
                Judy Guglielmin added a comment - rev 40239 for backport to 3.3.0 mtce branch

                  People

                  • Assignee:
                    Judy Guglielmin
                    Reporter:
                    Mark Collette
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: