[ICE-9232] ACE generator allow for disinheriting properties from baseMeta - ICEsoft JIRA Issue Tracker

Details

Type: New Feature
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.3
Fix Version/s: 4.0.BETA, EE-3.3.0.GA_P02, 4.0
Component/s: ACE-Components
Labels:
None
Environment:
ace:checkboxButton

Assignee Priority:
P1

Description

ace:checkboxButton and mobi:flipswitch, much like h:selectBoolanCheckbox and ice:selectBooleanCheckbox, extend from UISelectBoolean which extends from UIInput. But, those four components do not make use of a converter or validator, and required doesn't apply to them either. Therefore the properties for those as well as converterMessage, validatorMessage, requiredMessage do not apply for those components.

We could take the idea originally conceived in ~~ICE-5837~~, to allow for specifying a String[]disinheritProperties field in the @Component annotation, or we could tie into the newer @Only annotation, and have a NONE OnlyType that could keep that specific property from inheriting.

Issue Links

blocks

ICE-9395 ace:comboBox > on events don't function

Closed

ICE-9665 Remove unsupported pass-through attributes from ACE *Entry Component TLD docs

Closed

Activity

Ascending order - Click to sort in descending order

Mark Collette created issue - 02/May/13 1:41 PM

Hide

Permalink

Mark Collette added a comment - 02/May/13 2:43 PM

Ted favours disinheritProperties.

Show

Mark Collette added a comment - 02/May/13 2:43 PM Ted favours disinheritProperties.

Mark Collette made changes - 02/May/13 2:43 PM

Field	Original Value	New Value
Description	ace:checkboxButton, much like h:selectBoolanCheckbox and ice:selectBooleanCheckbox, extends from UISelectBoolean which extends from UIInput. But, those three components do not make use of a converter or validator, and required doesn't apply to them either. Therefore the properties for those as well as converterMessage, validatorMessage, requiredMessage do not apply for those components. We could take the idea originally conceived in ~~ICE-5837~~, to allow for specifying a String[]disinheritProperties field in the @Component annotation, or we could tie into the newer @Only annotation, and have a NONE OnlyType that could keep that specific property from inheriting.	ace:checkboxButton and mobi:flipswitch, much like h:selectBoolanCheckbox and ice:selectBooleanCheckbox, extend from UISelectBoolean which extends from UIInput. But, those four components do not make use of a converter or validator, and required doesn't apply to them either. Therefore the properties for those as well as converterMessage, validatorMessage, requiredMessage do not apply for those components. We could take the idea originally conceived in ~~ICE-5837~~, to allow for specifying a String[]disinheritProperties field in the @Component annotation, or we could tie into the newer @Only annotation, and have a NONE OnlyType that could keep that specific property from inheriting.

Hide

Permalink

Mark Collette added a comment - 02/May/13 4:14 PM

label might be another unnecessary property, in the absence of any FacesMessages being constructed.

Show

Mark Collette added a comment - 02/May/13 4:14 PM label might be another unnecessary property, in the absence of any FacesMessages being constructed.

Mark Collette made changes - 01/Jun/13 1:21 AM

Assignee

Mark Collette [ mark.collette ]

Mark Collette made changes - 01/Jun/13 1:21 AM

Fix Version/s

3.4 [ 10770 ]

Mark Collette made changes - 01/Jun/13 1:22 AM

Assignee Priority

P3 [ 10012 ]

Arturo Zambrano made changes - 08/Aug/13 5:48 PM

Link

This issue blocks ~~ICE-9395~~ [ ~~ICE-9395~~ ]

Ken Fyten made changes - 26/Sep/13 4:01 PM

Assignee	Mark Collette [ mark.collette ]	Judy Guglielmin [ judy.guglielmin ]
Assignee Priority	P3 [ 10012 ]	P1 [ 10010 ]

Hide

Permalink

Judy Guglielmin added a comment - 07/Oct/13 10:40 AM

Use case tested was CheckboxButton....modify Component property as follows:-
@Component(
tagName = "checkboxButton",
componentClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButton",
rendererClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButtonRenderer",
generatedClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButtonBase",
extendsClass = "javax.faces.component.UISelectBoolean",
componentType = "org.icefaces.ace.component.CheckboxButton",
rendererType = "org.icefaces.ace.component.CheckboxButtonRenderer",
componentFamily= "org.icefaces.ace.CheckboxButton",
disinheritProperties =

{"validator","validatorMessage", "converter", "converterMessage"}

,
tlddoc="The Checkbox Button is a component that allows entry of a button which "+
"supports browsers that see checkbox as true or false, "+
"yes or no, on or off. The Themeroller check icon will be displayed by default when the checkbox is checked. Override the .ui-icon-check class to display a different image." +
"<p>For more information, see the <a href=\"http://wiki.icefaces.org/display/ICE/CheckboxButton\">CheckboxButton Wiki Documentation</a>."
)

Show

Judy Guglielmin added a comment - 07/Oct/13 10:40 AM Use case tested was CheckboxButton....modify Component property as follows:- @Component( tagName = "checkboxButton", componentClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButton", rendererClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButtonRenderer", generatedClass = "org.icefaces.ace.component.checkboxbutton.CheckboxButtonBase", extendsClass = "javax.faces.component.UISelectBoolean", componentType = "org.icefaces.ace.component.CheckboxButton", rendererType = "org.icefaces.ace.component.CheckboxButtonRenderer", componentFamily= "org.icefaces.ace.CheckboxButton", disinheritProperties = {"validator","validatorMessage", "converter", "converterMessage"} , tlddoc="The Checkbox Button is a component that allows entry of a button which "+ "supports browsers that see checkbox as true or false, "+ "yes or no, on or off. The Themeroller check icon will be displayed by default when the checkbox is checked. Override the .ui-icon-check class to display a different image." + "<p>For more information, see the <a href=\"http://wiki.icefaces.org/display/ICE/CheckboxButton\">CheckboxButton Wiki Documentation</a>." )

Hide

Permalink

Judy Guglielmin added a comment - 07/Oct/13 10:41 AM

rev. 38535 has ability now to disinherit properties that are inherited from super classes. Does not affect base class or interface. Just the support Tag class.

Show

Judy Guglielmin added a comment - 07/Oct/13 10:41 AM rev. 38535 has ability now to disinherit properties that are inherited from super classes. Does not affect base class or interface. Just the support Tag class.

Judy Guglielmin made changes - 07/Oct/13 10:41 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#38535	Mon Oct 07 10:43:05 MDT 2013	judy.guglielmin	~~ICE-9232~~
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/TagHandlerContext.java MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/InterfaceContext.java MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentArtifact.java MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/meta/annotation/Component.java MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/utils/FileWriter.java MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/MetaContext.java MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/JSPContext.java MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/GeneratorContext.java MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/ComponentContext.java

Ken Fyten made changes - 25/Oct/13 5:02 PM

Link

This issue blocks ~~ICE-9665~~ [ ~~ICE-9665~~ ]

Hide

Permalink

Judy Guglielmin added a comment - 05/Mar/14 11:10 AM

backport to 3.3.0 mtce branch

Show

Judy Guglielmin added a comment - 05/Mar/14 11:10 AM backport to 3.3.0 mtce branch

Judy Guglielmin made changes - 05/Mar/14 11:10 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Judy Guglielmin made changes - 05/Mar/14 11:10 AM

Fix Version/s

EE-3.3.0.GA_P02 [ 11371 ]

Hide

Permalink

Judy Guglielmin added a comment - 05/Mar/14 11:29 AM

rev 40239 for backport to 3.3.0 mtce branch

Show

Judy Guglielmin added a comment - 05/Mar/14 11:29 AM rev 40239 for backport to 3.3.0 mtce branch

Judy Guglielmin made changes - 05/Mar/14 11:29 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 30/Oct/14 11:29 AM

Fix Version/s

4.0 [ 11382 ]

Ken Fyten made changes - 14/Nov/14 5:19 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Judy Guglielmin

Reporter:

Mark Collette

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

02/May/13 1:41 PM

Updated:

14/Nov/14 5:19 PM

Resolved:

05/Mar/14 11:29 AM