ICEfaces
  1. ICEfaces
  2. ICE-9097

Add support for different types of URL encodings in ace:menuItem

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Any
          • Assignee Priority:
            P2

            Description

            Motivated by the investigation done for ICE-8982, it is necessary to add support for different types of URL encodings in ace:menuItem, including a no-encoding case.

            Each type should correspond to an encoding method in ExternalContext:
                public String encodeActionURL
                public String encodeResourceURL
                public String encodeBookmarkableURL
                public String encodeRedirectURL
                public String encodePartialActionURL

              Issue Links

              depends on

              Bug - A problem which impairs or prevents the functions of the product. ICE-8982 WARNING: JSF1091: No mime type could be found for file logged by showcase with ace:fileEntry demo

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Ken Fyten added a comment -

                [13-03-21 1:18:25 PM] Mark Collette: Oh ok. Plus we should update showcase to use the new property when it's added

                Show
                Ken Fyten added a comment - [13-03-21 1:18:25 PM] Mark Collette: Oh ok. Plus we should update showcase to use the new property when it's added
                Hide
                Permalink
                Ken Fyten added a comment -

                Raising priority since this causes nasty warnings to be logged in showcase sample.

                Show
                Ken Fyten added a comment - Raising priority since this causes nasty warnings to be logged in showcase sample.
                Hide
                Permalink
                Arturo Zambrano added a comment - - edited

                Committed improvement at revision 35621. Added 'urlEncoding' and 'urlParameters' attributes to ace:menuItem. Added support for 'resource', 'action', 'partialaction', 'bookmarkable', 'redirect', and 'none' encodings. The utility function itself is in CoreRenderer.java, so that it can be reused.

                Modified content-template.xhtml in the showcase app, at revision 35622, to use the 'none' encoding in order to avoid the warning reported in ICE-8982.

                Show
                Arturo Zambrano added a comment - - edited Committed improvement at revision 35621. Added 'urlEncoding' and 'urlParameters' attributes to ace:menuItem. Added support for 'resource', 'action', 'partialaction', 'bookmarkable', 'redirect', and 'none' encodings. The utility function itself is in CoreRenderer.java, so that it can be reused. Modified content-template.xhtml in the showcase app, at revision 35622, to use the 'none' encoding in order to avoid the warning reported in ICE-8982 .
                Hide
                Permalink
                Carmen Cristurean added a comment -

                Confirming that the warning reported in ICE-8982 doesn't appear anymore in Mojarra (verified with rev#. 35652 in Firefox21).

                Show
                Carmen Cristurean added a comment - Confirming that the warning reported in ICE-8982 doesn't appear anymore in Mojarra (verified with rev#. 35652 in Firefox21).

                  People

                  • Assignee:
                    Arturo Zambrano
                    Reporter:
                    Arturo Zambrano
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: