ICEfaces
  1. ICEfaces
  2. ICE-9097

Add support for different types of URL encodings in ace:menuItem

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Any
          • Assignee Priority:
            P2

            Description

            Motivated by the investigation done for ICE-8982, it is necessary to add support for different types of URL encodings in ace:menuItem, including a no-encoding case.

            Each type should correspond to an encoding method in ExternalContext:
                public String encodeActionURL
                public String encodeResourceURL
                public String encodeBookmarkableURL
                public String encodeRedirectURL
                public String encodePartialActionURL

              Issue Links

              depends on

              Bug - A problem which impairs or prevents the functions of the product. ICE-8982 WARNING: JSF1091: No mime type could be found for file logged by showcase with ace:fileEntry demo

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Arturo Zambrano created issue -
                Arturo Zambrano made changes -
                Field Original Value New Value
                Link This issue depends on ICE-8982 [ ICE-8982 ]
                Arturo Zambrano made changes -
                Assignee Arturo Zambrano [ artzambrano ]
                Hide
                Permalink
                Ken Fyten added a comment -

                [13-03-21 1:18:25 PM] Mark Collette: Oh ok. Plus we should update showcase to use the new property when it's added

                Show
                Ken Fyten added a comment - [13-03-21 1:18:25 PM] Mark Collette: Oh ok. Plus we should update showcase to use the new property when it's added
                Ken Fyten made changes -
                Fix Version/s 3.4 [ 10770 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                Raising priority since this causes nasty warnings to be logged in showcase sample.

                Show
                Ken Fyten added a comment - Raising priority since this causes nasty warnings to be logged in showcase sample.
                Ken Fyten made changes -
                Assignee Priority P2 [ 10011 ]
                Ken Fyten made changes -
                Fix Version/s EE-3.3.0.GA [ 10572 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #35621 Mon May 27 12:15:41 MDT 2013 art.zambrano ICE-9097 added support for different types of URL encodings in ace:menuItem
                Files Changed
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menuitem/MenuItemMeta.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/renderkit/CoreRenderer.java
                Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #35622 Mon May 27 12:22:34 MDT 2013 art.zambrano ICE-9097 added 'urlEncoding' attribute to documentation menu items to avoid warning in mojarra (ICE-8982)
                Files Changed
                Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/templates/content-template.xhtml
                Hide
                Permalink
                Arturo Zambrano added a comment - - edited

                Committed improvement at revision 35621. Added 'urlEncoding' and 'urlParameters' attributes to ace:menuItem. Added support for 'resource', 'action', 'partialaction', 'bookmarkable', 'redirect', and 'none' encodings. The utility function itself is in CoreRenderer.java, so that it can be reused.

                Modified content-template.xhtml in the showcase app, at revision 35622, to use the 'none' encoding in order to avoid the warning reported in ICE-8982.

                Show
                Arturo Zambrano added a comment - - edited Committed improvement at revision 35621. Added 'urlEncoding' and 'urlParameters' attributes to ace:menuItem. Added support for 'resource', 'action', 'partialaction', 'bookmarkable', 'redirect', and 'none' encodings. The utility function itself is in CoreRenderer.java, so that it can be reused. Modified content-template.xhtml in the showcase app, at revision 35622, to use the 'none' encoding in order to avoid the warning reported in ICE-8982 .
                Arturo Zambrano made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Component/s ACE-Components [ 10050 ]
                Hide
                Permalink
                Carmen Cristurean added a comment -

                Confirming that the warning reported in ICE-8982 doesn't appear anymore in Mojarra (verified with rev#. 35652 in Firefox21).

                Show
                Carmen Cristurean added a comment - Confirming that the warning reported in ICE-8982 doesn't appear anymore in Mojarra (verified with rev#. 35652 in Firefox21).
                Ken Fyten made changes -
                Fix Version/s 4.0 [ 11382 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]

                  People

                  • Assignee:
                    Arturo Zambrano
                    Reporter:
                    Arturo Zambrano
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: