ICEfaces
  1. ICEfaces
  2. ICE-8932

ice:menuPopup - Incorrect positioning when used in Liferay

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.0.0.GA_P01, 3.2, EE-3.2.0.BETA
    • Fix Version/s: 3.3
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Liferay 6.x
    • Assignee Priority:
      P1

      Description

      When displaying an ice:menuPopup, the positioning of the popup is off likely due to the position:relative usage of Liferay.

      This issue had been addressed in ICE-2967 but these workaround don't seem to work for LIferay 6.x
      1. MenuPopupPositioningIssue.zip
        34 kB
        Arran Mccullough

        Activity

        Hide
        Arran Mccullough added a comment -

        Attached test case that shows the issue.

        Steps:

        • Load the portlet page.
        • Right click on the tree nodes and a menuPopup is displayed far away from where it should.
        Show
        Arran Mccullough added a comment - Attached test case that shows the issue. Steps: Load the portlet page. Right click on the tree nodes and a menuPopup is displayed far away from where it should.
        Hide
        Arran Mccullough added a comment -

        Attached a customized compat jar that has changes to resolve the positioning.

        Show
        Arran Mccullough added a comment - Attached a customized compat jar that has changes to resolve the positioning.
        Hide
        Arturo Zambrano added a comment -

        Committed fix to trunk at revision 33743.

        First we check if these additional calculations are necessary by checking if the offset parent of the submenu is different than the body element. In such case these additional calculations are necessary for taking into account this offset parent, otherwise they aren't necessary.

        Show
        Arturo Zambrano added a comment - Committed fix to trunk at revision 33743. First we check if these additional calculations are necessary by checking if the offset parent of the submenu is different than the body element. In such case these additional calculations are necessary for taking into account this offset parent, otherwise they aren't necessary.
        Hide
        Arturo Zambrano added a comment -

        Testing notes:
        Just verify that the popup menu is correctly positioned in Liferay 6 and 5, as well as in the non-portlet component-showcase app. Also, run all related regression tests for this component to verify that this fix doesn't affect the positioning in other scenarios.

        Show
        Arturo Zambrano added a comment - Testing notes: Just verify that the popup menu is correctly positioned in Liferay 6 and 5, as well as in the non-portlet component-showcase app. Also, run all related regression tests for this component to verify that this fix doesn't affect the positioning in other scenarios.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: