ICEfaces
  1. ICEfaces
  2. ICE-8932

ice:menuPopup - Incorrect positioning when used in Liferay

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.0.0.GA_P01, 3.2, EE-3.2.0.BETA
    • Fix Version/s: 3.3
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Liferay 6.x
    • Assignee Priority:
      P1

      Description

      When displaying an ice:menuPopup, the positioning of the popup is off likely due to the position:relative usage of Liferay.

      This issue had been addressed in ICE-2967 but these workaround don't seem to work for LIferay 6.x
      1. MenuPopupPositioningIssue.zip
        34 kB
        Arran Mccullough

        Activity

        Arran Mccullough created issue -
        Hide
        Arran Mccullough added a comment -

        Attached test case that shows the issue.

        Steps:

        • Load the portlet page.
        • Right click on the tree nodes and a menuPopup is displayed far away from where it should.
        Show
        Arran Mccullough added a comment - Attached test case that shows the issue. Steps: Load the portlet page. Right click on the tree nodes and a menuPopup is displayed far away from where it should.
        Arran Mccullough made changes -
        Field Original Value New Value
        Attachment MenuPopupPositioningIssue.zip [ 15386 ]
        Attachment MenuPopupPositioningIssue.war [ 15387 ]
        Hide
        Arran Mccullough added a comment -

        Attached a customized compat jar that has changes to resolve the positioning.

        Show
        Arran Mccullough added a comment - Attached a customized compat jar that has changes to resolve the positioning.
        Arran Mccullough made changes -
        Attachment icefaces-ee-compat.jar [ 15388 ]
        Ken Fyten made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Fix Version/s 3.3 [ 10370 ]
        Assignee Priority P2 [ 10011 ]
        Ken Fyten made changes -
        Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #33743 Mon Mar 04 12:55:46 MST 2013 art.zambrano ICE-8932 committed fix to take into account the offset parent (if any) to calculate the correct position of the submenu
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
        Hide
        Arturo Zambrano added a comment -

        Committed fix to trunk at revision 33743.

        First we check if these additional calculations are necessary by checking if the offset parent of the submenu is different than the body element. In such case these additional calculations are necessary for taking into account this offset parent, otherwise they aren't necessary.

        Show
        Arturo Zambrano added a comment - Committed fix to trunk at revision 33743. First we check if these additional calculations are necessary by checking if the offset parent of the submenu is different than the body element. In such case these additional calculations are necessary for taking into account this offset parent, otherwise they aren't necessary.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Arturo Zambrano added a comment -

        Testing notes:
        Just verify that the popup menu is correctly positioned in Liferay 6 and 5, as well as in the non-portlet component-showcase app. Also, run all related regression tests for this component to verify that this fix doesn't affect the positioning in other scenarios.

        Show
        Arturo Zambrano added a comment - Testing notes: Just verify that the popup menu is correctly positioned in Liferay 6 and 5, as well as in the non-portlet component-showcase app. Also, run all related regression tests for this component to verify that this fix doesn't affect the positioning in other scenarios.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: