[ICE-8577] focus is lost on the form on the first update - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Trivial
Resolution: Won't Fix
Affects Version/s: 3.1, EE-3.0.0.GA_P01, 3.2.BETA1
Fix Version/s: 3.3
Component/s: Bridge, Framework
Labels:
None
Environment:
All

Assignee Priority:
P2
Workaround Description:

Hide
As a workaround the web application can be configured to use an index JSP page that redirects the browser to the JSF page (where this issue occurs). During the redirect the browser will acquire the session tracking cookie. The request for the JSF page will then have this cookie thus prompting the server to generate URLs in the markup without the jsessionid parameter. Because URL format does not change anymore between requests the server will not generate large updates which cause the focus lost problem.

Show
As a workaround the web application can be configured to use an index JSP page that redirects the browser to the JSF page (where this issue occurs). During the redirect the browser will acquire the session tracking cookie. The request for the JSF page will then have this cookie thus prompting the server to generate URLs in the markup without the jsessionid parameter. Because URL format does not change anymore between requests the server will not generate large updates which cause the focus lost problem.

Description

On the first update of an input element (through singleSubmit or f:ajax) the focus is lost. Setting the tabindex doesn't have any impact on this. Once this first update is made the focus and tabing works without any issues.

A few things I noticed:
- This can only be seen when first loading the app in a fresh browser instance. If the tab is closed and then the page is accessed again in a new tab, this isn't an issue. To re-test this the browser needs to be closed and then re-opened between tests.
- Once the page is displayed initially, if I refresh the page without doing an update, this issue isn't seen.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
Case11612Example.war

30/Nov/12 11:32 PM

9.59 MB

Migration
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/com/.../example/Item.class 0.3 kB

WEB-INF/classes/.../example/TestBean.class 1 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/icefaces-ace.jar 3.13 MB

WEB-INF/lib/icefaces-compat.jar 2.68 MB

WEB-INF/lib/icefaces.jar 341 kB

WEB-INF/lib/javax.faces.jar 2.48 MB

WEB-INF/web.xml 2 kB

welcomeICEfaces.xhtml 2 kB

Download Zip
Show

Case11612Example.war

30/Nov/12 11:32 PM

9.59 MB

Migration

Issue Links

depends on

ICE-7803 Add ability to update specific attributes in the user DOM not whole elements

Closed

is duplicated by

ICE-8906 icecore:singleSubmit - default radio button selection is lost

Closed

Activity

Ascending order - Click to sort in descending order

Migration created issue - 18/Sep/12 4:32 PM

Hide

Permalink

Arran Mccullough added a comment - 18/Sep/12 4:36 PM - edited

Attached test case that shows this issue.

Steps:

In a new browser instance open welcomeICEfaces.jsf
Focus into the first input field, enter in some text.
Hit the Tab key, focus is lost when it should be on the next input field.

Show

Arran Mccullough added a comment - 18/Sep/12 4:36 PM - edited Attached test case that shows this issue. Steps: In a new browser instance open welcomeICEfaces.jsf Focus into the first input field, enter in some text. Hit the Tab key, focus is lost when it should be on the next input field.

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#31558	Wed Oct 17 16:58:58 MDT 2012	mircea.toma	~~ICE-8577~~ Use document.activeElement property to check if the focus really needs to be applied to an element. When the focus is already on the element that needs to receive focus ice.applyFocus function call will just ignore the request.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/core/src/main/javascript/focus.js

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#31559	Wed Oct 17 17:15:30 MDT 2012	mircea.toma	~~ICE-8577~~ Use document.activeElement property to check if the focus really needs to be applied to an element. When the focus is already on the element that needs to receive focus ice.applyFocus function call will just ignore the request.
				Files Changed
				MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/core/src/main/javascript/focus.js

Hide

Permalink

Mircea Toma added a comment - 17/Oct/12 10:55 PM - edited

There's a larger update generated because the URLs contained by the forms have appended the jsessionid path parameter during first page load but they are missing when the first update is generated.

Show

Mircea Toma added a comment - 17/Oct/12 10:55 PM - edited There's a larger update generated because the URLs contained by the forms have appended the jsessionid path parameter during first page load but they are missing when the first update is generated.

Hide

Permalink

Mircea Toma added a comment - 17/Oct/12 10:59 PM - edited

Use document.activeElement property (supported now by ie7, ie8, ie9, safari, opera and firefox) to check if the focus really needs to be applied to an element. When the focus is already on the element that needs to receive focus ice.applyFocus function call will just ignore the request.

Show

Mircea Toma added a comment - 17/Oct/12 10:59 PM - edited Use document.activeElement property (supported now by ie7, ie8, ie9, safari, opera and firefox) to check if the focus really needs to be applied to an element. When the focus is already on the element that needs to receive focus ice.applyFocus function call will just ignore the request.

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#31653	Mon Oct 22 15:03:12 MDT 2012	ken.fyten	~~ICE-8577~~ Revert commit from svn rvn#1558 as it's causing a regression with ace:dateTimeEntry by setting focus on the already focussed input element.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/core/src/main/javascript/focus.js

Hide

Permalink

Ken Fyten added a comment - 22/Oct/12 9:05 PM - edited

Reverted commit for this as it is causing the following regression behavior:
New Regression:
Showcase (Firefox 16/Tomcat 7):
Manual Test Results:
dateTimeEntry - Ajax Submit, Label Position, Indicator Text: after selecting new date in the popup calendar, the calendar closes and opens up again (not a PartialStateSavings specific issue).

Show

Ken Fyten added a comment - 22/Oct/12 9:05 PM - edited Reverted commit for this as it is causing the following regression behavior: New Regression: Showcase (Firefox 16/Tomcat 7): Manual Test Results: dateTimeEntry - Ajax Submit, Label Position, Indicator Text: after selecting new date in the popup calendar, the calendar closes and opens up again (not a PartialStateSavings specific issue).

Migration made changes - 29/Nov/12 9:38 PM

Field	Original Value	New Value
Reporter	Migration [ remote ]	Arran Mccullough [ arran.mccullough ]

Migration made changes - 29/Nov/12 9:45 PM

Assignee		Mircea Toma [ mircea.toma ]
Fix Version/s		3.2 [ 10338 ]
Priority	Major [ 3 ]	Trivial [ 5 ]
Assignee Priority		P2 [ 10011 ]

Migration made changes - 29/Nov/12 10:31 PM

Fix Version/s		3.3 [ 10370 ]
Fix Version/s	3.2 [ 10338 ]

Migration made changes - 30/Nov/12 12:23 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Migration made changes - 30/Nov/12 12:36 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Migration made changes - 30/Nov/12 10:03 PM

Fix Version/s		3.2 [ 10338 ]
Fix Version/s	3.3 [ 10370 ]

Migration made changes - 30/Nov/12 10:07 PM

Fix Version/s		3.3 [ 10370 ]
Fix Version/s	3.2 [ 10338 ]

Migration made changes - 30/Nov/12 11:32 PM

Attachment

Case11612Example.war [ 14947 ]

Ken Fyten made changes - 13/Dec/12 6:25 PM

Assignee Priority

P2 [ 10011 ]

P3 [ 10012 ]

Ken Fyten made changes - 23/Jan/13 5:42 PM

Assignee Priority

P3 [ 10012 ]

P2 [ 10011 ]

Mircea Toma made changes - 30/Jan/13 12:15 AM

Workaround Description

As a workaround the web application can be configured to use an index JSP page that redirects the browser to the JSF page (where this issue occurs). During the redirect the browser will acquire the session tracking cookie. The request for the JSF page will then have this cookie thus prompting the server to generate URLs in the markup without the jsessionid parameter. Because URL format does not change anymore between requests the server will not generate large updates which cause the focus lost problem.

Hide

Permalink

Mircea Toma added a comment - 30/Jan/13 12:17 AM - edited

This issue can be fixed if the attribute update generation in the DOM diff is enabled. Hopefully this approach will finally work well in the newer version of Mojarra.

Show

Mircea Toma added a comment - 30/Jan/13 12:17 AM - edited This issue can be fixed if the attribute update generation in the DOM diff is enabled. Hopefully this approach will finally work well in the newer version of Mojarra.

Hide

Permalink

Mircea Toma added a comment - 31/Jan/13 9:20 PM

Unfortunately updating attributes in IE doesn't always work. For example in showcase the "class" attributes on navigation links are not changed correctly.

Show

Mircea Toma added a comment - 31/Jan/13 9:20 PM Unfortunately updating attributes in IE doesn't always work. For example in showcase the "class" attributes on navigation links are not changed correctly.

Mircea Toma made changes - 04/Feb/13 11:35 AM

Link

This issue is duplicated by ~~ICE-8906~~ [ ~~ICE-8906~~ ]

Ken Fyten made changes - 13/Feb/13 6:59 PM

Link

This issue depends on ICE-8430 [ ICE-8430 ]

Mircea Toma made changes - 18/Feb/13 2:27 PM

Link

This issue depends on ~~ICE-7803~~ [ ~~ICE-7803~~ ]

Hide

Permalink

Mircea Toma added a comment - 06/Mar/13 8:50 PM - edited

ICE-8430 is now fixed. Running an application with org.icefaces.diffConfig=att should alleviate any focus related problems.

Show

Mircea Toma added a comment - 06/Mar/13 8:50 PM - edited ICE-8430 is now fixed. Running an application with org.icefaces.diffConfig=att should alleviate any focus related problems.

Mircea Toma made changes - 06/Mar/13 8:50 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Won't Fix [ 2 ]

Ken Fyten made changes - 14/Nov/14 5:39 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Mircea Toma

Reporter:

Arran Mccullough

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

18/Sep/12 4:32 PM

Updated:

14/Nov/14 5:39 PM

Resolved:

06/Mar/13 8:50 PM