Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.1.0.BETA1
-
Fix Version/s: 3.1
-
Component/s: QA, Sample Apps
-
Labels:None
-
Environment:ICEfaces3/trunk rev. 29153
Browsers: IE7, Firefox3.6/12, Chrome19
Server: Tomcat6
-
Assignee Priority:P1
Description
Firefox/Chrome:
Internet Explorer:
Sample Applications:
1) elementUpdate:
Firefox and Chrome: InputElementsCommon - times out waiting for Attribute after clicking on 'Class Name' button. Fails manually when testing common "className" attribute.
2) auctionMonitor:
Chrome:
Rendering issue, when clicking to bid on an item a yellow rectangle renders, highlighting the first row in the table. This cannot be removed until clicking outside the bid table, as example to sort items by bids. Screenshot attached, auctionMonitor-render.png.
Firefox:
chat fails; first user that joins chat cannot send a message.
Internet Explorer:
chat fails, a JS error happens when user1 clicks to join chat. (attachment chat-IE.png)
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
These are the additional ACE failures due to the Mojarra upgrade:
New failures:
Chrome / Firefox: tooltip, slider, resizable, pushButton, progressBar, panel, maskedEntry, notificationPanel, linkButton, draggableDroppable, dialog, dateTimeEntry, dataTable, dataExporter, checkboxButton
(All ajax tests fail manually for the above componenets. The value inside the input text does not always get updated on the page when the ajax listener is called or when resetting the values)
Test apps are located at: http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly
The above failures are also reproducible using http://server.ice:8888/svn/ossrepo/icefaces3/scratchpads/ICE-8156, which is svn rvn #29500 (pre-dates resource loading changes) with Mojarra 2.1.9 (patched). So this would indicate that the patch does not resolve the issues above.
I cannot run the ajax test of any of the mentioned test applications. The following exception is thrown on the server:
javax.servlet.ServletException: /tooltipAjax.xhtml: Property 'ajaxEventListener' not found on type org.icefaces.tooltip.AjaxTestBean
javax.faces.webapp.FacesServlet.service(FacesServlet.java:606)
root cause
javax.el.ELException: /tooltipAjax.xhtml: Property 'ajaxEventListener' not found on type org.icefaces.tooltip.AjaxTestBean
com.sun.faces.facelets.compiler.AttributeInstruction.write(AttributeInstruction.java:94)
com.sun.faces.facelets.compiler.UIInstructions.encodeBegin(UIInstructions.java:82)
com.sun.faces.facelets.compiler.UILeaf.encodeAll(UILeaf.java:183)
javax.faces.render.Renderer.encodeChildren(Renderer.java:168)
org.icefaces.impl.renderkit.RendererWrapper.encodeChildren(RendererWrapper.java:49)
javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:845)
com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.encodeRecursive(HtmlBasicRenderer.java:304)
com.sun.faces.renderkit.html_basic.GroupRenderer.encodeChildren(GroupRenderer.java:105)
javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:845)
According to ICE-8156, the following tests still show regressions when comparing Mojarra 2.1.6 to 2.1.9:
ICE-2113: A quick test shows that it's working fine when run on WebKit browsers (Safari and Chrome) but the popup panel is displaying blank for me when running on Firefox or IE. If I back out the Mojarra version to 2.1.6, I get the same issue with IE and FF where the popup doesn't display anything. Not convinced that this is a Mojarra related-regression at this point. Inspecting the HTML in Firebug, I can see that the content for the panel popup is contained in the div, it's just having troubles displaying it. Perhaps it's missing a resource (although there are no errors on the client or the server).
ICE-3190: This works fine for me in both Chrome and Firefox using the latest from the trunk (r29668) which includes the patched version of Mojarra 2.1.9.
ICE-4137: This works fine for me in both Chrome and Firefox using the latest from the trunk (r29668) which includes the patched version of Mojarra 2.1.9.
Patch from ICE-8156 resolves the last of these issues.
So looks like at least some of the issues are our own fault. Changes were made to jsf.js as per:
http://java.net/jira/browse/JAVASERVERFACES-2381
We submitted this as part of suggested fix to help with our own DOM diff work but I can't find the specific case. Perhaps this one:
http://jira.icesoft.org/browse/ICE-7803
In any event, the change was to how the attributes of a DOM node where retrieved and compared. Here's the relevant diff:
[deryk] resources > svn diff -r9903:9904 jsf.js
Index: jsf.js
===================================================================
— jsf.js (revision 9903)
+++ jsf.js (revision 9904)
@@ -691,8 +691,8 @@
// First, copy over core attributes
for (iIndex = 0,iLength = coreElementAttributes.length; iIndex < iLength; iIndex++) {
attributeName = coreElementAttributes[iIndex];
+ newValue = source.getAttribute(attributeName);
+ oldValue = target.getAttribute(attributeName);
if (oldValue != newValue) { target[attributeName] = newValue; }
@@ -702,8 +702,8 @@
if (target.nodeName.toLowerCase() === 'input') {
for (iIndex = 0,iLength = inputElementAttributes.length; iIndex < iLength; iIndex++) {
attributeName = inputElementAttributes[iIndex];
+ newValue = source.getAttribute(attributeName);
+ oldValue = target.getAttribute(attributeName);
if (oldValue != newValue) { target[attributeName] = newValue; }
The problem is that some attributes exist that can only be retrieved the "old" way. For example, if I try to get "className":
var theInputText = document.getElementById('j_idt22:in');
<input class="A" id="j_idt22:in" lang="en" name="j_idt22:in" size="15" style title="A" type="text" value="A">
theInputText['className'];
"A"
theInputText.getAttribute('className');
null
This is because "className" is a hard attribute of the node in the DOM, but "className" is not in the collection of attributes. In that collection, it's called "class".