Details
-
Type:
Task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.8.2, EE-1.8.2.GA_P03
-
Fix Version/s: EE-1.8.2.GA_P04
-
Component/s: Framework
-
Labels:None
-
Environment:Source code comments only.
-
Community Contribution:Yes
Description
h2. Changes Requested
As part of the review for the *Eclipse Process Manager* a.k.a. _Stardust_ (see http://www.eclipse.org/stardust and http://www.eclipse.org/proposals/soa.stardust/), some very minor changes in the ICEfaces library were suggested by the Eclipse review team. The web portals for _Stardust_ are based on *ICEfaces 1.8.2*.
The good news is that all changes are primarily in the area of "code comments" or "file headers" only. The short list is as follows:
|| File Name || Change Requested ||
| com.icesoft.faces.component.PORTLET_CSS_DEFAULT | The comment "All style class names are *extracted from* JSR-168 spec" should either be removed altogether or rephrased into something like "All style class names *were chosen in accordance with* JSR-168 spec" |
| com.icesoft.net.messaging.jms.JMSAdapter | Remove the comment blocks at the end of the file that are directly from spec or simply reference the spec. |
| \icefaces\core\src\com\icesoft\jasper\web-app_2_2.dtd | Change in license header only. Remainder of file is identical. |
| \icefaces\core\src\com\icesoft\jasper\web-app_2_3.dtd | Change in license header only. Remainder of file is identical. |
As part of the review for the *Eclipse Process Manager* a.k.a. _Stardust_ (see http://www.eclipse.org/stardust and http://www.eclipse.org/proposals/soa.stardust/), some very minor changes in the ICEfaces library were suggested by the Eclipse review team. The web portals for _Stardust_ are based on *ICEfaces 1.8.2*.
The good news is that all changes are primarily in the area of "code comments" or "file headers" only. The short list is as follows:
|| File Name || Change Requested ||
| com.icesoft.faces.component.PORTLET_CSS_DEFAULT | The comment "All style class names are *extracted from* JSR-168 spec" should either be removed altogether or rephrased into something like "All style class names *were chosen in accordance with* JSR-168 spec" |
| com.icesoft.net.messaging.jms.JMSAdapter | Remove the comment blocks at the end of the file that are directly from spec or simply reference the spec. |
| \icefaces\core\src\com\icesoft\jasper\web-app_2_2.dtd | Change in license header only. Remainder of file is identical. |
| \icefaces\core\src\com\icesoft\jasper\web-app_2_3.dtd | Change in license header only. Remainder of file is identical. |
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Thanks for the commit.
Could you please confirm that this was committed to the public repo as well? Thanks.
Show
Anoop Nair
added a comment - Thanks for the commit.
Could you please confirm that this was committed to the public repo as well? Thanks.
They were committed to the ICEfaces 1.x trunk so they should be available in the public repo as well. A quick check with the web client indicates they are there:
Show
Deryk Sinotte
added a comment - They were committed to the ICEfaces 1.x trunk so they should be available in the public repo as well. A quick check with the web client indicates they are there:
http://sventon.icesoft.org/svn/showfile.svn?path=/icefaces/trunk/icefaces/core/src/com/icesoft/faces/component/PORTLET_CSS_DEFAULT.java&revision=HEAD&name=repo
Changes reviewed and committed as per the submitted patch.