ICEfaces
  1. ICEfaces
  2. ICE-7886

Requested changes to code comments in some source, DTD files for Eclipse "Stardust"

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2, EE-1.8.2.GA_P03
    • Fix Version/s: EE-1.8.2.GA_P04
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Source code comments only.
    • Community Contribution:
      Yes

      Description

      h2. Changes Requested

      As part of the review for the *Eclipse Process Manager* a.k.a. _Stardust_ (see http://www.eclipse.org/stardust and http://www.eclipse.org/proposals/soa.stardust/), some very minor changes in the ICEfaces library were suggested by the Eclipse review team. The web portals for _Stardust_ are based on *ICEfaces 1.8.2*.

      The good news is that all changes are primarily in the area of "code comments" or "file headers" only. The short list is as follows:

      || File Name || Change Requested ||
      | com.icesoft.faces.component.PORTLET_CSS_DEFAULT | The comment "All style class names are *extracted from* JSR-168 spec" should either be removed altogether or rephrased into something like "All style class names *were chosen in accordance with* JSR-168 spec" |
      | com.icesoft.net.messaging.jms.JMSAdapter | Remove the comment blocks at the end of the file that are directly from spec or simply reference the spec. |
      | \icefaces\core\src\com\icesoft\jasper\web-app_2_2.dtd | Change in license header only. Remainder of file is identical. |
      | \icefaces\core\src\com\icesoft\jasper\web-app_2_3.dtd | Change in license header only. Remainder of file is identical. |

        Activity

        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P1
        Deryk Sinotte made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s EE-1.8.2.GA_P04 [ 10280 ]
        Fix Version/s 3.0.1 [ 10282 ]
        Ken Fyten made changes -
        Summary Change code comments in some source, DTD files Requested changes to code comments in some source, DTD files for Eclipse "Stardust"
        Salesforce Case []
        Fix Version/s 3.0.1 [ 10282 ]
        Assignee Priority P1
        Community Contribution [Yes]
        Assignee Deryk Sinotte [ deryk.sinotte ]
        Anoop Nair made changes -
        Field Original Value New Value
        Attachment ICE-7886_CommentChanges.patch [ 14166 ]
        Anoop Nair created issue -

          People

          • Assignee:
            Deryk Sinotte
            Reporter:
            Anoop Nair
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: