[ICE-7781] ice:panelPopup - panel isn't repositioned when popup size is changed - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Trivial
Resolution: Fixed
Affects Version/s: EE-1.8.2.GA_P03
Fix Version/s: 3.0.1, EE-3.0.0.GA, EE-1.8.2.GA_P04
Component/s: ICE-Components
Labels:
None
Environment:
ICEfaces EE 1.8.2 P03

Description

When changing/adding content in a panelPopup with autoCentre=true, the popup is not re-centred on the page. This was working fine in the ICEfaces 1.8.2 release. With the EE P03 release.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Case10908Example2.zip

17/Feb/12 11:11 AM

19 kB

Arran Mccullough
Hide
Case10908Example2.war

17/Feb/12 11:11 AM

6.78 MB

Arran Mccullough
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/.../example/TestBean.class 1 kB

WEB-INF/faces-config.xml 0.6 kB

WEB-INF/lib/backport-util-concurrent.jar 316 kB

WEB-INF/lib/commons-beanutils.jar 223 kB

WEB-INF/lib/commons-collections.jar 554 kB

WEB-INF/lib/commons-digester.jar 137 kB

WEB-INF/lib/commons-fileupload.jar 56 kB

WEB-INF/lib/commons-logging.jar 51 kB

WEB-INF/lib/icefaces-comps.jar 1.73 MB

WEB-INF/lib/icefaces-facelets.jar 592 kB

WEB-INF/lib/icefaces.jar 1.20 MB

WEB-INF/lib/jsf-api-1.2.jar 347 kB

WEB-INF/lib/jsf-impl-1.2.jar 818 kB

WEB-INF/lib/jxl.jar 689 kB

WEB-INF/.../krysalis-jCharts-1.0.0-alpha-1.jar 148 kB

WEB-INF/web.xml 4 kB

welcomeICEfaces.xhtml 2 kB

Download Zip
Show

Case10908Example2.war

17/Feb/12 11:11 AM

6.78 MB

Arran Mccullough

screenshot-1.png

170 kB

28/Feb/12 12:24 PM

Activity

Ascending order - Click to sort in descending order

Arran Mccullough created issue - 17/Feb/12 11:00 AM

Arran Mccullough made changes - 17/Feb/12 11:02 AM

Field	Original Value	New Value
Salesforce Case		[5007000000KFykT]

Hide

Permalink

Arran Mccullough added a comment - 17/Feb/12 11:11 AM

Attached test case that show issue.

Click on Open button. Modal popup is shown.
Click on the Show button, extra content is rendered in the popup. The popup header stays in place.
If the browser view is scrolled the popup jumps up to where the entire popup is centred.

In the ICEfaces 1.8.2 release it would be centred when the content is rendered.

Show

Arran Mccullough added a comment - 17/Feb/12 11:11 AM Attached test case that show issue. Click on Open button. Modal popup is shown. Click on the Show button, extra content is rendered in the popup. The popup header stays in place. If the browser view is scrolled the popup jumps up to where the entire popup is centred. In the ICEfaces 1.8.2 release it would be centred when the content is rendered.

Arran Mccullough made changes - 17/Feb/12 11:11 AM

Attachment		Case10908Example2.zip [ 14075 ]
Attachment		Case10908Example2.war [ 14076 ]

Ken Fyten made changes - 22/Feb/12 10:13 AM

Fix Version/s		3.0.1 [ 10282 ]
Fix Version/s		EE-1.8.2.GA_P04 [ 10280 ]
Assignee Priority		P2
Assignee		yip.ng [ yip.ng ]
Priority	Major [ 3 ]	Trivial [ 5 ]

yip.ng made changes - 28/Feb/12 12:24 PM

Attachment

screenshot-1.png [ 14107 ]

Hide

Permalink

yip.ng added a comment - 28/Feb/12 12:33 PM - edited

This is caused by ~~ICE-5652~~. (Numerous non-trivial changes. And there are a lot more other changes afterwards for other JIRA's.) See screenshot-1.png.

Tried some additional fixes. No luck. And don't know what effects they will have on original fixes for ~~ICE-5652~~.

Show

yip.ng added a comment - 28/Feb/12 12:33 PM - edited This is caused by ICE-5652 . (Numerous non-trivial changes. And there are a lot more other changes afterwards for other JIRA's.) See screenshot-1.png. Tried some additional fixes. No luck. And don't know what effects they will have on original fixes for ICE-5652 .

Hide

Permalink

Ken Fyten added a comment - 01/Mar/12 2:46 PM

Mircea, please analyze.

Show

Ken Fyten added a comment - 01/Mar/12 2:46 PM Mircea, please analyze.

Ken Fyten made changes - 01/Mar/12 2:46 PM

Assignee

yip.ng [ yip.ng ]

Mircea Toma [ mircea.toma ]

Hide

Permalink

Mircea Toma added a comment - 06/Mar/12 10:14 AM

When using the latest 1.8 code I could not reproduce the issue. The panel is re-centered right away when clicking on "Show" button (to expand panel's content).
Commit #23101 had indeed some changes related to popup's visiblity state that might have interfered with some of the rest of functionality but some of the changes were removed or refactored later on. This might explain why the issue does not occur anymore.

Show

Mircea Toma added a comment - 06/Mar/12 10:14 AM When using the latest 1.8 code I could not reproduce the issue. The panel is re-centered right away when clicking on "Show" button (to expand panel's content). Commit #23101 had indeed some changes related to popup's visiblity state that might have interfered with some of the rest of functionality but some of the changes were removed or refactored later on. This might explain why the issue does not occur anymore.

Mircea Toma made changes - 06/Mar/12 10:14 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Cannot Reproduce [ 5 ]

Hide

Permalink

yip.ng added a comment - 06/Mar/12 6:33 PM - edited

Still not working for me after re-checkout and clean build of http://server.ice:8888/svn/ossrepo/icefaces/trunk/icefaces. See video at http://screencast.com/t/dkAF7wAj6.

Show

yip.ng added a comment - 06/Mar/12 6:33 PM - edited Still not working for me after re-checkout and clean build of http://server.ice:8888/svn/ossrepo/icefaces/trunk/icefaces . See video at http://screencast.com/t/dkAF7wAj6 .

Ken Fyten made changes - 07/Mar/12 5:46 PM

Resolution	Cannot Reproduce [ 5 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#28275	Mon Mar 12 09:19:36 MDT 2012	mircea.toma	~~ICE-7781~~ Use JavascriptContext.addJavascriptCall method to send the JS code for auto-centering instead rendering the JS code in the component's markup. Using this makes approach makes sure the auto-centering is sent along every update of the popup.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#28276	Mon Mar 12 09:31:09 MDT 2012	mircea.toma	~~ICE-7781~~ Changed PanelPopupRenderer to use JavascriptContext.addJavascriptCall method to send the JS code for auto-centering instead rendering the JS code in the component's markup. Using this approach we make sure the auto-centering is sent along every update of the popup.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#28277	Mon Mar 12 09:31:59 MDT 2012	mircea.toma	~~ICE-7781~~ Changed PanelPopupRenderer to use JavascriptContext.addJavascriptCall method to send the JS code for auto-centering instead rendering the JS code in the component's markup. Using this approach we make sure the auto-centering is sent along every update of the popup.
				Files Changed
				MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java

Hide

Permalink

Mircea Toma added a comment - 12/Mar/12 10:33 AM

Changed PanelPopupRenderer to use JavascriptContext.addJavascriptCall method to send the JS code for auto-centering instead rendering the JS code in the component's markup. Using this approach we make sure the auto-centering is sent along every update of the popup.

Show

Mircea Toma added a comment - 12/Mar/12 10:33 AM Changed PanelPopupRenderer to use JavascriptContext.addJavascriptCall method to send the JS code for auto-centering instead rendering the JS code in the component's markup. Using this approach we make sure the auto-centering is sent along every update of the popup.

Hide

Permalink

Mircea Toma added a comment - 12/Mar/12 10:40 AM - edited

Applied fix to all the branches that require it.

Show

Mircea Toma added a comment - 12/Mar/12 10:40 AM - edited Applied fix to all the branches that require it.

Mircea Toma made changes - 12/Mar/12 10:40 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 15/Mar/12 3:26 PM

Fix Version/s

EE-3.0.0.GA [ 10262 ]

Ken Fyten made changes - 28/Mar/12 6:02 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee Priority	P2

People

Assignee:

Mircea Toma

Reporter:

Arran Mccullough

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

17/Feb/12 11:00 AM

Updated:

28/Mar/12 6:02 PM

Resolved:

12/Mar/12 10:40 AM