ICEfaces
  1. ICEfaces
  2. ICE-7781

ice:panelPopup - panel isn't repositioned when popup size is changed

          Details

            Description

            When changing/adding content in a panelPopup with autoCentre=true, the popup is not re-centred on the page. This was working fine in the ICEfaces 1.8.2 release. With the EE P03 release.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that show issue.

              • Click on Open button. Modal popup is shown.
              • Click on the Show button, extra content is rendered in the popup. The popup header stays in place.
              • If the browser view is scrolled the popup jumps up to where the entire popup is centred.

              In the ICEfaces 1.8.2 release it would be centred when the content is rendered.

              Show
              Arran Mccullough added a comment - Attached test case that show issue. Click on Open button. Modal popup is shown. Click on the Show button, extra content is rendered in the popup. The popup header stays in place. If the browser view is scrolled the popup jumps up to where the entire popup is centred. In the ICEfaces 1.8.2 release it would be centred when the content is rendered.
              Hide
              Permalink
              yip.ng added a comment - - edited

              This is caused by ICE-5652. (Numerous non-trivial changes. And there are a lot more other changes afterwards for other JIRA's.) See screenshot-1.png.

              Tried some additional fixes. No luck. And don't know what effects they will have on original fixes for ICE-5652.

              Show
              yip.ng added a comment - - edited This is caused by ICE-5652 . (Numerous non-trivial changes. And there are a lot more other changes afterwards for other JIRA's.) See screenshot-1.png. Tried some additional fixes. No luck. And don't know what effects they will have on original fixes for ICE-5652 .
              Hide
              Permalink
              Ken Fyten added a comment -

              Mircea, please analyze.

              Show
              Ken Fyten added a comment - Mircea, please analyze.
              Hide
              Permalink
              Mircea Toma added a comment -

              When using the latest 1.8 code I could not reproduce the issue. The panel is re-centered right away when clicking on "Show" button (to expand panel's content).
              Commit #23101 had indeed some changes related to popup's visiblity state that might have interfered with some of the rest of functionality but some of the changes were removed or refactored later on. This might explain why the issue does not occur anymore.

              Show
              Mircea Toma added a comment - When using the latest 1.8 code I could not reproduce the issue. The panel is re-centered right away when clicking on "Show" button (to expand panel's content). Commit #23101 had indeed some changes related to popup's visiblity state that might have interfered with some of the rest of functionality but some of the changes were removed or refactored later on. This might explain why the issue does not occur anymore.
              Hide
              Permalink
              yip.ng added a comment - - edited

              Still not working for me after re-checkout and clean build of http://server.ice:8888/svn/ossrepo/icefaces/trunk/icefaces. See video at http://screencast.com/t/dkAF7wAj6.

              Show
              yip.ng added a comment - - edited Still not working for me after re-checkout and clean build of http://server.ice:8888/svn/ossrepo/icefaces/trunk/icefaces . See video at http://screencast.com/t/dkAF7wAj6 .
              Hide
              Permalink
              Mircea Toma added a comment -

              Changed PanelPopupRenderer to use JavascriptContext.addJavascriptCall method to send the JS code for auto-centering instead rendering the JS code in the component's markup. Using this approach we make sure the auto-centering is sent along every update of the popup.

              Show
              Mircea Toma added a comment - Changed PanelPopupRenderer to use JavascriptContext.addJavascriptCall method to send the JS code for auto-centering instead rendering the JS code in the component's markup. Using this approach we make sure the auto-centering is sent along every update of the popup.
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              Applied fix to all the branches that require it.

              Show
              Mircea Toma added a comment - - edited Applied fix to all the branches that require it.

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: