ICEfaces
  1. ICEfaces
  2. ICE-7183

factor JavaScript utility functions

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 4.0.BETA, 4.0
    • Component/s: Bridge
    • Labels:
      None
    • Environment:
      ICEfaces, ICEpush
    • Assignee Priority:
      P1

      Description

      bridge-support is found in the following location:

      http://server.ice:8888/svn/ossrepo/projects/bridge-support/src/main/javascript

      We make use of bridge-support in multiple .jar files and incorporate it as
      an svn external. This is a good strategy when the included resource is
      subject to change and is used by multiple projects; however, it appears to
      now be stable and could be "released" as a binary.

      This would have two benefits:

       1. simplify the svn checkout
       2. reduce the number of times the JavaScript code is downloaded

      To satisfy 2., however, we would need to take some further steps:

       - make bridge-support a "public" JavaScript API
       - expose bridge-support from icefaces core
       - provide two versions of icepush.js, one with bridge-support and one without
         (ICEfaces would of course request the one without bridge-support)

        Activity

        Hide
        Mircea Toma added a comment -

        Implemented module system that allow the exporting and importing of variables in different local contexts. Defined modules that encapsulate well defined features.

        Show
        Mircea Toma added a comment - Implemented module system that allow the exporting and importing of variables in different local contexts. Defined modules that encapsulate well defined features.
        Hide
        Mircea Toma added a comment -

        Modified all projects that used to have svn:external references to bridge-support to now use the newly defined modules.

        Show
        Mircea Toma added a comment - Modified all projects that used to have svn:external references to bridge-support to now use the newly defined modules.
        Hide
        Ken Fyten added a comment -

        Commit to introduce a new JS compressor is causing a large number of ACE component regressions:

        svn rvn#36041 - ICE-7183 Replaced YUI compressor with ShrinkSafe since it can handle code because the latter can still compress code that has 'eval' invocations in it.


        Note: Summary file was generated by comparing results to the previous trunk results of June 4th (revision# 35843).

        ICEfaces3/trunk revision# 36078
        Server: tomcat6
        Browser: FF3.6, IE8, GoogleChrome27

        New failures: Lots of new failures, see Summary file. There is a reoccurring failure in all browsers (tested a sampling of 5 different components):
        A JS error is generated for each component that is on the page. The components either don't render or are non-functional with a JS error occuring with each render/interaction:
        Message: 'ice.ace' is null or not an object
        Line: 25
        Char: 1
        Code: 0

        Show
        Ken Fyten added a comment - Commit to introduce a new JS compressor is causing a large number of ACE component regressions: svn rvn#36041 - ICE-7183 Replaced YUI compressor with ShrinkSafe since it can handle code because the latter can still compress code that has 'eval' invocations in it. Note: Summary file was generated by comparing results to the previous trunk results of June 4th (revision# 35843). ICEfaces3/trunk revision# 36078 Server: tomcat6 Browser: FF3.6, IE8, GoogleChrome27 New failures: Lots of new failures, see Summary file. There is a reoccurring failure in all browsers (tested a sampling of 5 different components): A JS error is generated for each component that is on the page. The components either don't render or are non-functional with a JS error occuring with each render/interaction: Message: 'ice.ace' is null or not an object Line: 25 Char: 1 Code: 0
        Hide
        Mircea Toma added a comment -

        The previous changes removed yui-compressor.jar from the lib directory but it was still being used by the ACE components build file.
        The fix put back the missing jar.

        Show
        Mircea Toma added a comment - The previous changes removed yui-compressor.jar from the lib directory but it was still being used by the ACE components build file. The fix put back the missing jar.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: