ICEfaces
  1. ICEfaces
  2. ICE-7183

factor JavaScript utility functions

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0.2
          • Fix Version/s: 4.0.BETA, 4.0
          • Component/s: Bridge
          • Labels:
            None
          • Environment:
            ICEfaces, ICEpush
          • Assignee Priority:
            P1

            Description

            bridge-support is found in the following location:

            http://server.ice:8888/svn/ossrepo/projects/bridge-support/src/main/javascript

            We make use of bridge-support in multiple .jar files and incorporate it as
            an svn external. This is a good strategy when the included resource is
            subject to change and is used by multiple projects; however, it appears to
            now be stable and could be "released" as a binary.

            This would have two benefits:

             1. simplify the svn checkout
             2. reduce the number of times the JavaScript code is downloaded

            To satisfy 2., however, we would need to take some further steps:

             - make bridge-support a "public" JavaScript API
             - expose bridge-support from icefaces core
             - provide two versions of icepush.js, one with bridge-support and one without
               (ICEfaces would of course request the one without bridge-support)

              Activity

              Ascending order - Click to sort in descending order
              Ted Goddard created issue -
              Ted Goddard made changes -
              Field Original Value New Value
              Assignee Mircea Toma [ mircea.toma ]
              Ken Fyten made changes -
              Fix Version/s 3.4 [ 10770 ]
              Ken Fyten made changes -
              Assignee Priority P3 [ 10012 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35961 Wed Jun 05 17:46:02 MDT 2013 mircea.toma ICE-7183 Implemented module system that allow the exporting and importing of variables in different local contexts. Defined modules that encapsulate well defined feature.
              Files Changed
              Commit graph MODIFY /projects/bridge-support/src/test/javascript/hashtable.html
              Commit graph ADD /projects/bridge-support/lib
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/hashtable.js
              Commit graph ADD /projects/bridge-support/src/main/javascript/header.js
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/collection.js
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/cookie.js
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/string.js
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/http.js
              Commit graph MODIFY /projects/bridge-support/src/test/javascript/configuration.html
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/event.js
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/functional.js
              Commit graph ADD /projects/bridge-support/lib/yui-compressor.jar
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/oo.js
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/logger.js
              Commit graph DEL /projects/bridge-support/src/main/javascript/exception.js
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/delay.js
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/element.js
              Commit graph MODIFY /projects/bridge-support/src/test/javascript/collection.html
              Commit graph ADD /projects/bridge-support/build.xml
              Commit graph ADD /projects/bridge-support/src/main/javascript/module.js
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/configuration.js
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/window.js
              Commit graph DEL /projects/bridge-support/src/test/javascript/exception.html
              Hide
              Permalink
              Mircea Toma added a comment -

              Implemented module system that allow the exporting and importing of variables in different local contexts. Defined modules that encapsulate well defined features.

              Show
              Mircea Toma added a comment - Implemented module system that allow the exporting and importing of variables in different local contexts. Defined modules that encapsulate well defined features.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35966 Wed Jun 05 17:51:04 MDT 2013 mircea.toma ICE-7183 Modified ICEpush to use the new module system from bridge-support project.
              Files Changed
              Commit graph ADD /icepush/trunk/icepush/core/src/main/resources/META-INF/ice.core/bridge-support.js
              Commit graph ADD /icepush/trunk/icepush/core/src/main/resources/META-INF/ice.core
              Commit graph ADD /icepush/trunk/icepush/core/src/main/resources/META-INF/ice.core/bridge-support.uncompressed.js
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/javascript
              Commit graph MODIFY /icepush/trunk/icepush/core/build.javascript.xml
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/servlet/MainServlet.java
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/javascript/application.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35968 Wed Jun 05 17:53:52 MDT 2013 mircea.toma ICE-7183 Modified ICEfaces bridge to use the new module system from bridge-support project.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/BridgeSetup.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/javascript
              Commit graph ADD /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/resources/ice.core/bridge-support.uncompressed.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/javascript/application.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/resource-dependency.xml
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/build.javascript.xml
              Commit graph ADD /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/resources/ice.core/bridge-support.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35974 Thu Jun 06 04:06:22 MDT 2013 mircea.toma ICE-7183 Removed reference to configuration.js since it is not used directly anymore.
              Files Changed
              Commit graph MODIFY /icepush/trunk/icepush/core/build.javascript.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35975 Thu Jun 06 04:20:07 MDT 2013 mircea.toma ICE-7183 Import missing ice.lib.configuration module.
              Files Changed
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/javascript/application.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35976 Thu Jun 06 04:29:21 MDT 2013 mircea.toma ICE-7183 Fixed build to include configuration.js into the final coalesced files.
              Files Changed
              Commit graph MODIFY /projects/bridge-support/build.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35977 Thu Jun 06 04:31:39 MDT 2013 mircea.toma ICE-7183 Updated bridge-support files with versions that the have ice.lib.configuration module included.
              Files Changed
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/resources/META-INF/ice.core/bridge-support.js
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/resources/META-INF/ice.core/bridge-support.uncompressed.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/resources/ice.core/bridge-support.uncompressed.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/resources/ice.core/bridge-support.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35978 Thu Jun 06 04:44:38 MDT 2013 mircea.toma ICE-7183 Removed references to bridge-support files since they are not included directly ino the bridge code anymore.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/build.javascript.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35979 Thu Jun 06 04:49:24 MDT 2013 mircea.toma ICE-7183 Modified JS compat code to use the new modules defined in bridge-support.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/compat.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/build.javascript.xml
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35980 Thu Jun 06 05:10:23 MDT 2013 mircea.toma ICE-7183 Fixed module inter-dependencies.
              Files Changed
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/cookie.js
              Commit graph MODIFY /projects/bridge-support/src/main/javascript/window.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35981 Thu Jun 06 05:49:00 MDT 2013 mircea.toma ICE-7183 Replace YUI code minifier with Dojo Shrinksafe because it can compress code that contains 'eval' function invocations.
              Files Changed
              Commit graph ADD /projects/bridge-support/lib/js.jar
              Commit graph MODIFY /projects/bridge-support/build.xml
              Commit graph ADD /projects/bridge-support/lib/shrinksafe.jar
              Commit graph DEL /projects/bridge-support/lib/yui-compressor.jar
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35982 Thu Jun 06 05:51:41 MDT 2013 mircea.toma ICE-7183 Use 'eval' instead of ice.evaluate to make sure the code is evaluated in local scope. Replaced bridge-support.js with version that is now Dojo Shrinksafe minified.
              Files Changed
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/resources/META-INF/ice.core/bridge-support.js
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/resources/META-INF/ice.core/bridge-support.uncompressed.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/resources/ice.core/bridge-support.uncompressed.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/javascript/application.js
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/javascript/application.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/resources/META-INF/resources/ice.core/bridge-support.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35983 Thu Jun 06 05:53:00 MDT 2013 mircea.toma ICE-7183 Use eval instead of ice.evaluate to make sure code is evaluated in local scope.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/compat.js
              Hide
              Permalink
              Mircea Toma added a comment -

              Modified all projects that used to have svn:external references to bridge-support to now use the newly defined modules.

              Show
              Mircea Toma added a comment - Modified all projects that used to have svn:external references to bridge-support to now use the newly defined modules.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #36041 Fri Jun 07 10:28:02 MDT 2013 mircea.toma ICE-7183 Replaced YUI compressor with ShrinkSafe since it can handle code because the latter can still compress code that has 'eval' invocations in it.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/build.javascript.xml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/WEB-INF/web.xml
              Commit graph DEL /icefaces3/trunk/icefaces/lib/yui-compressor.jar
              Commit graph ADD /icefaces3/trunk/icefaces/lib/js.jar
              Commit graph ADD /icefaces3/trunk/icefaces/lib/shrinksafe.jar
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/build.javascript.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #36044 Fri Jun 07 10:40:54 MDT 2013 mircea.toma ICE-7183 Replaced YUI compressor with ShrinkSafe since it can handle code because the latter can still compress code that has 'eval' invocations in it.
              Files Changed
              Commit graph MODIFY /icepush/trunk/icepush/core/build.javascript.xml
              Commit graph ADD /icepush/trunk/icepush/lib/shrinksafe.jar
              Commit graph DEL /icepush/trunk/icepush/lib/yui-compressor.jar
              Commit graph ADD /icepush/trunk/icepush/lib/js.jar
              Hide
              Permalink
              Ken Fyten added a comment -

              Commit to introduce a new JS compressor is causing a large number of ACE component regressions:

              svn rvn#36041 - ICE-7183 Replaced YUI compressor with ShrinkSafe since it can handle code because the latter can still compress code that has 'eval' invocations in it.

              Note: Summary file was generated by comparing results to the previous trunk results of June 4th (revision# 35843).

              ICEfaces3/trunk revision# 36078
              Server: tomcat6
              Browser: FF3.6, IE8, GoogleChrome27

              New failures: Lots of new failures, see Summary file. There is a reoccurring failure in all browsers (tested a sampling of 5 different components):
              A JS error is generated for each component that is on the page. The components either don't render or are non-functional with a JS error occuring with each render/interaction:
              Message: 'ice.ace' is null or not an object
              Line: 25
              Char: 1
              Code: 0

              Show
              Ken Fyten added a comment - Commit to introduce a new JS compressor is causing a large number of ACE component regressions: svn rvn#36041 - ICE-7183 Replaced YUI compressor with ShrinkSafe since it can handle code because the latter can still compress code that has 'eval' invocations in it. Note: Summary file was generated by comparing results to the previous trunk results of June 4th (revision# 35843). ICEfaces3/trunk revision# 36078 Server: tomcat6 Browser: FF3.6, IE8, GoogleChrome27 New failures: Lots of new failures, see Summary file. There is a reoccurring failure in all browsers (tested a sampling of 5 different components): A JS error is generated for each component that is on the page. The components either don't render or are non-functional with a JS error occuring with each render/interaction: Message: 'ice.ace' is null or not an object Line: 25 Char: 1 Code: 0
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Assignee Priority P3 [ 10012 ] P1 [ 10010 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #36100 Mon Jun 10 14:37:21 MDT 2013 mircea.toma ICE-7183 Put back YUI compressor since it is used by ACE components build.
              Files Changed
              Commit graph ADD /icefaces3/trunk/icefaces/lib/yui-compressor.jar
              Hide
              Permalink
              Mircea Toma added a comment -

              The previous changes removed yui-compressor.jar from the lib directory but it was still being used by the ACE components build file.
              The fix put back the missing jar.

              Show
              Mircea Toma added a comment - The previous changes removed yui-compressor.jar from the lib directory but it was still being used by the ACE components build file. The fix put back the missing jar.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #36105 Mon Jun 10 15:30:07 MDT 2013 mircea.toma ICE-7183 Move ACE build file to shrinksafe JS compressor.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/build.xml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #36230 Thu Jun 13 17:12:52 MDT 2013 mircea.toma ICE-7183 Use YUI compressor for icefaces-compat.js just to get rid of line breaks and comments just as before (switching to ShrinkSafe). Prototype code proves to be hyper-sensitive to compression.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/build.javascript.xml
              Ken Fyten made changes -
              Fix Version/s 4.0 [ 11382 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: