ICEfaces
  1. ICEfaces
  2. ICE-7110

Simplify PushRenderer Cloud Push API

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.1-Beta, 3.0
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces, ICEpush

      Description

      Current code for using this API is functional but too verbose:

              PushRendererMessage pushMessage = new PushRendererMessage();
              pushMessage.setProperty("subject", notificationSubject);
              pushMessage.setProperty("body", notificationMessage);
              PushRenderer.render(NOTIFICATION_GROUP_NAME, pushMessage);

      Something along the lines of:

        PushRenderer.render(NOTIFICATION_GROUP_NAME,
            new PushMessage(notificationSubject, notificationMessage) );

      would be preferred

        Activity

        Hide
        Ken Fyten added a comment -

        This seems to have caused a regression for apps. that do not include icepush.jar.

        Williams POC fails upon startup with:

        Sep 1, 2011 11:42:28 AM org.icefaces.ace.webapp.PostConstructApplicationEventListener processEvent
        INFO: Running on ICEfaces ACE: 2.1.0-b01
        Sep 1, 2011 11:42:28 AM com.sun.faces.config.ConfigureListener contextInitialized
        SEVERE: Critical error during deployment:
        java.lang.NoClassDefFoundError: org/icepush/PushConfiguration
        at com.icesoft.faces.async.render.SessionRenderer$StartupListener.processEvent(SessionRenderer.java:53)
        at javax.faces.event.SystemEvent.processListener(SystemEvent.java:106)
        at com.sun.faces.application.ApplicationImpl.processListeners(ApplicationImpl.java:2129)
        at com.sun.faces.application.ApplicationImpl.invokeListenersFor(ApplicationImpl.java:2105)
        at com.sun.faces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:300)
        at com.sun.faces.config.ConfigManager.publishPostConfigEvent(ConfigManager.java:600)
        at com.sun.faces.config.ConfigManager.initialize(ConfigManager.java:369)
        at com.sun.faces.config.ConfigureListener.contextInitialized(ConfigureListener.java:225)
        at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4723)
        at org.apache.catalina.core.StandardContext$1.call(StandardContext.java:5226)
        at org.apache.catalina.core.StandardContext$1.call(StandardContext.java:5221)
        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
        at java.util.concurrent.FutureTask.run(FutureTask.java:138)
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
        at java.lang.Thread.run(Thread.java:680)
        Caused by: java.lang.ClassNotFoundException: org.icepush.PushConfiguration
        at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1678)
        at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1523)
        ... 16 more

        Show
        Ken Fyten added a comment - This seems to have caused a regression for apps. that do not include icepush.jar. Williams POC fails upon startup with: Sep 1, 2011 11:42:28 AM org.icefaces.ace.webapp.PostConstructApplicationEventListener processEvent INFO: Running on ICEfaces ACE: 2.1.0-b01 Sep 1, 2011 11:42:28 AM com.sun.faces.config.ConfigureListener contextInitialized SEVERE: Critical error during deployment: java.lang.NoClassDefFoundError: org/icepush/PushConfiguration at com.icesoft.faces.async.render.SessionRenderer$StartupListener.processEvent(SessionRenderer.java:53) at javax.faces.event.SystemEvent.processListener(SystemEvent.java:106) at com.sun.faces.application.ApplicationImpl.processListeners(ApplicationImpl.java:2129) at com.sun.faces.application.ApplicationImpl.invokeListenersFor(ApplicationImpl.java:2105) at com.sun.faces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:300) at com.sun.faces.config.ConfigManager.publishPostConfigEvent(ConfigManager.java:600) at com.sun.faces.config.ConfigManager.initialize(ConfigManager.java:369) at com.sun.faces.config.ConfigureListener.contextInitialized(ConfigureListener.java:225) at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4723) at org.apache.catalina.core.StandardContext$1.call(StandardContext.java:5226) at org.apache.catalina.core.StandardContext$1.call(StandardContext.java:5221) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) Caused by: java.lang.ClassNotFoundException: org.icepush.PushConfiguration at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1678) at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1523) ... 16 more

          People

          • Assignee:
            Ted Goddard
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: