[ICE-7110] Simplify PushRenderer Cloud Push API - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.1
Fix Version/s: 2.1-Beta, 3.0
Component/s: Framework
Labels:
None
Environment:
ICEfaces, ICEpush

Description

Current code for using this API is functional but too verbose:

        PushRendererMessage pushMessage = new PushRendererMessage();
        pushMessage.setProperty("subject", notificationSubject);
        pushMessage.setProperty("body", notificationMessage);
        PushRenderer.render(NOTIFICATION_GROUP_NAME, pushMessage);

Something along the lines of:

  PushRenderer.render(NOTIFICATION_GROUP_NAME,
      new PushMessage(notificationSubject, notificationMessage) );

would be preferred

Activity

Ascending order - Click to sort in descending order

Ted Goddard created issue - 09/Aug/11 5:21 PM

Ted Goddard made changes - 09/Aug/11 5:22 PM

Field	Original Value	New Value
Salesforce Case		[]
Fix Version/s		2.1 [ 10241 ]

Ted Goddard made changes - 09/Aug/11 5:22 PM

Assignee

Ted Goddard [ ted.goddard ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25361	Wed Aug 31 15:17:14 MDT 2011	ted.goddard	simplified cloud push API (~~ICE-7110~~)
				Files Changed
				DEL /icepush/trunk/core/src/main/java/org/icepush/PushMessage.java MODIFY /icepush/trunk/core/src/main/java/org/icepush/EmailNotificationProvider.java MODIFY /icepush/trunk/core/src/main/java/org/icepush/LocalPushGroupManager.java MODIFY /icepush/trunk/core/src/main/java/org/icepush/OutOfBandNotifier.java MODIFY /icepush/trunk/core/src/main/java/org/icepush/PushContext.java ADD /icepush/trunk/core/src/main/java/org/icepush/PushConfiguration.java MODIFY /icepush/trunk/core/src/main/java/org/icepush/NoopPushGroupManager.java MODIFY /icepush/trunk/core/src/main/java/org/icepush/PushGroupManager.java ADD /icepush/trunk/core/src/main/java/org/icepush/PushNotification.java MODIFY /icepush/trunk/core/src/main/java/org/icepush/NotificationProvider.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25362	Wed Aug 31 15:26:54 MDT 2011	ted.goddard	simplified cloud push API, icepush.jar revision 25361 (~~ICE-7110~~)
				Files Changed
				ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/PushMessage.java ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/PushOptions.java MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/PortableRenderer.java MODIFY /icefaces2/trunk/icefaces/lib/icepush.jar MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/PushRenderer.java DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/PushRendererMessage.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25363	Wed Aug 31 15:29:51 MDT 2011	ted.goddard	simplified cloud push API, icepush.jar revision 25361 corrected (~~ICE-7110~~)
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/PushRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25364	Wed Aug 31 15:34:29 MDT 2011	ted.goddard	simplified cloud push API, icepush.jar revision 25361, icefaces.jar revision 25363 (~~ICE-7110~~)
				Files Changed
				MODIFY /icemobile/trunk/icemobile/samples/mediacast/src/main/java/org/icemobile/samples/mediacast/MediaController.java MODIFY /icemobile/trunk/icemobile/lib/icepush.jar MODIFY /icemobile/trunk/icemobile/lib/icefaces.jar MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/java/org/icemobile/samples/mobileshowcase/view/examples/device/notification/NotificationBean.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25383	Thu Sep 01 12:25:47 MDT 2011	ted.goddard	removing icepush.jar from basic (~~ICE-7110~~)
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/samples/core/basic/build.xml

Hide

Permalink

Ken Fyten added a comment - 01/Sep/11 12:46 PM

This seems to have caused a regression for apps. that do not include icepush.jar.

Williams POC fails upon startup with:

Sep 1, 2011 11:42:28 AM org.icefaces.ace.webapp.PostConstructApplicationEventListener processEvent
INFO: Running on ICEfaces ACE: 2.1.0-b01
Sep 1, 2011 11:42:28 AM com.sun.faces.config.ConfigureListener contextInitialized
SEVERE: Critical error during deployment:
java.lang.NoClassDefFoundError: org/icepush/PushConfiguration
at com.icesoft.faces.async.render.SessionRenderer$StartupListener.processEvent(SessionRenderer.java:53)
at javax.faces.event.SystemEvent.processListener(SystemEvent.java:106)
at com.sun.faces.application.ApplicationImpl.processListeners(ApplicationImpl.java:2129)
at com.sun.faces.application.ApplicationImpl.invokeListenersFor(ApplicationImpl.java:2105)
at com.sun.faces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:300)
at com.sun.faces.config.ConfigManager.publishPostConfigEvent(ConfigManager.java:600)
at com.sun.faces.config.ConfigManager.initialize(ConfigManager.java:369)
at com.sun.faces.config.ConfigureListener.contextInitialized(ConfigureListener.java:225)
at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4723)
at org.apache.catalina.core.StandardContext$1.call(StandardContext.java:5226)
at org.apache.catalina.core.StandardContext$1.call(StandardContext.java:5221)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:680)
Caused by: java.lang.ClassNotFoundException: org.icepush.PushConfiguration
at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1678)
at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1523)
... 16 more

Show

Ken Fyten added a comment - 01/Sep/11 12:46 PM This seems to have caused a regression for apps. that do not include icepush.jar. Williams POC fails upon startup with: Sep 1, 2011 11:42:28 AM org.icefaces.ace.webapp.PostConstructApplicationEventListener processEvent INFO: Running on ICEfaces ACE: 2.1.0-b01 Sep 1, 2011 11:42:28 AM com.sun.faces.config.ConfigureListener contextInitialized SEVERE: Critical error during deployment: java.lang.NoClassDefFoundError: org/icepush/PushConfiguration at com.icesoft.faces.async.render.SessionRenderer$StartupListener.processEvent(SessionRenderer.java:53) at javax.faces.event.SystemEvent.processListener(SystemEvent.java:106) at com.sun.faces.application.ApplicationImpl.processListeners(ApplicationImpl.java:2129) at com.sun.faces.application.ApplicationImpl.invokeListenersFor(ApplicationImpl.java:2105) at com.sun.faces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:300) at com.sun.faces.config.ConfigManager.publishPostConfigEvent(ConfigManager.java:600) at com.sun.faces.config.ConfigManager.initialize(ConfigManager.java:369) at com.sun.faces.config.ConfigureListener.contextInitialized(ConfigureListener.java:225) at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4723) at org.apache.catalina.core.StandardContext$1.call(StandardContext.java:5226) at org.apache.catalina.core.StandardContext$1.call(StandardContext.java:5221) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) Caused by: java.lang.ClassNotFoundException: org.icepush.PushConfiguration at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1678) at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1523) ... 16 more

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25384	Thu Sep 01 13:40:33 MDT 2011	ted.goddard	isolating icepush calls to avoid runtime icepush.jar dependency (~~ICE-7110~~)
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/samples/compat/compat-basic/build.xml MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/PushRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25389	Thu Sep 01 16:19:59 MDT 2011	ted.goddard	icefaces.jar revision 25830 and icepush.jar revision 25388 (~~ICE-7110~~)
				Files Changed
				MODIFY /icemobile/trunk/icemobile/lib/icepush.jar MODIFY /icemobile/trunk/icemobile/lib/icefaces.jar

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25443	Fri Sep 09 12:12:34 MDT 2011	ted.goddard	reduced logging during startup (~~ICE-7110~~)
				Files Changed
				MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/EmailNotificationProvider.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#25444	Fri Sep 09 12:13:44 MDT 2011	ted.goddard	reduced startup logging of EmailNotificationProvider icepush.jar from revision 25443 (~~ICE-7110~~)
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/lib/icepush.jar

Ted Goddard made changes - 22/Sep/11 1:27 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 04/Oct/11 3:40 PM

Fix Version/s

2.1-Beta [ 10291 ]

Ken Fyten made changes - 17/Feb/12 5:21 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Ted Goddard

Reporter:

Ted Goddard

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

09/Aug/11 5:21 PM

Updated:

17/Feb/12 5:21 PM

Resolved:

22/Sep/11 1:27 PM