ICEfaces
  1. ICEfaces
  2. ICE-6823

Improve environment detection logic where requests and responses can implement both Portlet and non-Portlet interfaces

    Details

      Description

      There are a few places where we rely on checking the request to see if it's an HttpServletRequest and, if not, assume we're running in a portlet environment. However, some portal containers wrap their requests and responses so that they implement both the PortletRequest/PortletResponse interfaces as well as the non-portlet versions (HttpServletRequest, HttpServletResponse). Our detection code does not handle this and will assume a non-portlet environment, leading to problems. The detection code needs to be able to take this into account.

        Activity

        Hide
        Deryk Sinotte added a comment -

        EnvUtils has been updated and the portlet detection logic has been improved.

        Show
        Deryk Sinotte added a comment - EnvUtils has been updated and the portlet detection logic has been improved.
        Hide
        Deryk Sinotte added a comment -

        Resolved. This was mostly driven by WebSphere Portal where incoming requests can implement both Portlet* and HttpServlet* versions of requests and responses so checking if something is the HttpServlet version was not enough.

        Show
        Deryk Sinotte added a comment - Resolved. This was mostly driven by WebSphere Portal where incoming requests can implement both Portlet* and HttpServlet* versions of requests and responses so checking if something is the HttpServlet version was not enough.

          People

          • Assignee:
            Deryk Sinotte
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: