ICEfaces
  1. ICEfaces
  2. ICE-6823

Improve environment detection logic where requests and responses can implement both Portlet and non-Portlet interfaces

          Details

            Description

            There are a few places where we rely on checking the request to see if it's an HttpServletRequest and, if not, assume we're running in a portlet environment. However, some portal containers wrap their requests and responses so that they implement both the PortletRequest/PortletResponse interfaces as well as the non-portlet versions (HttpServletRequest, HttpServletResponse). Our detection code does not handle this and will assume a non-portlet environment, leading to problems. The detection code needs to be able to take this into account.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24461 Tue Apr 26 11:35:26 MDT 2011 deryk.sinotte ICE-6823: improve portal environment detection logic
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/style/OutputStyleRenderer.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/fileentry/PushUtils.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/fileentry/FileEntryPhaseListener.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/servlet/ICEpushResourceHandler.java
              Deryk Sinotte created issue -
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24573 Fri May 13 14:28:05 MDT 2011 deryk.sinotte ICE-6823: improve robustness of how a portal environment is detected
              Files Changed
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/style/OutputStyleRenderer.java
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/ace/component/src/org/icefaces/component/fileentry/PushUtils.java
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/java/org/icefaces/impl/push/servlet/ICEpushResourceHandler.java
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/ace/component/src/org/icefaces/component/fileentry/FileEntryPhaseListener.java
              Hide
              Permalink
              Deryk Sinotte added a comment -

              EnvUtils has been updated and the portlet detection logic has been improved.

              Show
              Deryk Sinotte added a comment - EnvUtils has been updated and the portlet detection logic has been improved.
              Deryk Sinotte made changes -
              Field Original Value New Value
              Salesforce Case []
              Assignee Deryk Sinotte [ deryk.sinotte ]
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Resolved. This was mostly driven by WebSphere Portal where incoming requests can implement both Portlet* and HttpServlet* versions of requests and responses so checking if something is the HttpServlet version was not enough.

              Show
              Deryk Sinotte added a comment - Resolved. This was mostly driven by WebSphere Portal where incoming requests can implement both Portlet* and HttpServlet* versions of requests and responses so checking if something is the HttpServlet version was not enough.
              Deryk Sinotte made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.1-Beta [ 10291 ]
              Fix Version/s 2.1 [ 10241 ]
              Ken Fyten made changes -
              Fix Version/s 3.0 [ 10241 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Deryk Sinotte
                  Reporter:
                  Deryk Sinotte
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: