Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0.1
-
Fix Version/s: EE-2.0.0.GA, 2.0.2
-
Component/s: Bridge, ICE-Components
-
Labels:None
-
Environment:IF 2
Description
When building ICEfaces with uncompressed JavaScript (NO-COMPRESS), the resulting JS causes all kinds of errors in the browser. This used to work until recently, may be related to the recent adoption of YUI-Compressor.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
The icefaces-compat.js file with the comments stripped out is 440kb in size while with the comments left in is 493kb in size. So, just 12% increase.
Anyway the 'no-compress' switch is really useful only in case you want to debug the JS code, it's even preferable to have the comments in (with the exception of the license header).
By default the minification is applied and that indeed reduces the size to less than half of the original.
Applied the fix to 2.0.x-maintenance as well.
Show
Mircea Toma
added a comment - - edited The icefaces-compat.js file with the comments stripped out is 440kb in size while with the comments left in is 493kb in size. So, just 12% increase.
Anyway the 'no-compress' switch is really useful only in case you want to debug the JS code, it's even preferable to have the comments in (with the exception of the license header).
By default the minification is applied and that indeed reduces the size to less than half of the original.
Applied the fix to 2.0.x-maintenance as well.
Disabled 'stripjavacomments' Ant filter when 'no-compress=true'. The used to remove comments breaks Prototype code, one of the regular expressions contains '/*' characters which are mistakenly interpreted as JS comments.
With 'no-compress=false' the YUI compressor correctly parses the Prototype code and minifies it as expected.