ICEfaces
  1. ICEfaces
  2. ICE-6721

Building with uncompressed JavaScript (for debugging) results in JS errors at runtime.

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0.1
          • Fix Version/s: EE-2.0.0.GA, 2.0.2
          • Component/s: Bridge, ICE-Components
          • Labels:
            None
          • Environment:
            IF 2

            Description

            When building ICEfaces with uncompressed JavaScript (NO-COMPRESS), the resulting JS causes all kinds of errors in the browser. This used to work until recently, may be related to the recent adoption of YUI-Compressor.

              Activity

              Ascending order - Click to sort in descending order
              Ken Fyten created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Assignee Priority P1
              Assignee Mircea Toma [ mircea.toma ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24337 Mon Apr 04 08:35:25 MDT 2011 mircea.toma ICE-6721 Disable 'stripjavacomments' Ant filter to avoid breaking Prototype code.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/build.javascript.xml
              Hide
              Permalink
              Mircea Toma added a comment -

              Disabled 'stripjavacomments' Ant filter when 'no-compress=true'. The used to remove comments breaks Prototype code, one of the regular expressions contains '/*' characters which are mistakenly interpreted as JS comments.

              With 'no-compress=false' the YUI compressor correctly parses the Prototype code and minifies it as expected.

              Show
              Mircea Toma added a comment - Disabled 'stripjavacomments' Ant filter when 'no-compress=true'. The used to remove comments breaks Prototype code, one of the regular expressions contains '/*' characters which are mistakenly interpreted as JS comments. With 'no-compress=false' the YUI compressor correctly parses the Prototype code and minifies it as expected.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #24344 Mon Apr 04 14:21:21 MDT 2011 mircea.toma ICE-6721 Disable 'stripjavacomments' Ant filter to avoid breaking Prototype code.
              Files Changed
              Commit graph MODIFY /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/core/build.javascript.xml
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              The icefaces-compat.js file with the comments stripped out is 440kb in size while with the comments left in is 493kb in size. So, just 12% increase.
              Anyway the 'no-compress' switch is really useful only in case you want to debug the JS code, it's even preferable to have the comments in (with the exception of the license header).
              By default the minification is applied and that indeed reduces the size to less than half of the original.

              Applied the fix to 2.0.x-maintenance as well.

              Show
              Mircea Toma added a comment - - edited The icefaces-compat.js file with the comments stripped out is 440kb in size while with the comments left in is 493kb in size. So, just 12% increase. Anyway the 'no-compress' switch is really useful only in case you want to debug the JS code, it's even preferable to have the comments in (with the exception of the license header). By default the minification is applied and that indeed reduces the size to less than half of the original. Applied the fix to 2.0.x-maintenance as well.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Salesforce Case []
              Fix Version/s 2.1 [ 10241 ]
              Assignee Priority P1
              Ken Fyten made changes -
              Fix Version/s 2.0.2 [ 10273 ]
              Fix Version/s 2.1 [ 10241 ]
              Ken Fyten made changes -
              Salesforce Case []
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: