ICEfaces
  1. ICEfaces
  2. ICE-6508

panelTabSet keyboard navigation not working when tabbed into

    Details

    • Assignee Priority:
      P1

      Description

      With addition of the tabindex attribute (ICE-5994) it is now possible to tab into the panelTabSet component. The keyboard navigation does not seem to work once the focus has been received. It does work once the tab has been selected via the mouse.

        Activity

        Hide
        yip.ng added a comment - - edited

        Tabbing works fine in all 3 browsers once the fix for this JIRA is reverted, i.e. this fix for the keyboard navigation within the tabset (the addition of an onfocus listener to the tabs) wrecks the tabbing among the fields and components.

        Note that "after tabbing through all components once, user can not tab into components above tabset." is standard behavior, because in the test case only the group of fields around the tabset have tabindex. Many other fields are on the page that don't have tabindex. You have to cycle all through these before focus will get back to the test fields.

        Show
        yip.ng added a comment - - edited Tabbing works fine in all 3 browsers once the fix for this JIRA is reverted, i.e. this fix for the keyboard navigation within the tabset (the addition of an onfocus listener to the tabs) wrecks the tabbing among the fields and components. Note that "after tabbing through all components once, user can not tab into components above tabset." is standard behavior, because in the test case only the group of fields around the tabset have tabindex. Many other fields are on the page that don't have tabindex. You have to cycle all through these before focus will get back to the test fields.
        Hide
        Ken Fyten added a comment -

        So the only real failure here is this one:

        "On IE8 & Chrome10 the user cannot tab into the input text fields after the panel tabset component."

        We're going to need a version of this fix that also works with IE8 and Chrome.

        Show
        Ken Fyten added a comment - So the only real failure here is this one: "On IE8 & Chrome10 the user cannot tab into the input text fields after the panel tabset component." We're going to need a version of this fix that also works with IE8 and Chrome.
        Hide
        yip.ng added a comment -

        There is also the Shift-Tab not working in FF. Not the same as "tabbing into components above tabset" from the top.

        Show
        yip.ng added a comment - There is also the Shift-Tab not working in FF. Not the same as "tabbing into components above tabset" from the top.
        Hide
        yip.ng added a comment -

        Fixed. Tested on FF, IE and Chrome. Note that the tab key is also used for intra-component navigation like the arrow keys. It was working like this before.

        Revision: 24758


        Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

        Revision: 24759


        Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

        Revision: 24760


        Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

        Show
        yip.ng added a comment - Fixed. Tested on FF, IE and Chrome. Note that the tab key is also used for intra-component navigation like the arrow keys. It was working like this before. Revision: 24758 Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java Revision: 24759 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java Revision: 24760 Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
        Hide
        Mandeep Hayher added a comment -

        Tested successfully on ICEfaces-1.8.2-GA_P03-bin (build6) using FF3.6, IE8 & Chrome11.

        Show
        Mandeep Hayher added a comment - Tested successfully on ICEfaces-1.8.2-GA_P03-bin (build6) using FF3.6, IE8 & Chrome11.

          People

          • Assignee:
            Ken Fyten
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: