Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
Completed: At revision: 24576

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\branches\icefaces-2.0.x-maintenance\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
Completed: At revision: 24577

Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\paneltabset\PanelTabSetRenderer.java
Completed: At revision: 24578

Tested on icefaces1.8 revision# 24720
tabbing and keyboard navigation works fine on FF3.6, but user cannot tab back into input text fields from the panel tabset component by pressing shift+tab keys.

On IE8 & Chrome10 the user cannot tab into the input text fields after the panel tabset component.

Also on FF user can navigate only once through all components on the page, after tabbing through all components once, user can not tab into components above tabset.

Tabbing works fine in all 3 browsers once the fix for this JIRA is reverted, i.e. this fix for the keyboard navigation within the tabset (the addition of an onfocus listener to the tabs) wrecks the tabbing among the fields and components.

Note that "after tabbing through all components once, user can not tab into components above tabset." is standard behavior, because in the test case only the group of fields around the tabset have tabindex. Many other fields are on the page that don't have tabindex. You have to cycle all through these before focus will get back to the test fields.

So the only real failure here is this one:

"On IE8 & Chrome10 the user cannot tab into the input text fields after the panel tabset component."

We're going to need a version of this fix that also works with IE8 and Chrome.

There is also the Shift-Tab not working in FF. Not the same as "tabbing into components above tabset" from the top.

Fixed. Tested on FF, IE and Chrome. Note that the tab key is also used for intra-component navigation like the arrow keys. It was working like this before.

Revision: 24758

Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

Revision: 24759

Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

Revision: 24760

Modified : /icefaces2/branches/icefaces-2.0.x-maintenance/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

Tested successfully on ICEfaces-1.8.2-GA_P03-bin (build6) using FF3.6, IE8 & Chrome11.