ICEfaces
  1. ICEfaces
  2. ICE-6243

ACE: sliderEntry should only submit if 'singleSubmit=true'

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta2
    • Fix Version/s: 2.0.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 2 Adv. Comps.
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      Currently the sliderEntry component always triggers a submit when it's value is changed, with the singleSubmit attribute adjusting whether it's a full-form submit (singleSubmit=false), or only executing the sliderEntry (singleSubmit=true).

      The correct behavior is to have the sliderEntry only update a hidden form field when singleSubmit=false. The hidden form field will eventually be submitted whenever the form it is contained within is submitted. If singleSubmit=true then the sliderEntry should submit with ice.se().

        Activity

        Hide
        Adnan Durrani added a comment - - edited

        Current behavior before changes:
        When we set singleSubmit=true, we call ice.se() and when singleSubmit=false we consider it full submit so call ice.s().

        Show
        Adnan Durrani added a comment - - edited Current behavior before changes: When we set singleSubmit=true, we call ice.se() and when singleSubmit=false we consider it full submit so call ice.s().
        Hide
        Adnan Durrani added a comment -

        Requested changes has been applied.

        Command: Commit
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js
        Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\sliderentry\SliderEntryRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\sliderentry\SliderEntryRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js
        Completed: At revision: 23191

        Show
        Adnan Durrani added a comment - Requested changes has been applied. Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\sliderentry\SliderEntryRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\sliderentry\SliderEntryRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js Completed: At revision: 23191
        Hide
        Adnan Durrani added a comment -

        Ken this is exactly what I have implemented. May you had to clean cache. Please watch following video which is made using latest code from today:

        http://screencast.com/t/OX0F2Fa1hpx

        Show
        Adnan Durrani added a comment - Ken this is exactly what I have implemented. May you had to clean cache. Please watch following video which is made using latest code from today: http://screencast.com/t/OX0F2Fa1hpx

          People

          • Assignee:
            Adnan Durrani
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: