ICEfaces
  1. ICEfaces
  2. ICE-6243

ACE: sliderEntry should only submit if 'singleSubmit=true'

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta2
          • Fix Version/s: 2.0.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces 2 Adv. Comps.
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.)

            Description

            Currently the sliderEntry component always triggers a submit when it's value is changed, with the singleSubmit attribute adjusting whether it's a full-form submit (singleSubmit=false), or only executing the sliderEntry (singleSubmit=true).

            The correct behavior is to have the sliderEntry only update a hidden form field when singleSubmit=false. The hidden form field will eventually be submitted whenever the form it is contained within is submitted. If singleSubmit=true then the sliderEntry should submit with ice.se().

              Activity

              Ascending order - Click to sort in descending order
              Ken Fyten created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 2.0.0 [ 10230 ]
              Affects [Documentation (User Guide, Ref. Guide, etc.)]
              Ken Fyten made changes -
              Assignee Adnan Durrani [ adnan.durrani ]
              Ken Fyten made changes -
              Assignee Priority P1
              Adnan Durrani made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Adnan Durrani added a comment - - edited

              Current behavior before changes:
              When we set singleSubmit=true, we call ice.se() and when singleSubmit=false we consider it full submit so call ice.s().

              Show
              Adnan Durrani added a comment - - edited Current behavior before changes: When we set singleSubmit=true, we call ice.se() and when singleSubmit=false we consider it full submit so call ice.s().
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23191 Tue Nov 23 21:34:39 MST 2010 adnan.durrani Fix for ICE-6243 (ACE: sliderEntry should only submit if 'singleSubmit=true')
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/SliderEntryRenderer.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.sliderentry/slider.js
              Hide
              Permalink
              Adnan Durrani added a comment -

              Requested changes has been applied.

              Command: Commit
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js
              Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\sliderentry\SliderEntryRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\sliderentry\SliderEntryRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js
              Completed: At revision: 23191

              Show
              Adnan Durrani added a comment - Requested changes has been applied. Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js Modified: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\sliderentry\SliderEntryRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\src\org\icefaces\component\sliderentry\SliderEntryRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces2\trunk\icefaces\ace\component\resources\org.icefaces.component.sliderentry\slider.js Completed: At revision: 23191
              Adnan Durrani made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Adnan Durrani added a comment -

              Ken this is exactly what I have implemented. May you had to clean cache. Please watch following video which is made using latest code from today:

              http://screencast.com/t/OX0F2Fa1hpx

              Show
              Adnan Durrani added a comment - Ken this is exactly what I have implemented. May you had to clean cache. Please watch following video which is made using latest code from today: http://screencast.com/t/OX0F2Fa1hpx
              Adnan Durrani made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P1

                People

                • Assignee:
                  Adnan Durrani
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: