ICEfaces
  1. ICEfaces
  2. ICE-5941

Remove reliance on resetHiddenFields() in compat components

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha3
          • Fix Version/s: 2.0.0
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            compat

            Description

            Certain components create hidden fields, either via server rendering, or via javascript DOM manipulation, which have a name but no id. These hidden input fields are special, intended for sending one-off messages back to the server. They rely on resetHiddenFields() clearing the special hidden input field values, so that the one-off messages are not re-sent in subsequent form submits.

            It should be possible to find all of these, by searching for "hidden" in the source code, so that they can be enumerated, and hopefully removed, thus removing the need for resetHiddenFields() itself. Likely, uses can be replaced with parameters to iceSubmit() and iceSubmitPartial(). An alternate strategy is depicted in ICE-5796, the parent task, for removing resetHiddenFields() itself.
            1. screenshot-01.png
              84 kB
            2. screenshot-02.png
              83 kB
            3. screenshot-03.png
              181 kB
            4. screenshot-04.png
              188 kB
            5. screenshot-05.png
              274 kB

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-5796 Try to eliminate resetHiddenFields() function in Compat Comps.

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                18 older comments
                Hide
                Permalink
                yip.ng added a comment -

                COMMAND_LINK_HIDDEN_FIELD in PanelTabSetRenderer done.

                Revision: 23279

                Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

                Show
                yip.ng added a comment - COMMAND_LINK_HIDDEN_FIELD in PanelTabSetRenderer done. Revision: 23279 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
                Hide
                Permalink
                yip.ng added a comment -

                COMMAND_LINK_HIDDEN_FIELD in SelectInputDateRenderer done.

                Revision: 23283

                Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

                Show
                yip.ng added a comment - COMMAND_LINK_HIDDEN_FIELD in SelectInputDateRenderer done. Revision: 23283 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Hide
                Permalink
                yip.ng added a comment -

                COMMAND_LINK_HIDDEN_FIELD in CommandLinkRenderer done.

                Revision: 23286

                Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/CommandLinkRenderer.java
                Modified : /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java

                Show
                yip.ng added a comment - COMMAND_LINK_HIDDEN_FIELD in CommandLinkRenderer done. Revision: 23286 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/CommandLinkRenderer.java Modified : /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
                Hide
                Permalink
                yip.ng added a comment -

                resetHiddenFieldsFor() removed.

                Revision: 23287

                Modified : /icefaces2/trunk/icefaces/compat/core/src/main/javascript/submit.js

                Show
                yip.ng added a comment - resetHiddenFieldsFor() removed. Revision: 23287 Modified : /icefaces2/trunk/icefaces/compat/core/src/main/javascript/submit.js
                Hide
                Permalink
                Ted Goddard added a comment -

                Code in submit.js verified to match earlier prototype work.

                Show
                Ted Goddard added a comment - Code in submit.js verified to match earlier prototype work.

                  People

                  • Assignee:
                    yip.ng
                    Reporter:
                    Mark Collette
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: