ICEfaces
  1. ICEfaces
  2. ICE-5941

Remove reliance on resetHiddenFields() in compat components

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha3
          • Fix Version/s: 2.0.0
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            compat

            Description

            Certain components create hidden fields, either via server rendering, or via javascript DOM manipulation, which have a name but no id. These hidden input fields are special, intended for sending one-off messages back to the server. They rely on resetHiddenFields() clearing the special hidden input field values, so that the one-off messages are not re-sent in subsequent form submits.

            It should be possible to find all of these, by searching for "hidden" in the source code, so that they can be enumerated, and hopefully removed, thus removing the need for resetHiddenFields() itself. Likely, uses can be replaced with parameters to iceSubmit() and iceSubmitPartial(). An alternate strategy is depicted in ICE-5796, the parent task, for removing resetHiddenFields() itself.
            1. screenshot-01.png
              84 kB
            2. screenshot-02.png
              83 kB
            3. screenshot-03.png
              181 kB
            4. screenshot-04.png
              188 kB
            5. screenshot-05.png
              274 kB

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-5796 Try to eliminate resetHiddenFields() function in Compat Comps.

              • Major - Major loss of function.
              • Closed

                Activity

                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23287 Thu Dec 02 16:18:18 MST 2010 yip.ng ICE-5941: Remove reliance on resetHiddenFields() in compat components.
                Files Changed
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/submit.js
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23286 Thu Dec 02 16:08:17 MST 2010 yip.ng ICE-5941: Remove reliance on resetHiddenFields() in compat components.
                Files Changed
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/CommandLinkRenderer.java
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23283 Thu Dec 02 14:23:50 MST 2010 yip.ng ICE-5941: Remove reliance on resetHiddenFields() in compat components.
                Files Changed
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23279 Thu Dec 02 11:52:24 MST 2010 yip.ng ICE-5941: Remove reliance on resetHiddenFields() in compat components.
                Files Changed
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23270 Wed Dec 01 17:02:09 MST 2010 yip.ng ICE-5941: Remove reliance on resetHiddenFields() in compat components.
                Files Changed
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/outputchart/OutputChart.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23269 Wed Dec 01 14:15:44 MST 2010 yip.ng ICE-5941: Remove reliance on resetHiddenFields() in compat components.
                Files Changed
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23253 Tue Nov 30 15:31:59 MST 2010 yip.ng ICE-5941: Remove reliance on resetHiddenFields() in compat components.
                Files Changed
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23251 Tue Nov 30 13:56:10 MST 2010 yip.ng ICE-5941: Remove reliance on resetHiddenFields() in compat components.
                Files Changed
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23244 Mon Nov 29 17:34:39 MST 2010 yip.ng ICE-5941: Remove reliance on resetHiddenFields() in compat components.
                Files Changed
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/submit.js
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23231 Mon Nov 29 13:49:34 MST 2010 yip.ng ICE-5941: Remove reliance on resetHiddenFields() in compat components.
                Files Changed
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/submit.js

                  People

                  • Assignee:
                    yip.ng
                    Reporter:
                    Mark Collette
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: