ICEfaces
  1. ICEfaces
  2. ICE-5873

Sparkle Tabpane - Adopt latest coding best-practices

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta1
          • Fix Version/s: 2.0-Beta2, 2.0.0
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Sparkle components

            Description

            1. (ICE-5831) Adopt JSONBuilder.create() util method for generating parameter strings.

            2. (ICE-5830) Adopt ScriptWriter.insertScript() util method for inserting JavaScript.

            3. (ICE-5832) Adopt the 'ice.submit.type' bridge-maintained parameter for detecting the submit-type while decoding.

            4. (ICE-5805) Ensure that input components (any value-holder comps) are using a hidden form field for the value, and not parameters.

            5. Ensure that the component renderer is creating the recommended component hierarchy of a surrounding DIV (with ID), which itself contains the script elements generated by the ScriptWriter.insertScript() function (step 2 above), followed by another DIV which contains the rest of the component markup.

            The Calendar component can be used as a reference, once ICE-5872 is complete).

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Adnan Durrani added a comment -

              changes applied to the tabset component. Please see attached image.

              Command: Commit
              Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\component\src\org\icefaces\component\tab\TabSetRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\component\src\org\icefaces\component\tab\TabSetRenderer.java
              Completed: At revision: 22004

              Show
              Adnan Durrani added a comment - changes applied to the tabset component. Please see attached image. Command: Commit Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\component\src\org\icefaces\component\tab\TabSetRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\component\src\org\icefaces\component\tab\TabSetRenderer.java Completed: At revision: 22004
              Hide
              Permalink
              Adnan Durrani added a comment -

              Every suggestion is applied, except the span/script renders after the tabset elements and it works fine that way, if I try to put before tabset elements, I get errors.

              This is how tabset gets rendered(e.g.)

              <tabsetdiv >
              <tabset panel>
              <tabset contents>
              <span>
              <script>
              </script>
              </div>

              Show
              Adnan Durrani added a comment - Every suggestion is applied, except the span/script renders after the tabset elements and it works fine that way, if I try to put before tabset elements, I get errors. This is how tabset gets rendered(e.g.) <tabsetdiv > <tabset panel> <tabset contents> <span> <script> </script> </div>

                People

                • Assignee:
                  Adnan Durrani
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: