Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0-Beta1
-
Component/s: ICE-Components
-
Labels:None
-
Environment:Sparkle components
Description
1. (ICE-5831) Adopt JSONBuilder.create() util method for generating parameter strings.
2. (ICE-5830) Adopt ScriptWriter.insertScript() util method for inserting JavaScript.
3. (ICE-5832) Adopt the 'ice.submit.type' bridge-maintained parameter for detecting the submit-type while decoding.
4. (ICE-5805) Ensure that input components (any value-holder comps) are using a hidden form field for the value, and not parameters.
5. Ensure that the component renderer is creating the recommended component hierarchy of a surrounding DIV (with ID), which itself contains the script elements generated by the ScriptWriter.insertScript() function (step 2 above), followed by another DIV which contains the rest of the component markup.
The Calendar component can be used as a reference, onceICE-5872 is complete).
2. (
3. (
4. (
5. Ensure that the component renderer is creating the recommended component hierarchy of a surrounding DIV (with ID), which itself contains the script elements generated by the ScriptWriter.insertScript() function (step 2 above), followed by another DIV which contains the rest of the component markup.
The Calendar component can be used as a reference, once
Activity
| Field | Original Value | New Value |
|---|---|---|
| Summary | CLONE -Sparkle Tabpane - Adopt latest coding best-practices | Sparkle Tabpane - Adopt latest coding best-practices |
| Salesforce Case | [] | |
| Assignee Priority | P1 | |
| Assignee | Yip Ng [ yip.ng ] | Adnan Durrani [ adnan.durrani ] |
| Salesforce Case | [] | |
| Description |
1. ( 2. ( 3. ( 4. ( 5. Ensure that the component renderer is creating the recommended component hierarchy of a surrounding DIV (with ID), which itself contains the script elements generated by the ScriptWriter.insertScript() function (step 2 above), followed by another DIV which contains the rest of the component markup. |
1. ( 2. ( 3. ( 4. ( 5. Ensure that the component renderer is creating the recommended component hierarchy of a surrounding DIV (with ID), which itself contains the script elements generated by the ScriptWriter.insertScript() function (step 2 above), followed by another DIV which contains the rest of the component markup. The Calendar component can be used as a reference, once |
| Fix Version/s | 2.0-Beta2 [ 10242 ] | |
| Fix Version/s | 2.0-Beta1 [ 10231 ] |
| Assignee Priority | P2 |
| Security | Private [ 10001 ] |
| Salesforce Case | [] | |
| Assignee Priority | P2 | P1 |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #22004 | Thu Jul 22 22:31:10 MDT 2010 | adnan.durrani | Fix for |
| Files Changed | ||||
MODIFY
/icefaces/scratchpads/sparkle/component/src/org/icefaces/component/tab/TabSetRenderer.java
|
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Attachment | ICE-5873.jpg [ 12460 ] |
Every suggestion is applied, except the span/script renders after the tabset elements and it works fine that way, if I try to put before tabset elements, I get errors.
This is how tabset gets rendered(e.g.)
<tabsetdiv >
<tabset panel>
<tabset contents>
<span>
<script>
</script>
</div>
Show
Adnan Durrani
added a comment - Every suggestion is applied, except the span/script renders after the tabset elements and it works fine that way, if I try to put before tabset elements, I get errors.
This is how tabset gets rendered(e.g.)
<tabsetdiv >
<tabset panel>
<tabset contents>
<span>
<script>
</script>
</div>
| Fix Version/s | 2.0.0 [ 10230 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Assignee Priority | P1 |
changes applied to the tabset component. Please see attached image.
Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\component\src\org\icefaces\component\tab\TabSetRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\component\src\org\icefaces\component\tab\TabSetRenderer.java
Completed: At revision: 22004