ICEfaces
  1. ICEfaces
  2. ICE-5624

New CheckboxButton ACE component

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      all
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

      Description

      Create a new checkbox component for the Sparkle component suite based on the button checkbox YUI2 widget.

        Issue Links

          Activity

          Hide
          Judy Guglielmin added a comment -

          component has been created and reviewed, following the new standards for component development for ICEfaces-2.0.

          Items to note:-
          1) hidden field "_hidden" maintains the value of the "checked" attribute, which may be updated via the yui checkbox or server-push.
          the javascript params are no longer used for this input component
          2) singleSubmit=true means that the checkbutton submits to the server side, singleSubmit=false means that the hidden field gets updated
          and waits for some other component to submit the form to the server.
          3) the event has a null target (event.target), so this must be set for partial submit = true.
          4) aria support means that the space bar toggles the button for true/false.

          Show
          Judy Guglielmin added a comment - component has been created and reviewed, following the new standards for component development for ICEfaces-2.0. Items to note:- 1) hidden field "_hidden" maintains the value of the "checked" attribute, which may be updated via the yui checkbox or server-push. the javascript params are no longer used for this input component 2) singleSubmit=true means that the checkbutton submits to the server side, singleSubmit=false means that the hidden field gets updated and waits for some other component to submit the form to the server. 3) the event has a null target (event.target), so this must be set for partial submit = true. 4) aria support means that the space bar toggles the button for true/false.
          Hide
          Judy Guglielmin added a comment -

          any other features for this component could perhaps be within another jira.

          Show
          Judy Guglielmin added a comment - any other features for this component could perhaps be within another jira.
          Hide
          Judy Guglielmin added a comment -

          see ICE-5798 for details

          Show
          Judy Guglielmin added a comment - see ICE-5798 for details
          Hide
          Ken Fyten added a comment -

          Need a sam skin for this component also.

          Show
          Ken Fyten added a comment - Need a sam skin for this component also.
          Hide
          Ken Fyten added a comment - - edited

          Checkbox component has the following noted outstanding tasks/issues:

          Component Name:

          • Rename/repackage component to "CheckboxButton", incl. comp. name, tag name ("checkboxButton"), all classnames, componentFamily, etc.
          • Change componentFamily to "org.icefaces.component.CheckboxButton"

          Attributes:

          • Following attributes are not useful on a checkboxButton, need to be removed:
          • validatorMessage
          • image
          • requiredMessage
          • converter (useful?)
          • required

          Documentation:

          • Component level descriptive doc missing from TLD/taglib doc. This can be brief summation with link to the Wiki doc page.
          • The following attributes have insufficient doc:
          • styleClass
          • label
          • labelPosition (is this still a useful attribute? Why are the values only "on" and "left"? Should this positioning be done in CSS instead?)
          • singleSubmit (use std. description)
          • value
          • disabled
          • Wiki user doc:
          • No high-level component description at all
          • Should mimic the general contents and compleness from http://developer.yahoo.com/yui/autocomplete/, for example.
          • General config and usage should be covered, typical use-cases illustrated and described.

          CheckboxRenderer Impl.:

          • Don't need to check if rendered in decode and encode, because if false those methods wouldn't get called in Renderer (needs verification)
          • decode: if (requestParameterMap.containsKey("ice.event.captured")) { but doesn't use it (remove?)
          • encodeBegin: writer.write(checkbox.getLabel()); Should this use writeText to escape the label?
          • Reduce component property evaluations. Eg: findCheckboxLabel(Checkbox) by cacheing property values with local var.
          Show
          Ken Fyten added a comment - - edited Checkbox component has the following noted outstanding tasks/issues: Component Name: Rename/repackage component to "CheckboxButton", incl. comp. name, tag name ("checkboxButton"), all classnames, componentFamily, etc. Change componentFamily to "org.icefaces.component.CheckboxButton" Attributes: Following attributes are not useful on a checkboxButton, need to be removed: validatorMessage image requiredMessage converter (useful?) required Documentation: Component level descriptive doc missing from TLD/taglib doc. This can be brief summation with link to the Wiki doc page. The following attributes have insufficient doc: styleClass label labelPosition (is this still a useful attribute? Why are the values only "on" and "left"? Should this positioning be done in CSS instead?) singleSubmit (use std. description) value disabled Wiki user doc: No high-level component description at all Should mimic the general contents and compleness from http://developer.yahoo.com/yui/autocomplete/ , for example. General config and usage should be covered, typical use-cases illustrated and described. CheckboxRenderer Impl.: Don't need to check if rendered in decode and encode, because if false those methods wouldn't get called in Renderer (needs verification) decode: if (requestParameterMap.containsKey("ice.event.captured")) { but doesn't use it (remove?) encodeBegin: writer.write(checkbox.getLabel()); Should this use writeText to escape the label? Reduce component property evaluations. Eg: findCheckboxLabel(Checkbox) by cacheing property values with local var.
          Hide
          Judy Guglielmin added a comment -

          had to move disabled and tabindex to yuicomps (jscomps) for param map as they need to be able to be updated dynamically on the client.
          Also, singleSubmit must be retrieved from the javascript context setup in ice.components namespace in order to dyanmically update it. (do this in the fn registered to listen for the 'checkedChange' event).

          Show
          Judy Guglielmin added a comment - had to move disabled and tabindex to yuicomps (jscomps) for param map as they need to be able to be updated dynamically on the client. Also, singleSubmit must be retrieved from the javascript context setup in ice.components namespace in order to dyanmically update it. (do this in the fn registered to listen for the 'checkedChange' event).
          Hide
          Ken Fyten added a comment -

          Package name is: org.icefaces.component.checkboxButton.CheckboxButtonTag

          ...should be: org.icefaces.component.checkboxbutton.CheckboxButtonTag.

          Show
          Ken Fyten added a comment - Package name is: org.icefaces.component.checkboxButton.CheckboxButtonTag ...should be: org.icefaces.component.checkboxbutton.CheckboxButtonTag.

            People

            • Assignee:
              Judy Guglielmin
              Reporter:
              Arturo Zambrano
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: