ICEfaces
  1. ICEfaces
  2. ICE-5624

New CheckboxButton ACE component

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      all
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

      Description

      Create a new checkbox component for the Sparkle component suite based on the button checkbox YUI2 widget.

        Issue Links

          Activity

          Arturo Zambrano created issue -
          Arturo Zambrano made changes -
          Field Original Value New Value
          Assignee Arturo Zambrano [ artzambrano ]
          Arturo Zambrano made changes -
          Salesforce Case []
          Fix Version/s 2.0-Alpha3 [ 10032 ]
          Arturo Zambrano made changes -
          Salesforce Case []
          Component/s Components [ 10012 ]
          Ken Fyten made changes -
          Salesforce Case []
          Security Private [ 10001 ]
          Ken Fyten made changes -
          Fix Version/s 2.0-Beta [ 10231 ]
          Fix Version/s 2.0-Alpha3 [ 10032 ]
          Ken Fyten made changes -
          Salesforce Case []
          Affects [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial]
          Assignee Arturo Zambrano [ artzambrano ] Judy Guglielmin [ judy.guglielmin ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #21725 Fri Jun 11 09:00:39 MDT 2010 judy.guglielmin ICE-5624
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/showcase/test/web/buttons/checkbox.xhtml
          Hide
          Judy Guglielmin added a comment -

          component has been created and reviewed, following the new standards for component development for ICEfaces-2.0.

          Items to note:-
          1) hidden field "_hidden" maintains the value of the "checked" attribute, which may be updated via the yui checkbox or server-push.
          the javascript params are no longer used for this input component
          2) singleSubmit=true means that the checkbutton submits to the server side, singleSubmit=false means that the hidden field gets updated
          and waits for some other component to submit the form to the server.
          3) the event has a null target (event.target), so this must be set for partial submit = true.
          4) aria support means that the space bar toggles the button for true/false.

          Show
          Judy Guglielmin added a comment - component has been created and reviewed, following the new standards for component development for ICEfaces-2.0. Items to note:- 1) hidden field "_hidden" maintains the value of the "checked" attribute, which may be updated via the yui checkbox or server-push. the javascript params are no longer used for this input component 2) singleSubmit=true means that the checkbutton submits to the server side, singleSubmit=false means that the hidden field gets updated and waits for some other component to submit the form to the server. 3) the event has a null target (event.target), so this must be set for partial submit = true. 4) aria support means that the space bar toggles the button for true/false.
          Hide
          Judy Guglielmin added a comment -

          any other features for this component could perhaps be within another jira.

          Show
          Judy Guglielmin added a comment - any other features for this component could perhaps be within another jira.
          Judy Guglielmin made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Judy Guglielmin added a comment -

          see ICE-5798 for details

          Show
          Judy Guglielmin added a comment - see ICE-5798 for details
          Judy Guglielmin made changes -
          Link This issue is duplicated by ICE-5798 [ ICE-5798 ]
          Ken Fyten made changes -
          Fix Version/s 2.0-Beta2 [ 10242 ]
          Fix Version/s 2.0-Beta1 [ 10231 ]
          Ken Fyten made changes -
          Security Private [ 10001 ]
          Hide
          Ken Fyten added a comment -

          Need a sam skin for this component also.

          Show
          Ken Fyten added a comment - Need a sam skin for this component also.
          Ken Fyten made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22403 Thu Sep 23 09:38:43 MDT 2010 judy.guglielmin ICE-5624 updated rime skin for checkbox
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkbox/sprites/rime/checkbox.css
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22406 Thu Sep 23 11:43:25 MDT 2010 judy.guglielmin ICE-5624 labelPosition and rime/Sam skin
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkbox/CheckboxMeta.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkbox/CheckboxRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22407 Thu Sep 23 11:44:12 MDT 2010 judy.guglielmin ICE-5624 test pages for checkbutton in rime and sam
          Files Changed
          Commit graph ADD /icefaces/scratchpads/sparkle/showcase/test/web/buttons/checkboxSam.xhtml
          Commit graph ADD /icefaces/scratchpads/sparkle/showcase/test/web/buttons/mixedRime.xhtml
          Commit graph ADD /icefaces/scratchpads/sparkle/showcase/test/web/buttons/mixedSam.xhtml
          Commit graph ADD /icefaces/scratchpads/sparkle/showcase/test/web/buttons/checkboxRime.xhtml
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22408 Thu Sep 23 11:44:55 MDT 2010 judy.guglielmin ICE-5624 rime and sam skin test pages for checkbutton with labelPosition attribute
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/showcase/test/web/buttons.xhtml
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22409 Thu Sep 23 12:26:03 MDT 2010 judy.guglielmin ICE-5624 checkboxes in tables
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/showcase/test/web/buttons/mixedRime.xhtml
          Commit graph MODIFY /icefaces/scratchpads/sparkle/showcase/test/web/buttons/mixedSam.xhtml
          Commit graph ADD /icefaces/scratchpads/sparkle/showcase/test/web/buttons/buttonTableSam.xhtml
          Commit graph ADD /icefaces/scratchpads/sparkle/showcase/test/web/buttons/buttonTableRime.xhtml
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22411 Thu Sep 23 12:48:20 MDT 2010 judy.guglielmin ICE-5624
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkbox/checkbox.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22500 Mon Oct 04 10:11:17 MDT 2010 judy.guglielmin ICE-5624 update renderer to ensure same use as mojarra renderer for 2.0 and 1.2 latest
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkbox/CheckboxRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22554 Thu Oct 07 08:32:39 MDT 2010 judy.guglielmin ICE-5624 remove image property
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkbox/CheckboxMeta.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkbox/CheckboxRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22560 Thu Oct 07 11:19:56 MDT 2010 judy.guglielmin ICE-5624 removed image property on <ice:pushbutton>
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/showcase/test/web/buttons/pushbutton.xhtml
          Hide
          Ken Fyten added a comment - - edited

          Checkbox component has the following noted outstanding tasks/issues:

          Component Name:

          • Rename/repackage component to "CheckboxButton", incl. comp. name, tag name ("checkboxButton"), all classnames, componentFamily, etc.
          • Change componentFamily to "org.icefaces.component.CheckboxButton"

          Attributes:

          • Following attributes are not useful on a checkboxButton, need to be removed:
          • validatorMessage
          • image
          • requiredMessage
          • converter (useful?)
          • required

          Documentation:

          • Component level descriptive doc missing from TLD/taglib doc. This can be brief summation with link to the Wiki doc page.
          • The following attributes have insufficient doc:
          • styleClass
          • label
          • labelPosition (is this still a useful attribute? Why are the values only "on" and "left"? Should this positioning be done in CSS instead?)
          • singleSubmit (use std. description)
          • value
          • disabled
          • Wiki user doc:
          • No high-level component description at all
          • Should mimic the general contents and compleness from http://developer.yahoo.com/yui/autocomplete/, for example.
          • General config and usage should be covered, typical use-cases illustrated and described.

          CheckboxRenderer Impl.:

          • Don't need to check if rendered in decode and encode, because if false those methods wouldn't get called in Renderer (needs verification)
          • decode: if (requestParameterMap.containsKey("ice.event.captured")) { but doesn't use it (remove?)
          • encodeBegin: writer.write(checkbox.getLabel()); Should this use writeText to escape the label?
          • Reduce component property evaluations. Eg: findCheckboxLabel(Checkbox) by cacheing property values with local var.
          Show
          Ken Fyten added a comment - - edited Checkbox component has the following noted outstanding tasks/issues: Component Name: Rename/repackage component to "CheckboxButton", incl. comp. name, tag name ("checkboxButton"), all classnames, componentFamily, etc. Change componentFamily to "org.icefaces.component.CheckboxButton" Attributes: Following attributes are not useful on a checkboxButton, need to be removed: validatorMessage image requiredMessage converter (useful?) required Documentation: Component level descriptive doc missing from TLD/taglib doc. This can be brief summation with link to the Wiki doc page. The following attributes have insufficient doc: styleClass label labelPosition (is this still a useful attribute? Why are the values only "on" and "left"? Should this positioning be done in CSS instead?) singleSubmit (use std. description) value disabled Wiki user doc: No high-level component description at all Should mimic the general contents and compleness from http://developer.yahoo.com/yui/autocomplete/ , for example. General config and usage should be covered, typical use-cases illustrated and described. CheckboxRenderer Impl.: Don't need to check if rendered in decode and encode, because if false those methods wouldn't get called in Renderer (needs verification) decode: if (requestParameterMap.containsKey("ice.event.captured")) { but doesn't use it (remove?) encodeBegin: writer.write(checkbox.getLabel()); Should this use writeText to escape the label? Reduce component property evaluations. Eg: findCheckboxLabel(Checkbox) by cacheing property values with local var.
          Ken Fyten made changes -
          Salesforce Case []
          Assignee Priority P1
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22603 Wed Oct 13 11:22:32 MDT 2010 judy.guglielmin ICE-5624 renamed to checkboxButton, put disabled and tabindex in jsProps params. removed unnecessary statements from Renderer as per jira
          Files Changed
          Commit graph ADD /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxButton
          Commit graph DEL /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxButton/checkbox.css
          Commit graph ADD /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxButton/checkboxButton.css
          Commit graph ADD /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxButton/checkboxButton.js
          Commit graph DEL /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxButton/checkbox.js
          Commit graph DEL /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkbox
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22604 Wed Oct 13 11:26:21 MDT 2010 judy.guglielmin ICE-5624 renamed to checkboxButton, put disabled and tabindex in jsProps params. removed unnecessary statements from Renderer as per jira
          Files Changed
          Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxButton/CheckboxButtonRenderer.java
          Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxButton
          Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxButton/CheckboxButton.java
          Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxButton/skins/rime/checkboxButton.css
          Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxButton/CheckboxButtonMeta.java
          Hide
          Judy Guglielmin added a comment -

          had to move disabled and tabindex to yuicomps (jscomps) for param map as they need to be able to be updated dynamically on the client.
          Also, singleSubmit must be retrieved from the javascript context setup in ice.components namespace in order to dyanmically update it. (do this in the fn registered to listen for the 'checkedChange' event).

          Show
          Judy Guglielmin added a comment - had to move disabled and tabindex to yuicomps (jscomps) for param map as they need to be able to be updated dynamically on the client. Also, singleSubmit must be retrieved from the javascript context setup in ice.components namespace in order to dyanmically update it. (do this in the fn registered to listen for the 'checkedChange' event).
          Hide
          Ken Fyten added a comment -

          Package name is: org.icefaces.component.checkboxButton.CheckboxButtonTag

          ...should be: org.icefaces.component.checkboxbutton.CheckboxButtonTag.

          Show
          Ken Fyten added a comment - Package name is: org.icefaces.component.checkboxButton.CheckboxButtonTag ...should be: org.icefaces.component.checkboxbutton.CheckboxButtonTag.
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22669 Mon Oct 18 14:56:33 MDT 2010 judy.guglielmin ICE-5624 rename checkbox package
          Files Changed
          Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxButton-int
          Commit graph DEL /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxButton
          Commit graph DEL /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxButton
          Commit graph ADD /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxButton-int
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/build.properties
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22670 Mon Oct 18 14:57:58 MDT 2010 judy.guglielmin ICE-5624 rename checkbox package
          Files Changed
          Commit graph DEL /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxButton-int
          Commit graph DEL /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxButton-int
          Commit graph ADD /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxbutton
          Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxbutton
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22671 Mon Oct 18 15:03:28 MDT 2010 judy.guglielmin ICE-5624 updating references for repackaging
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxbutton/CheckboxButtonMeta.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxbutton/CheckboxButton.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxbutton/CheckboxButtonRenderer.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxbutton/checkboxButton.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22672 Mon Oct 18 15:04:56 MDT 2010 judy.guglielmin ICE-5624 intermediate step for renaming packages
          Files Changed
          Commit graph ADD /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxbutton/checkboxBbutton.css
          Commit graph ADD /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxbutton/checkboxBbutton.js
          Commit graph DEL /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxbutton/checkboxButton.css
          Commit graph DEL /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxbutton/checkboxButton.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22673 Mon Oct 18 15:09:14 MDT 2010 judy.guglielmin ICE-5624 finally finished renaming checkboxButton to checkboxbutton
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/build.xml
          Commit graph ADD /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxbutton/checkboxbutton.css
          Commit graph ADD /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxbutton/checkboxbutton.js
          Commit graph DEL /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxbutton/checkboxBbutton.css
          Commit graph DEL /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.checkboxbutton/checkboxBbutton.js
          Ken Fyten made changes -
          Summary ICEfaces 2.0 create checkbox component for Sparkle component suite New CheckboxButton ACE component
          Salesforce Case []
          Component/s ACE-Components [ 10050 ]
          Component/s Components [ 10012 ]
          Assignee Priority P1
          Ken Fyten made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Fix Version/s 2.0.0 [ 10230 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Cruz Miraback made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Cruz Miraback made changes -
          Comment [ A comment with security level 'icesoft-internal-developers' was removed. ]
          Cruz Miraback made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Judy Guglielmin
              Reporter:
              Arturo Zambrano
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: