Details
-
Type:
New Feature
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0-Alpha2
-
Fix Version/s: 2.0-Alpha3, 2.0.0
-
Component/s: Bridge
-
Labels:None
-
Environment:ICEfaces 2.0 Alpha2 / JSF 2.
Description
Issue Links
- blocks
-
ICE-5536
The action method of two components are called when Enter key is pressed
-
- Closed
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
All h:* components work properly, including h:commandButton and h:commandLink. "repo\qa\trunk\Regression-Icefaces2\ICE-5574" test is using forward navigation for h:commandButton and h:commandLink when successfully submitted. But there seems to be a bug with navigation in JSF 2.0.2 because the javax.faces.ViewState hidden input fields belonging to the forms are missing after navigation is executed (hence oldDOM = null).
Modifying the test to have h:commandLink and h:commandButton increment an associated counter instead of running navigation rules shows that these components work as well.
As for ice:* components here are my discoveries:
1) ice:selectManyCheckbox – indeed the NullPointerException is present, looking at the renderer code it is obvious that when a SelectItemGroup is nested the markup generation is wrong. I'll attach a patch to this case for com.icesoft.faces.renderkit.dom_html_basic.SelectManyCheckboxListRenderer.
2) Following components work as expected as long "partialSubmit" attribute is removed:
selectBooleanCheckbox
selectManyListbox
selectManyMenu
selectOneListbox
selectOneMenu
selectOneRadio
3) ice:commandLink is not working because the rendered anchor normally changes the value of a hidden input element (in the event handler) just before invoking iceSubmit. When Enter key is pressed iceSubmit will serialize the hidden input field, but its value is not changed as required.
I guess the solution would be to change renderer's decode method to not rely on the named input hidden field.
Changed submit code to avoid form submission when Enter key is pressed in textarea elements. The affected components, h:inputTextarea and ice:inputTextarea, are not going to submit the form on Enter.
Follow-up JIRAs created for issue #1, ice:selectManyCheckbox (ICE-5672), and issue #3, ice:commandLink (ICE-5673) above.
Marking fixed.
Introduced system event listener that wires up any rendered form to capture enter key presses. The JS event handler is registered with the form element capturing thus any enter key presses that can arrive from any input or select elements enclosed within the form.
Here's a link that describes the difference in IE's behavior without the fix for this issue: http://www.thefutureoftheweb.com/blog/submit-a-form-in-ie-with-enter .