Details
Description
The issue is that we have assumed that any component that fired an action event on "enter" would also consume the "enter" key event so that it would not bubble up the DOM. This appears to be an incorrect assumption in this case.
- this behavior can cause problems with validators/users as the they are
under the perception that just one submit has occurred, the double submit
will likely leave the application in an unexpected state.
- Workaround in auction is to avoid having an action listener on the input field.
- Ideally the framework would not do the full form submit if the component already had an action listener ready to fire.
Issue Links
- duplicates
-
ICE-5536
The action method of two components are called when Enter key is pressed
-
- Closed
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Just checked in some changes for the the compat/auctionMonitor to use standard JSF validation, more or less, http://jira.icefaces.org/browse/ICE-5975.
The auction monitor's bid inputText field now has an action listener that will handle a bid as well as a validator to check the bid. When I types a new bid value and type renturn I get a double submit. The first bid/submit is accepted and the effect fires but the second submit resends the bid value resulting in a validation error as the bid is equal to the current item price.
I've done a full clean and build of the core and compat so I don't think I'm seeing a JavaScript cache issue. Can you start up compat/auctionMonitor to see if you can reproduce the behaviour I'm seeing?
The test in ice.submit function which verifies if an event needs to have its default action canceled fails to return true when the enter key is pressed. More precisely isKeyEvent returns 'false' which is not correct since the event is triggered by a key press. The browser specific key events inherit from both KeyEvent and NetscapeEvent/IEEvent classes. isKeyEvent is not overridden because the object will pick the method of the first defined ancestor (NetscapeEvent/IEEvent ), but really the method expected to be picked is found on the KeyEvent ancestor.
To fix changes the order of inheritance for the events that use multiple inehritance to make sure the isKeyEvent or isMouseEvent are overrriden properly.
Modified ice.s and ice.ss functions to cancel the event bubbling. In case there is an event handler on the event triggering form element the event will not propagate to the parent 'form' element thus avoiding the additional submit.