[ICE-5253] SelectInputDate should have seconds drop down item in the date time picker - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.8.2
Fix Version/s: 1.8.3, 1.8.2-EE-GA_P02, 2.0.0
Component/s: ICE-Components
Labels:
None
Environment:
Operating System: Oracle Enterprise Linux x86_64
Java version: 1.6.0_13

Affects:

Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

Description

SelectInputDate should have seconds drop down item in the date time picker, currently it only provides hours and minutes.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

ICE-5253.patch

11/Jan/10 6:48 PM

16 kB

Gary Chan
ICE-5253-part2.patch

11/Jan/10 10:15 PM

0.8 kB

Gary Chan

screenshot-01.png

228 kB

04/Nov/10 6:03 PM

Activity

Ascending order - Click to sort in descending order

Gary Chan created issue - 11/Jan/10 6:39 PM

Hide

Permalink

Gary Chan added a comment - 11/Jan/10 6:44 PM

Attached is my patch file to address this issue.

Show

Gary Chan added a comment - 11/Jan/10 6:44 PM Attached is my patch file to address this issue.

Gary Chan made changes - 11/Jan/10 6:44 PM

Field	Original Value	New Value
Attachment		ICE-5253.patch [ 12143 ]

Gary Chan made changes - 11/Jan/10 6:47 PM

Attachment

~~ICE-5253~~.patch [ 12143 ]

Hide

Permalink

Gary Chan added a comment - 11/Jan/10 6:48 PM

Attached is my patch file to address this issue.

Show

Gary Chan added a comment - 11/Jan/10 6:48 PM Attached is my patch file to address this issue.

Gary Chan made changes - 11/Jan/10 6:48 PM

Attachment

ICE-5253.patch [ 12144 ]

Hide

Permalink

Gary Chan added a comment - 11/Jan/10 10:15 PM

Missed one line of changes, now submit it as part2 patch

Show

Gary Chan added a comment - 11/Jan/10 10:15 PM Missed one line of changes, now submit it as part2 patch

Gary Chan made changes - 11/Jan/10 10:15 PM

Attachment

ICE-5253-part2.patch [ 12145 ]

Ken Fyten made changes - 20/Jan/10 4:08 PM

Salesforce Case		[]
Fix Version/s		1.8.3 [ 10211 ]

Arran Mccullough made changes - 21/Jan/10 11:03 AM

Salesforce Case

[5007000000Ap9wy]

Ken Fyten made changes - 01/Apr/10 11:31 AM

Fix Version/s		1.8.2-EE-GA_P02 [ 10226 ]
Affects		[Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial]

Ken Fyten made changes - 02/Nov/10 3:34 PM

Fix Version/s		2.0.0 [ 10230 ]
Assignee Priority		P3
Assignee		Yip Ng [ yip.ng ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#23033	Thu Nov 04 14:22:06 MDT 2010	yip.ng	~~ICE-5253~~: SelectInputDate should have seconds drop down item in the date time picker -- with patches from Gary Chan.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#23034	Thu Nov 04 15:42:36 MDT 2010	yip.ng	~~ICE-5253~~: SelectInputDate should have seconds drop down item in the date time picker -- with patches from Gary Chan.
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDate.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#23035	Thu Nov 04 16:16:15 MDT 2010	yip.ng	~~ICE-5253~~: SelectInputDate should have seconds drop down item in the date time picker -- with patches from Gary Chan.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/samples/component-showcase/common-web/WEB-INF/includes/examples/custom/selectInputDate.jspx MODIFY /icefaces/trunk/icefaces/samples/component-showcase/common-src/org/icefaces/application/showcase/view/bean/examples/component/selectInputDate/SelectInputDateBean.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#23036	Thu Nov 04 16:25:56 MDT 2010	yip.ng	~~ICE-5253~~: SelectInputDate should have seconds drop down item in the date time picker -- with patches from Gary Chan.
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/compat/samples/component-showcase/web/WEB-INF/includes/examples/custom/selectInputDate.xhtml MODIFY /icefaces2/trunk/icefaces/compat/samples/component-showcase/src/org/icefaces/application/showcase/view/bean/examples/component/selectInputDate/SelectInputDateBean.java

yip.ng made changes - 04/Nov/10 6:03 PM

Attachment

screenshot-01.png [ 12653 ]

Hide

Permalink

yip.ng added a comment - 04/Nov/10 6:05 PM - edited

Patches applied. See screenshot 1.

Revision: 23033

Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

Revision: 23034

Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

Revision: 23035

Modified : /icefaces/trunk/icefaces/samples/component-showcase/common-src/org/icefaces/application/showcase/view/bean/examples/component/selectInputDate/SelectInputDateBean.java
Modified : /icefaces/trunk/icefaces/samples/component-showcase/common-web/WEB-INF/includes/examples/custom/selectInputDate.jspx

Revision: 23036

Modified : /icefaces2/trunk/icefaces/compat/samples/component-showcase/src/org/icefaces/application/showcase/view/bean/examples/component/selectInputDate/SelectInputDateBean.java
Modified : /icefaces2/trunk/icefaces/compat/samples/component-showcase/web/WEB-INF/includes/examples/custom/selectInputDate.xhtml

Show

yip.ng added a comment - 04/Nov/10 6:05 PM - edited Patches applied. See screenshot 1. Revision: 23033 Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java Revision: 23034 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDate.java Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java Revision: 23035 Modified : /icefaces/trunk/icefaces/samples/component-showcase/common-src/org/icefaces/application/showcase/view/bean/examples/component/selectInputDate/SelectInputDateBean.java Modified : /icefaces/trunk/icefaces/samples/component-showcase/common-web/WEB-INF/includes/examples/custom/selectInputDate.jspx Revision: 23036 Modified : /icefaces2/trunk/icefaces/compat/samples/component-showcase/src/org/icefaces/application/showcase/view/bean/examples/component/selectInputDate/SelectInputDateBean.java Modified : /icefaces2/trunk/icefaces/compat/samples/component-showcase/web/WEB-INF/includes/examples/custom/selectInputDate.xhtml

yip.ng made changes - 04/Nov/10 6:05 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Ken Fyten added a comment - 05/Nov/10 11:14 AM

This change seems related to a new regression failure:

~~ICE-4011~~ Exception seen on application page when month selection is changed (problem reproducible on component-showcase calendar)
java.lang.RuntimeException: wrapped Exception: java.lang.NullPointerException
com.icesoft.faces.webapp.http.servlet.MainServlet.service(MainServlet.java:209)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
com.icesoft.faces.webapp.xmlhttp.BlockingServlet.service(BlockingServlet.java:55)
root cause

java.lang.NullPointerException com.icesoft.faces.component.selectinputdate.SelectInputDateRenderer.encodeEnd(SelectInputDateRenderer.java:636) javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:861)

Show

Ken Fyten added a comment - 05/Nov/10 11:14 AM This change seems related to a new regression failure: ICE-4011 Exception seen on application page when month selection is changed (problem reproducible on component-showcase calendar) java.lang.RuntimeException: wrapped Exception: java.lang.NullPointerException com.icesoft.faces.webapp.http.servlet.MainServlet.service(MainServlet.java:209) javax.servlet.http.HttpServlet.service(HttpServlet.java:717) com.icesoft.faces.webapp.xmlhttp.BlockingServlet.service(BlockingServlet.java:55) root cause java.lang.NullPointerException com.icesoft.faces.component.selectinputdate.SelectInputDateRenderer.encodeEnd(SelectInputDateRenderer.java:636) javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:861)

Ken Fyten made changes - 05/Nov/10 11:14 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Ken Fyten made changes - 05/Nov/10 11:14 AM

Assignee Priority

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#23054	Mon Nov 08 15:24:50 MST 2010	yip.ng	~~ICE-5253~~: SelectInputDate should have seconds drop down item in the date time picker.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#23055	Mon Nov 08 15:26:47 MST 2010	yip.ng	~~ICE-5253~~: SelectInputDate should have seconds drop down item in the date time picker.
				Files Changed
				MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

Hide

Permalink

yip.ng added a comment - 08/Nov/10 4:45 PM

Happens only with formats "MM/dd/yyyy HH:mm" and "MM/dd/yyyy hh:mm a", not with formats "MM/dd/yyyy" and "MMM/dd/yyyy HH:mm:ss".

Show

yip.ng added a comment - 08/Nov/10 4:45 PM Happens only with formats "MM/dd/yyyy HH:mm" and "MM/dd/yyyy hh:mm a", not with formats "MM/dd/yyyy" and "MMM/dd/yyyy HH:mm:ss".

Hide

Permalink

yip.ng added a comment - 08/Nov/10 4:53 PM

Line in error is from the patch:

sec = selectInputDate.getSecondsSubmittedValue().intValue();

Double checked changes applied. Didn't seem to have done anything wrong.

Show

yip.ng added a comment - 08/Nov/10 4:53 PM Line in error is from the patch: sec = selectInputDate.getSecondsSubmittedValue().intValue(); Double checked changes applied. Didn't seem to have done anything wrong.

Hide

Permalink

yip.ng added a comment - 08/Nov/10 5:46 PM

Added null checking for seconds.

Revision: 23054

Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

Revision: 23055

Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

Show

yip.ng added a comment - 08/Nov/10 5:46 PM Added null checking for seconds. Revision: 23054 Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java Revision: 23055 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

yip.ng made changes - 08/Nov/10 5:46 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

yip.ng added a comment - 17/Nov/10 7:34 PM

See ~~ICE-6267~~ for another problem caused by this patch.

Show

yip.ng added a comment - 17/Nov/10 7:34 PM See ICE-6267 for another problem caused by this patch.

Tyler Johnson made changes - 23/Nov/10 7:17 PM

Salesforce Case

[5007000000Ap9wy]

[5007000000Ap9wy, 5007000000Arzmb]

Ken Fyten made changes - 03/Jan/11 4:18 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee Priority	P1

People

Assignee:

yip.ng

Reporter:

Gary Chan

Votes:

1 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

11/Jan/10 6:39 PM

Updated:

03/Jan/11 4:18 PM

Resolved:

08/Nov/10 5:46 PM