ICEfaces
  1. ICEfaces
  2. ICE-5253

SelectInputDate should have seconds drop down item in the date time picker

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2
    • Fix Version/s: 1.8.3, 1.8.2-EE-GA_P02, 2.0.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Operating System: Oracle Enterprise Linux x86_64
      Java version: 1.6.0_13
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

      Description

      SelectInputDate should have seconds drop down item in the date time picker, currently it only provides hours and minutes.
      1. ICE-5253.patch
        16 kB
        Gary Chan
      2. ICE-5253-part2.patch
        0.8 kB
        Gary Chan
      1. screenshot-01.png
        228 kB

        Activity

        Hide
        Gary Chan added a comment -

        Attached is my patch file to address this issue.

        Show
        Gary Chan added a comment - Attached is my patch file to address this issue.
        Hide
        Gary Chan added a comment -

        Attached is my patch file to address this issue.

        Show
        Gary Chan added a comment - Attached is my patch file to address this issue.
        Hide
        Gary Chan added a comment -

        Missed one line of changes, now submit it as part2 patch

        Show
        Gary Chan added a comment - Missed one line of changes, now submit it as part2 patch
        Hide
        yip.ng added a comment - - edited

        Patches applied. See screenshot 1.

        Revision: 23033


        Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
        Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

        Revision: 23034


        Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
        Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

        Revision: 23035


        Modified : /icefaces/trunk/icefaces/samples/component-showcase/common-src/org/icefaces/application/showcase/view/bean/examples/component/selectInputDate/SelectInputDateBean.java
        Modified : /icefaces/trunk/icefaces/samples/component-showcase/common-web/WEB-INF/includes/examples/custom/selectInputDate.jspx

        Revision: 23036


        Modified : /icefaces2/trunk/icefaces/compat/samples/component-showcase/src/org/icefaces/application/showcase/view/bean/examples/component/selectInputDate/SelectInputDateBean.java
        Modified : /icefaces2/trunk/icefaces/compat/samples/component-showcase/web/WEB-INF/includes/examples/custom/selectInputDate.xhtml

        Show
        yip.ng added a comment - - edited Patches applied. See screenshot 1. Revision: 23033 Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java Revision: 23034 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDate.java Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java Revision: 23035 Modified : /icefaces/trunk/icefaces/samples/component-showcase/common-src/org/icefaces/application/showcase/view/bean/examples/component/selectInputDate/SelectInputDateBean.java Modified : /icefaces/trunk/icefaces/samples/component-showcase/common-web/WEB-INF/includes/examples/custom/selectInputDate.jspx Revision: 23036 Modified : /icefaces2/trunk/icefaces/compat/samples/component-showcase/src/org/icefaces/application/showcase/view/bean/examples/component/selectInputDate/SelectInputDateBean.java Modified : /icefaces2/trunk/icefaces/compat/samples/component-showcase/web/WEB-INF/includes/examples/custom/selectInputDate.xhtml
        Hide
        Ken Fyten added a comment -

        This change seems related to a new regression failure:

        ICE-4011 Exception seen on application page when month selection is changed (problem reproducible on component-showcase calendar)
        java.lang.RuntimeException: wrapped Exception: java.lang.NullPointerException
        com.icesoft.faces.webapp.http.servlet.MainServlet.service(MainServlet.java:209)
        javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
        com.icesoft.faces.webapp.xmlhttp.BlockingServlet.service(BlockingServlet.java:55)
        root cause

        java.lang.NullPointerException com.icesoft.faces.component.selectinputdate.SelectInputDateRenderer.encodeEnd(SelectInputDateRenderer.java:636) javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:861)

        Show
        Ken Fyten added a comment - This change seems related to a new regression failure: ICE-4011 Exception seen on application page when month selection is changed (problem reproducible on component-showcase calendar) java.lang.RuntimeException: wrapped Exception: java.lang.NullPointerException com.icesoft.faces.webapp.http.servlet.MainServlet.service(MainServlet.java:209) javax.servlet.http.HttpServlet.service(HttpServlet.java:717) com.icesoft.faces.webapp.xmlhttp.BlockingServlet.service(BlockingServlet.java:55) root cause java.lang.NullPointerException com.icesoft.faces.component.selectinputdate.SelectInputDateRenderer.encodeEnd(SelectInputDateRenderer.java:636) javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:861)
        Hide
        yip.ng added a comment -

        Happens only with formats "MM/dd/yyyy HH:mm" and "MM/dd/yyyy hh:mm a", not with formats "MM/dd/yyyy" and "MMM/dd/yyyy HH:mm:ss".

        Show
        yip.ng added a comment - Happens only with formats "MM/dd/yyyy HH:mm" and "MM/dd/yyyy hh:mm a", not with formats "MM/dd/yyyy" and "MMM/dd/yyyy HH:mm:ss".
        Hide
        yip.ng added a comment -

        Line in error is from the patch:

        sec = selectInputDate.getSecondsSubmittedValue().intValue();

        Double checked changes applied. Didn't seem to have done anything wrong.

        Show
        yip.ng added a comment - Line in error is from the patch: sec = selectInputDate.getSecondsSubmittedValue().intValue(); Double checked changes applied. Didn't seem to have done anything wrong.
        Hide
        yip.ng added a comment -

        Added null checking for seconds.

        Revision: 23054


        Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

        Revision: 23055


        Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java

        Show
        yip.ng added a comment - Added null checking for seconds. Revision: 23054 Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java Revision: 23055 Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
        Hide
        yip.ng added a comment -

        See ICE-6267 for another problem caused by this patch.

        Show
        yip.ng added a comment - See ICE-6267 for another problem caused by this patch.

          People

          • Assignee:
            yip.ng
            Reporter:
            Gary Chan
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: