ICEfaces
  1. ICEfaces
  2. ICE-4581

Add id to conversation Id Parameter with Seam so entire form is not included in DomDiff when pushed

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.1
    • Fix Version/s: 1.8.2-RC1, 1.8.2
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Seam, ajax-push

      Description

      From http://www.seamframework.org/Community/ConversationIdHiddenFieldAndICEFaces investigation showed that the conversation id was included on the form in a hidden field but that no id was associated with it (use <s:link> for redirection/navigation to show this hidden form field).

      If the cid is required to be a hidden field on the form, then the id should also be the conversation Id parameter and class com.icesoft.faces.renderkit.dom_html_basic.FormRenderer should be modified for this.

       


        Activity

        Hide
        Deryk Sinotte added a comment -

        Assigning to Greg: If we find a conversation id, we add a hidden parameter to the form. It simply needs an id attribute so that the DOMDiffing algorithm can efficiently update it as required.

        Show
        Deryk Sinotte added a comment - Assigning to Greg: If we find a conversation id, we add a hidden parameter to the form. It simply needs an id attribute so that the DOMDiffing algorithm can efficiently update it as required.
        Hide
        Greg Dick added a comment -

        Change is checked in but needs a test

        Show
        Greg Dick added a comment - Change is checked in but needs a test

          People

          • Assignee:
            Greg Dick
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: