ICEfaces
  1. ICEfaces
  2. ICE-4581

Add id to conversation Id Parameter with Seam so entire form is not included in DomDiff when pushed

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.1
          • Fix Version/s: 1.8.2-RC1, 1.8.2
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            Seam, ajax-push

            Description

            From http://www.seamframework.org/Community/ConversationIdHiddenFieldAndICEFaces investigation showed that the conversation id was included on the form in a hidden field but that no id was associated with it (use <s:link> for redirection/navigation to show this hidden form field).

            If the cid is required to be a hidden field on the form, then the id should also be the conversation Id parameter and class com.icesoft.faces.renderkit.dom_html_basic.FormRenderer should be modified for this.

             


              Activity

              Descending order - Click to sort in ascending order
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Ken Fyten made changes -
              Fix Version/s 1.8.2-RC1 [ 10210 ]
              Ken Fyten made changes -
              Issue Type Bug [ 1 ] Improvement [ 4 ]
              Salesforce Case []
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19226 Fri Sep 04 11:47:44 MDT 2009 greg.dick ICE-4581 packaging change
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/LifecycleExecutor.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19225 Fri Sep 04 11:43:30 MDT 2009 greg.dick ICE-4581 packaging change
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/env/SpringWebFlowInstantiationServlet.java
              Greg Dick made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Greg Dick added a comment -

              Change is checked in but needs a test

              Show
              Greg Dick added a comment - Change is checked in but needs a test
              Deryk Sinotte made changes -
              Assignee Mircea Toma [ mircea.toma ] Greg Dick [ greg.dick ]
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Assigning to Greg: If we find a conversation id, we add a hidden parameter to the form. It simply needs an id attribute so that the DOMDiffing algorithm can efficiently update it as required.

              Show
              Deryk Sinotte added a comment - Assigning to Greg: If we find a conversation id, we add a hidden parameter to the form. It simply needs an id attribute so that the DOMDiffing algorithm can efficiently update it as required.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19222 Thu Sep 03 16:41:46 MDT 2009 greg.dick ICE-4581 Added an id attribute to the hidden input field containing the conversation id so that if it changes the dom diff update will be minimal
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java
              Deryk Sinotte made changes -
              Assignee Mircea Toma [ mircea.toma ]
              Judy Guglielmin made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 1.8.2 [ 10190 ]
              Judy Guglielmin created issue -

                People

                • Assignee:
                  Greg Dick
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: