ICEfaces
  1. ICEfaces
  2. ICE-4256

Disabled ice:dataPaginator buttons not styled correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.8RC2
    • Fix Version/s: 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 1.8.0-RC2
    • Workaround Exists:
      Yes
    • Workaround Description:
      Workaround is to have the application dynamically set the images to a disabled image when viewing pg.1 or pg. last.

      Description

      When viewing the first or last page using the ice:dataPaginator the previous or next page buttons are now disabled automatically (see ICE-3677). However, it appears that the styling for the disabled buttons (disabled theme style images for the buttons) are not being applied correctly, as the disabled buttons look the same as the enabled ones, expect they have a strange dotted line underneath them.

      When the buttons are disabled they should display a disabled-state image appropriate for the current theme.

        Activity

        Hide
        Ken Fyten added a comment -

        Attached screenshot of "disabled" buttons.

        Show
        Ken Fyten added a comment - Attached screenshot of "disabled" buttons.
        Hide
        Adnan Durrani added a comment -

        The dataPaginator provides facet based navigation. So it can not be supported by the component directly. In order to get it work the application needs to dynamically change the images when on pg. 1 or pg last, etc.

        Show
        Adnan Durrani added a comment - The dataPaginator provides facet based navigation. So it can not be supported by the component directly. In order to get it work the application needs to dynamically change the images when on pg. 1 or pg last, etc.
        Hide
        Mihai Dobrescu added a comment -

        Excuse my ignorance, but I don't understand why the dotted lines appear.
        I intend to use this component in my next project, so I don't appreciate such behavior.

        Show
        Mihai Dobrescu added a comment - Excuse my ignorance, but I don't understand why the dotted lines appear. I intend to use this component in my next project, so I don't appreciate such behavior.
        Hide
        Adnan Durrani added a comment -

        Why the dotted lines appear?
        When the paginator is already on the first page, then there is no benefit clicking on the following buttons:
        -FirstPage
        -FastBackward
        -PreviousPage

        That is why the dataPaginator disables those navigation buttons which doesn't have any effect based on its current page. Internally the commandLink renderer renders the iceCmdLnk-dis class for those links which are disabled. That allows you to visually change the disable buttons. You might you liked the current style which is dotted line but you can always override them. For example you can add the following style class to the application level css file:
        .iceDatPgrScrBtn .iceCmdLnk-dis

        { border:1px solid gray; display:block; }

        or if you don't want to see any difference between enabled and disabled buttons then add the following style class to the application level css file:
        .iceDatPgrScrBtn .iceCmdLnk-dis

        { border-bottom:none; }

        Hope that will help.

        Show
        Adnan Durrani added a comment - Why the dotted lines appear? When the paginator is already on the first page, then there is no benefit clicking on the following buttons: -FirstPage -FastBackward -PreviousPage That is why the dataPaginator disables those navigation buttons which doesn't have any effect based on its current page. Internally the commandLink renderer renders the iceCmdLnk-dis class for those links which are disabled. That allows you to visually change the disable buttons. You might you liked the current style which is dotted line but you can always override them. For example you can add the following style class to the application level css file: .iceDatPgrScrBtn .iceCmdLnk-dis { border:1px solid gray; display:block; } or if you don't want to see any difference between enabled and disabled buttons then add the following style class to the application level css file: .iceDatPgrScrBtn .iceCmdLnk-dis { border-bottom:none; } Hope that will help.

          People

          • Assignee:
            Unassigned
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: