ICEfaces
  1. ICEfaces
  2. ICE-4254

Rendering of Data Paginator instable in 1.8 RC2

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8RC2
    • Fix Version/s: 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      JDK 1.6.0_12, JBoss 4.2.3

      Description

      The Data Paginator buttons are not at the correct places sometimes since 1.8 RC2. This can be seen e.g. in the component showcase, when clicking on Table -> Columns first and on Table -> Data Paginator next.

      This behaviour could not be observed with 1.7.2.

      Is this related to ICE-2515? This bug has newly appeared on 1.8 RC2, however (after 1.7.2 SP1 to be precise).

        Activity

        Thomas Greve created issue -
        Hide
        Thomas Greve added a comment - - edited

        This screenshot shows how the paginator in the component showcase looks like after switching to "Columns" and back.

        Show
        Thomas Greve added a comment - - edited This screenshot shows how the paginator in the component showcase looks like after switching to "Columns" and back.
        Thomas Greve made changes -
        Field Original Value New Value
        Attachment Paginator.jpg [ 11616 ]
        Hide
        Ken Fyten added a comment - - edited

        Cannot reproduce this with any of our test browsers using 1.8.0-RC2.

        Please provide additional information:

        • Operating system/platform + browser and version being used?
        • Exact steps to reproduce the problem
        • Any special conditions required to reproduce the problem (browser window size, theme, etc.).
        Show
        Ken Fyten added a comment - - edited Cannot reproduce this with any of our test browsers using 1.8.0-RC2. Please provide additional information: Operating system/platform + browser and version being used? Exact steps to reproduce the problem Any special conditions required to reproduce the problem (browser window size, theme, etc.).
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 1.8 [ 10161 ]
        Assignee Ken Fyten [ ken.fyten ]
        Hide
        Marcel Groeneweg added a comment - - edited

        I have it too, but I could not get the Component Showcase latest build on icefaces.org to do this.
        But it does happen with my own projects and this definitely started with 1.8.0. RC2.
        It happens when I change the number of rows in the table using the combo box.

        Product Version: NetBeans IDE 6.5 (Build 200811100001)
        Java: 1.6.0_11; Java HotSpot(TM) Client VM 11.0-b16
        System: Windows XP version 5.1 running on x86; Cp1252; nl_NL (nb)
        Userdir: C:\Documents and Settings\Marcel\.netbeans\6.5

        IE7 with all fixes

        GlassFish V2UR2

        Show
        Marcel Groeneweg added a comment - - edited I have it too, but I could not get the Component Showcase latest build on icefaces.org to do this. But it does happen with my own projects and this definitely started with 1.8.0. RC2. It happens when I change the number of rows in the table using the combo box. Product Version: NetBeans IDE 6.5 (Build 200811100001) Java: 1.6.0_11; Java HotSpot(TM) Client VM 11.0-b16 System: Windows XP version 5.1 running on x86; Cp1252; nl_NL (nb) Userdir: C:\Documents and Settings\Marcel\.netbeans\6.5 IE7 with all fixes GlassFish V2UR2
        Marcel Groeneweg made changes -
        Attachment screenshot-1.jpg [ 11621 ]
        Marcel Groeneweg made changes -
        Comment [ The datapaginator is messed up ]
        Hide
        Ken Fyten added a comment -

        Okay, this can be seen using the JSP variant of the component-showcase (/samples/component-showcase/jsp). Note that for some reason the facelet and facelet-enh versions do not have this issue.

        To reproduce, simply view the dataPaginator demo in any browser, click "2" to go to page 2, and the problem appears.

        Show
        Ken Fyten added a comment - Okay, this can be seen using the JSP variant of the component-showcase (/samples/component-showcase/jsp). Note that for some reason the facelet and facelet-enh versions do not have this issue. To reproduce, simply view the dataPaginator demo in any browser, click "2" to go to page 2, and the problem appears.
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P2
        Assignee Ken Fyten [ ken.fyten ] Adnan Durrani [ adnan.durrani ]
        Marcel Groeneweg made changes -
        Attachment testappscreenshot.jpg [ 11622 ]
        Hide
        Marcel Groeneweg added a comment -

        I created a little test project to reproduce the issue, NetBeans project is attached

        Show
        Marcel Groeneweg added a comment - I created a little test project to reproduce the issue, NetBeans project is attached
        Marcel Groeneweg made changes -
        Attachment DataPaginator180RC2.zip [ 11623 ]
        Marcel Groeneweg made changes -
        Comment [ Screenshot of testapp I created for this issue ]
        Hide
        Thomas Greve added a comment -

        Server: JBoss 4.2.3-jdk6 on jdk-1.6.0_12 on Linux / x86-64 (but exhibits this on Windows XP / x86-32 as well)
        Browsers: IE 7 Version 7.0.5730.13, Firefox 3.0.7, both on Windows XP

        To reproduce use the jsp-showcase

        • choose any theme
        • click on Table / Data Paginator (looks fine now)
        • click on Columns
        • go back to Data Paginator

        You then get the presentation shown in the first screenshot.

        Show
        Thomas Greve added a comment - Server: JBoss 4.2.3-jdk6 on jdk-1.6.0_12 on Linux / x86-64 (but exhibits this on Windows XP / x86-32 as well) Browsers: IE 7 Version 7.0.5730.13, Firefox 3.0.7, both on Windows XP To reproduce use the jsp-showcase choose any theme click on Table / Data Paginator (looks fine now) click on Columns go back to Data Paginator You then get the presentation shown in the first screenshot.
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P2 P1
        Assignee Adnan Durrani [ adnan.durrani ] Ted Goddard [ ted.goddard ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18654 Wed Mar 25 14:21:09 MDT 2009 ted.goddard default to DOM error checking for paginator (ICE-4254)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/DOMResponseWriter.java
        Hide
        Ted Goddard added a comment -

        Disabled DOM optimization that revealed this problem. Note that the function of the optimization is to disable error checking on DOM operations, so the component should still be investigated for possible DOM manipulation errors.

        Show
        Ted Goddard added a comment - Disabled DOM optimization that revealed this problem. Note that the function of the optimization is to disable error checking on DOM operations, so the component should still be investigated for possible DOM manipulation errors.
        Ted Goddard made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Marcel Groeneweg added a comment -

        Could a patched jar be made available, like Frank did for ICE-4262?
        This makes it easier to test the change before 1.8.0 final release

        Show
        Marcel Groeneweg added a comment - Could a patched jar be made available, like Frank did for ICE-4262 ? This makes it easier to test the change before 1.8.0 final release
        Hide
        Ted Goddard added a comment - - edited

        Invoke the following static method from your application code to disable the optimization (the checked in change simply turns the optimization off by default):

        DOMResponseWriter.setDOMErrorChecking(true);

        Show
        Ted Goddard added a comment - - edited Invoke the following static method from your application code to disable the optimization (the checked in change simply turns the optimization off by default): DOMResponseWriter.setDOMErrorChecking(true);
        Christophe Taverne made changes -
        Comment [ Hi,

        I tested the last SVN rev: 18662 and I always getting the problem.

        regards,
        ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18664 Thu Mar 26 11:21:49 MDT 2009 ted.goddard retored attach functionality for CommandLinkRenderer (ICE-4254)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/DOMContext.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #18665 Thu Mar 26 11:32:12 MDT 2009 ted.goddard adjusted for modified DOMResponseWriter constructor (ICE-4254)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/DOMContext.java
        Hide
        Marcel Groeneweg added a comment -

        If I understand this correctly, dataPaginator needs further investigation to make it behave nicely.
        Is this planned for 1.8.0 final?

        Show
        Marcel Groeneweg added a comment - If I understand this correctly, dataPaginator needs further investigation to make it behave nicely. Is this planned for 1.8.0 final?
        Hide
        Ted Goddard added a comment -

        The change that was incompatible with the paginator (actually the commandLink used by the paginator) has been reverted, so there should be no revisions to the paginator required for 1.8.0 final. In any case, please test from subversion to verify in your application, or contact product.support@icesoft.com for an interim binary for testing.

        Show
        Ted Goddard added a comment - The change that was incompatible with the paginator (actually the commandLink used by the paginator) has been reverted, so there should be no revisions to the paginator required for 1.8.0 final. In any case, please test from subversion to verify in your application, or contact product.support@icesoft.com for an interim binary for testing.
        Hide
        Christophe Taverne added a comment -

        Hi,

        Last svn rev 18675 perfectly works.

        regards,

        Show
        Christophe Taverne added a comment - Hi, Last svn rev 18675 perfectly works. regards,
        Ken Fyten made changes -
        Assignee Priority P1
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Ted Goddard [ ted.goddard ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Thomas Greve
          • Votes:
            5 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: