Details
Improvement
Description
By default, xerces runs with errorChecking set to true:
(times in nanoseconds, 500 iterations)
errorChecking(true) ice: auctionMonitor
lifecycle took 9709000 RENDER: 8293000
lifecycle took 9981000 RENDER: 8481000
lifecycle took 9542000 RENDER: 8085000
lifecycle took 9827000 RENDER: 8356000
lifecycle took 9794000 RENDER: 8374000
lifecycle took 10348000 RENDER: 8960000
lifecycle took 9782000 RENDER: 8310000
lifecycle took 10174000 RENDER: 8751000
lifecycle took 10328000 RENDER: 8603000
lifecycle took 9965000 RENDER: 8443000
errorChecking(false) ice: auctionMonitor:
lifecycle took 9419000 RENDER: 7985000
lifecycle took 9375000 RENDER: 7998000
lifecycle took 12394000 RENDER: 10994000
lifecycle took 9798000 RENDER: 8356000
lifecycle took 9367000 RENDER: 7978000
lifecycle took 9363000 RENDER: 7843000
lifecycle took 9409000 RENDER: 8021000
lifecycle took 9292000 RENDER: 7936000
lifecycle took 9438000 RENDER: 8047000
lifecycle took 10291000 RENDER: 8296000
5% improvement on the average.
This can be enabled by the following in DOMResponseWriter:
document = DOCUMENT_BUILDER.newDocument();
((com.sun.org.apache.xerces.internal.dom.CoreDocumentImpl) document).setErrorChecking(false);
Perhaps this should be the default, but configurable with a context parameter.
Issue Links
- blocks
-
ICE-4131
MenuPopup no longer work in Showcase
-
- Closed
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
This solution checked in will cause a problem if you're using an JRE other than SUN's and com.sun.org.apache.xerces.internal.dom.CoreDocumentImpl is not in the classpath. The instanceof check does require the class to be on the classpath at runtime. (I got hit with this while trying to deploy the trunk of IceFaces to an IBM JRE on AIX.
document = DOCUMENT_BUILDER.newDocument();
if (!isDOMChecking) {
if (document instanceof com.sun.org.apache.xerces.internal.dom.CoreDocumentImpl) {
((com.sun.org.apache.xerces.internal.dom.CoreDocumentImpl) document).setErrorChecking(false);
}
}
I'm afraid I don't have an elegant solution for this, but the below should work as non-optimal as it is
Class klass = null; try { //really just need to this once in a static block or at initialization klass = Class.forName("com.sun.org.apache.xerces.internal.dom.CoreDocumentImpl"); } catch (ClassNotFoundException e) { //suppress } if (klass != null && klass.isAssignableFrom(document.getClass())) { ((com.sun.org.apache.xerces.internal.dom.CoreDocumentImpl) document).setErrorChecking(false); }
Thanks for noticing this, we'll definitely use a reflection strategy for obtaining the xerces internal API. Does the corresponding API exist (perhaps in a different package) on the AIX JRE?
It would appear the IBM's JRE (my current deployment) is using a pure xerces implementation, so the default document class is
org.apache.xerces.dom.DocumentImpl
which does inherit
org.apache.xerces.dom.CoreDocumentImpl
which also has the setErrorChecking method on it
I don't have access to BEA's JRE, but adding the optimization for pure xerces would probably cover a few bases.
The checked in fix now simply looks for the setErrorChecking method, so it should invoke the method whether the class is xerces or a com.sun implementation.
This optimization is not the default; to enable it:
DOMResponseWriter.setDOMErrorChecking(false);
After 6000 invocations of the test, the performance difference reduced to 7.76ms for the optimization vs 7.86ms without.