ICEfaces
  1. ICEfaces
  2. ICE-3920

Spanish content seen on some components even when English language is selected

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8DR#2
    • Fix Version/s: 1.8RC2, 1.8
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      N/A

      Description

      Some component content is displayed in Spanish even though the language selection is English.
      So far problem seen on Dynamic tabset and Button & Link component.
      Please note that this problem is random and can usually be seen when the component is visited for the first time.

        Activity

        Hide
        David Soul added a comment -

        I have detected with the new <ice:loadBundle even a default language is defined (e.g: spanish) it takes english by default

        Show
        David Soul added a comment - I have detected with the new <ice:loadBundle even a default language is defined (e.g: spanish) it takes english by default
        Hide
        Krashan Brahmanjara added a comment -

        That can depend on browser settings >options>language and order of accepted langages ...but behaviour or IE anf FF is different.

        I can suggest only one - do not use f:loadBundle and jsf 1.1. Use faces-config with jsf 1.2 configuration and language and messageBundle declaration. It works fast and good with Icefaces too.

        My suggestion for Icefaces stuff, remove ice:loadBundle component because is not necessary and it make problems as I said long time age.

        Show
        Krashan Brahmanjara added a comment - That can depend on browser settings >options>language and order of accepted langages ...but behaviour or IE anf FF is different. I can suggest only one - do not use f:loadBundle and jsf 1.1. Use faces-config with jsf 1.2 configuration and language and messageBundle declaration. It works fast and good with Icefaces too. My suggestion for Icefaces stuff, remove ice:loadBundle component because is not necessary and it make problems as I said long time age.
        Hide
        Mandeep Hayher added a comment -

        The problem was seen again on ICEFaces1.8 RC1 build2, jsp version component-showcase while running test scripts on tomcat5 server.

        Following components failed due to content being displayed in spanish instead of english:

        1) Expandable Table
        assertTable iceform:teSub:dataTable.1.1 Actual value 'Presupuesto del Proyecto' did not match 'Project Budget'

        2) Popup Panel
        assertValue iceform:ppSub:modalMessageInput Actual value 'Un mensaje modal.' did not match 'A modal message.'

        Note: The language was never switched from English to Spanish before running these scripts.

        Show
        Mandeep Hayher added a comment - The problem was seen again on ICEFaces1.8 RC1 build2, jsp version component-showcase while running test scripts on tomcat5 server. Following components failed due to content being displayed in spanish instead of english: 1) Expandable Table assertTable iceform:teSub:dataTable.1.1 Actual value 'Presupuesto del Proyecto' did not match 'Project Budget' 2) Popup Panel assertValue iceform:ppSub:modalMessageInput Actual value 'Un mensaje modal.' did not match 'A modal message.' Note: The language was never switched from English to Spanish before running these scripts.
        Hide
        Patrick Corless added a comment -

        I see the locale issue when running the JSP of component showcase. The default language set by the browser seem to be picked up correct (assuming, English, German or Spanish). If a user then tries to change the locale to another supported language nothing seems to happen.

        I've simplified the LocaleBean.java in -r18315 as part of a change for ICE-3993. I suspect there are larger problem with the setting the view root locale in the jsp view handler.

        Show
        Patrick Corless added a comment - I see the locale issue when running the JSP of component showcase. The default language set by the browser seem to be picked up correct (assuming, English, German or Spanish). If a user then tries to change the locale to another supported language nothing seems to happen. I've simplified the LocaleBean.java in -r18315 as part of a change for ICE-3993 . I suspect there are larger problem with the setting the view root locale in the jsp view handler.
        Hide
        Mark Collette added a comment -

        Investigation of the JSP component-showcase found:

        Calendar : Weekends have dark gray backgrounds / August days are bold
        Calendar : Select Pattern
        Charts : The chart types
        Charts : All the text in the actual chart graphic
        Connection Status : Should we translate Royale and Rime? They're proper names
        Download Resources : All the labels on the left
        Effects : The Effect names stick to the first, because we're not using the ice:loadBundle
        File Upload : The buttons
        GMap : The Map / Satellite / Hybrid labels stick to the first
        Menu Bar : The menu items and the horizontal / vertical
        Progress : The layout isn't quite right with the longer Spanish labels
        Rich Text : Seems to mess up in Spanish, after pressing the save button
        Tree : The tree nodes for Employees / Central / Eastern
        Table Columns : "A to D"
        Row Selector : Single / Multiple / Enhanced Multiple
        Data Exporter : The label in the tree
        Panel Border : North / South / East / West / Center (the checkboxes are translated)
        Split Pane : Hotizontal / Vertical
        Dynamic panelTabSet : Tab labels sticking
        Popup Panel : Values in input fields stick

        Show
        Mark Collette added a comment - Investigation of the JSP component-showcase found: Calendar : Weekends have dark gray backgrounds / August days are bold Calendar : Select Pattern Charts : The chart types Charts : All the text in the actual chart graphic Connection Status : Should we translate Royale and Rime? They're proper names Download Resources : All the labels on the left Effects : The Effect names stick to the first, because we're not using the ice:loadBundle File Upload : The buttons GMap : The Map / Satellite / Hybrid labels stick to the first Menu Bar : The menu items and the horizontal / vertical Progress : The layout isn't quite right with the longer Spanish labels Rich Text : Seems to mess up in Spanish, after pressing the save button Tree : The tree nodes for Employees / Central / Eastern Table Columns : "A to D" Row Selector : Single / Multiple / Enhanced Multiple Data Exporter : The label in the tree Panel Border : North / South / East / West / Center (the checkboxes are translated) Split Pane : Hotizontal / Vertical Dynamic panelTabSet : Tab labels sticking Popup Panel : Values in input fields stick
        Hide
        Mark Collette added a comment -

        Most of these are just application issues, but the ones that seem to involve components are GMap and Rich Text.

        Show
        Mark Collette added a comment - Most of these are just application issues, but the ones that seem to involve components are GMap and Rich Text.
        Hide
        Mark Collette added a comment -

        Fixed the "sticking" issues, where things that were supposedly localised were not changing between the languages, though they would show in the initial language.

        Subversion 18408
        icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\util\MessageBundleLoader.java
        icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\buttonsAndLinks\ButtonsAndLinksBean.java
        icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\effects\EffectsModel.java
        icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\selection\SelectionTagsBean.java
        icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\setEventPhase\SetEventPhaseBean.java
        icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\layoutPanel\panelTabset\DynamicTabSetBean.java
        icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\layoutPanel\panelToolTip\PanelToolTipController.java
        icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\resources\messages_es.properties
        icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\custom\setEventPhase.jspx
        icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\panel\panelTooltip.jspx
        icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\standard\selectionTags.jspx

        Show
        Mark Collette added a comment - Fixed the "sticking" issues, where things that were supposedly localised were not changing between the languages, though they would show in the initial language. Subversion 18408 icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\util\MessageBundleLoader.java icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\buttonsAndLinks\ButtonsAndLinksBean.java icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\effects\EffectsModel.java icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\selection\SelectionTagsBean.java icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\setEventPhase\SetEventPhaseBean.java icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\layoutPanel\panelTabset\DynamicTabSetBean.java icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\layoutPanel\panelToolTip\PanelToolTipController.java icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\resources\messages_es.properties icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\custom\setEventPhase.jspx icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\panel\panelTooltip.jspx icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\standard\selectionTags.jspx
        Hide
        Mark Collette added a comment -

        The translated toolbar modes were being sent to the FCKEditor, when the enumerated value strings should have instead, causing the editor to fail when using a language other than English.

        Subversion 18417
        icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\inputRichText\InputRichTextBean.java
        icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\custom\inputRichText.jspx

        Show
        Mark Collette added a comment - The translated toolbar modes were being sent to the FCKEditor, when the enumerated value strings should have instead, causing the editor to fail when using a language other than English. Subversion 18417 icefaces\samples\component-showcase\common-src\org\icefaces\application\showcase\view\bean\examples\component\inputRichText\InputRichTextBean.java icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\custom\inputRichText.jspx
        Hide
        Mark Collette added a comment -

        I've moved the simple translation omissions into ICE-4132, and am closing this bug, which is for bugs in the component-showcase application.

        Show
        Mark Collette added a comment - I've moved the simple translation omissions into ICE-4132 , and am closing this bug, which is for bugs in the component-showcase application.

          People

          • Assignee:
            Unassigned
            Reporter:
            Mandeep Hayher
          • Votes:
            2 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: