[ICE-3808] RuntimeException "Cannot determine if user in role" during file upload - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.8DR#1
Fix Version/s: 1.8
Component/s: Framework
Labels:
None
Environment:
Tomcat or JBoss with JAAS authentication

ICEsoft Forum Reference:
http://www.icefaces.org/JForum/posts/list/7507.page#34210

Description

Steps to reproduce the RuntimeException :

1. Create a JSF page holding a "ice:inputFile" component. This page must be protected by HTTP authentication (in web.xml). Only users with role "foo" may access it.

<security-constraint>
        <web-resource-collection>
            <web-resource-name>Admin Constraints</web-resource-name>
            <url-pattern>/app/*</url-pattern>
            <http-method>GET</http-method>
            <http-method>POST</http-method>
        </web-resource-collection>

        <auth-constraint>
            <role-name>foo</role-name>
        </auth-constraint>
    </security-constraint>

    <login-config>
        <auth-method>FORM</auth-method>
        <realm-name>viperats-admin</realm-name>

        <form-login-config>
            <form-login-page>/login.jsp</form-login-page>
            <form-error-page>/loginerr.jsp</form-error-page>
        </form-login-config>
    </login-config>

<security-role>
        <role-name>foo</role-name>
    </security-role>

2. Create a menu page with a "ice:menuItem" element. IMPORTANT: The menuitem must contain an "enabledOnUserRole='foo'" attribute.
    Without enabledOnUserRole or without authentication the issue does not appear.

<ice:menuItem id="License"
                        enabledOnUserRole="foo"
                        renderedOnUserRole="foo"
                        value="License"
                        action="menuLicense" />

3. Open the menu page, click on the menu link to get to the file upload page. Log in with a user which has role "foo". Perform a file upload and the Servlet container will
    log a stack trace like the one below to stderr. Progress bar will not be updated.

This issue has been there since ICEfaces 1.7.0 and was confirmed to be still there also in 1.8DR1

Caused by: java.lang.RuntimeException: Cannot determine if user in role. User information is not available.
at com.icesoft.faces.context.BridgeExternalContext$4.isUserInRole(BridgeExternalContext.java:138)
at com.icesoft.faces.webapp.http.servlet.ServletEnvironmentRequest.isUserInRole(ServletEnvironmentRequest.java:207)
at com.icesoft.faces.webapp.http.servlet.ServletExternalContext.isUserInRole(ServletExternalContext.java:243)
at com.icesoft.faces.component.ext.taglib.Util.isRenderedOnUserRole(Util.java:111)
at com.icesoft.faces.component.menubar.MenuItem.isRendered(MenuItem.java:402)
at com.icesoft.faces.component.menubar.MenuItemRenderer.renderSubMenuItem(MenuItemRenderer.java:549)
at com.icesoft.faces.component.menubar.MenuItemRenderer.renderChildrenRecursive(MenuItemRenderer.java:448)
at com.icesoft.faces.component.menubar.MenuItemRenderer.encodeBegin(MenuItemRenderer.java:230)
at javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:788)
at com.icesoft.faces.renderkit.dom_html_basic.DomBasicRenderer.encodeParentAndChildren(DomBasicRenderer.java:350)
at com.icesoft.faces.component.menubar.MenuBarRenderer.encodeChildren(MenuBarRenderer.java:117)
at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:812)
at com.icesoft.faces.renderkit.dom_html_basic.DomBasicRenderer.encodeParentAndChildren(DomBasicRenderer.java:352)
at com.icesoft.faces.renderkit.dom_html_basic.GridRenderer.encodeChildren(GridRenderer.java:203)
at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:812)
at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:571)
at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:575)
at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:575)
at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:575)
at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:575)
at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:575)
at com.icesoft.faces.facelets.D2DFaceletViewHandler.renderResponse(D2DFaceletViewHandler.java:282)

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
ice-bug.war

26/Aug/09 11:55 PM

5.81 MB

Mark Collette
META-INF/MANIFEST.MF 0.1 kB

WEB-INF/classes/roles.properties 0.0 kB

WEB-INF/classes/test/UploadBean.class 2 kB

WEB-INF/classes/users.properties 0.0 kB

WEB-INF/faces-config.xml 0.6 kB

WEB-INF/jboss-web.xml 0.4 kB

WEB-INF/web.xml 5 kB

index.jsp 0.3 kB

layout.jspx 2 kB

login.jspx 1 kB

menuheader.jspx 1.0 kB

pages/main.jspx 0.8 kB

pages/menu.jspx 0.5 kB

pages/t_main.jspx 1 kB

WEB-INF/lib/icefaces.jar 1.17 MB

WEB-INF/lib/icefaces-comps.jar 2.01 MB

WEB-INF/lib/icefaces-facelets.jar 597 kB

WEB-INF/classes/test/UploadBean$1.class 1 kB

WEB-INF/lib/backport-util-concurrent.jar 319 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-discovery.jar 75 kB

WEB-INF/lib/commons-el.jar 110 kB

WEB-INF/lib/commons-fileupload.jar 56 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/FastInfoset.jar 285 kB

WEB-INF/lib/jxl.jar 708 kB

WEB-INF/.../krysalis-jCharts-1.0.0-alpha-1.jar 151 kB

WEB-INF/classes/test/UploadBean.java 2 kB

Download Zip
Show

ice-bug.war

26/Aug/09 11:55 PM

5.81 MB

Mark Collette

Issue Links

blocks

ICE-5129 ice:inputFile not working if JSF page is protected by JAAS authentication

Closed

depends on

ICE-3707 Add support for JAAS security

Closed

is duplicated by

ICE-3900 Cannot determine if user in role - using inputFile, menuItem, panelGroup with renderedOnUserRole

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Golgoth added a comment - 03/Mar/09 8:05 AM

I've the same exception on a facelet app with Icefaces 1.7.2-SP1.
No authentication need to see the page but it contains a form with render restriction :
<ice:form id="HeaderMenu" renderedOnUserRole="#

{appBean.administratorRole}

{appBean.providerRole}

">...

INFO: 2009-03-03 15:00:38,149 [Render Thread - 5] ERROR com.icesoft.faces.facelets.D2DFaceletViewHandler - Problem in renderResponse: Cannot determine if user in role. User information is not available.
java.lang.RuntimeException: Cannot determine if user in role. User information is not available.
at com.icesoft.faces.context.BridgeExternalContext$4.isUserInRole(BridgeExternalContext.java:146)
at com.icesoft.faces.webapp.http.servlet.ServletEnvironmentRequest.isUserInRole(ServletEnvironmentRequest.java:207)
at com.icesoft.faces.webapp.http.servlet.ServletExternalContext.isUserInRole(ServletExternalContext.java:243)
at com.icesoft.faces.component.ext.taglib.Util.isRenderedOnUserRole(Util.java:111)
at com.icesoft.faces.component.ext.HtmlForm.isRendered(HtmlForm.java:125)
at com.icesoft.faces.renderkit.dom_html_basic.GroupRenderer.encodeChildren(GroupRenderer.java:91)
at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:837)
at com.icesoft.faces.renderkit.dom_html_basic.DomBasicRenderer.encodeParentAndChildren(DomBasicRenderer.java:352)
at com.icesoft.faces.renderkit.dom_html_basic.GroupRenderer.encodeChildren(GroupRenderer.java:92)
at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:837)
at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:571)
at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:575)
at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:575)
at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:575)
at com.icesoft.faces.facelets.D2DFaceletViewHandler.renderResponse(D2DFaceletViewHandler.java:282)
at com.icesoft.faces.application.D2DViewHandler.renderView(D2DViewHandler.java:159)
at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:110)
at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:100)
at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139)
at com.icesoft.faces.webapp.xmlhttp.PersistentFacesState.render(PersistentFacesState.java:169)
at com.icesoft.faces.webapp.xmlhttp.PersistentFacesState.executeAndRender(PersistentFacesState.java:256)
at com.icesoft.faces.async.render.RunnableRender.run(RunnableRender.java:143)
at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:665)
at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:690)
at java.lang.Thread.run(Thread.java:613)

SEVERE: JSF1054: (Phase ID: RENDER_RESPONSE 6, View ID: /main.jspx) Exception thrown during phase execution: javax.faces.event.PhaseEvent[source=com.sun.faces.lifecycle.LifecycleImpl@28c113]

Show

Golgoth added a comment - 03/Mar/09 8:05 AM I've the same exception on a facelet app with Icefaces 1.7.2-SP1. No authentication need to see the page but it contains a form with render restriction : <ice:form id="HeaderMenu" renderedOnUserRole="# {appBean.administratorRole} ,# {appBean.providerRole} ">... INFO: 2009-03-03 15:00:38,149 [Render Thread - 5] ERROR com.icesoft.faces.facelets.D2DFaceletViewHandler - Problem in renderResponse: Cannot determine if user in role. User information is not available. java.lang.RuntimeException: Cannot determine if user in role. User information is not available. at com.icesoft.faces.context.BridgeExternalContext$4.isUserInRole(BridgeExternalContext.java:146) at com.icesoft.faces.webapp.http.servlet.ServletEnvironmentRequest.isUserInRole(ServletEnvironmentRequest.java:207) at com.icesoft.faces.webapp.http.servlet.ServletExternalContext.isUserInRole(ServletExternalContext.java:243) at com.icesoft.faces.component.ext.taglib.Util.isRenderedOnUserRole(Util.java:111) at com.icesoft.faces.component.ext.HtmlForm.isRendered(HtmlForm.java:125) at com.icesoft.faces.renderkit.dom_html_basic.GroupRenderer.encodeChildren(GroupRenderer.java:91) at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:837) at com.icesoft.faces.renderkit.dom_html_basic.DomBasicRenderer.encodeParentAndChildren(DomBasicRenderer.java:352) at com.icesoft.faces.renderkit.dom_html_basic.GroupRenderer.encodeChildren(GroupRenderer.java:92) at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:837) at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:571) at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:575) at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:575) at com.icesoft.faces.application.D2DViewHandler.renderResponse(D2DViewHandler.java:575) at com.icesoft.faces.facelets.D2DFaceletViewHandler.renderResponse(D2DFaceletViewHandler.java:282) at com.icesoft.faces.application.D2DViewHandler.renderView(D2DViewHandler.java:159) at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:110) at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:100) at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139) at com.icesoft.faces.webapp.xmlhttp.PersistentFacesState.render(PersistentFacesState.java:169) at com.icesoft.faces.webapp.xmlhttp.PersistentFacesState.executeAndRender(PersistentFacesState.java:256) at com.icesoft.faces.async.render.RunnableRender.run(RunnableRender.java:143) at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:665) at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:690) at java.lang.Thread.run(Thread.java:613) SEVERE: JSF1054: (Phase ID: RENDER_RESPONSE 6, View ID: /main.jspx) Exception thrown during phase execution: javax.faces.event.PhaseEvent [source=com.sun.faces.lifecycle.LifecycleImpl@28c113]

5 older comments

Hide

Permalink

Mark Collette added a comment - 27/Aug/09 12:04 AM

On the main page that comes up, after you log in, there's a Commence button that will do 10 server pushes, 2 seconds apart, updating the same progress bar that the file upload uses. This will allow us to test any differences between regular server pushes and file upload server pushes.

What I've found is that upon doing an action that should result in a server push, the browser receives a receive-updated-views message that references the current view. But, either the browser javascript does not act on this, or it does, but the server quietly discards the request for any updates. I think a phase listener should be installed to confirm that JSF lifecycles are happening to bring about the receive-updated-views. Then, debug should be added to the servlet to see if the browser is in fact contacting it for the updates. Maybe port listening software should be used, since I'm not sure the Firebug can differentiate between no server connection having been made, and one that has been made, but hasn't received a response.

Server push, one of these every 2 seconds

http://localhost:8080/ice-bug/block/receive-updated-views
<updated-views>d9dGRkj2QEM5ZGqPWqwe7A:1 </updated-views>

File upload, only after done (no progress)

http://localhost:8080/ice-bug/block/receive-updated-views
<updated-views>d9dGRkj2QEM5ZGqPWqwe7A:1 </updated-views>

I was in the process of commenting out all of the JAAS references in the configuration xml files, so that I could verify that the application itself is not causing this problem. I believe I've commented everything out, so the next step would be to completely remove the jboss-web.xml file, since maybe its presence alone is causing problems.

Show

Mark Collette added a comment - 27/Aug/09 12:04 AM On the main page that comes up, after you log in, there's a Commence button that will do 10 server pushes, 2 seconds apart, updating the same progress bar that the file upload uses. This will allow us to test any differences between regular server pushes and file upload server pushes. What I've found is that upon doing an action that should result in a server push, the browser receives a receive-updated-views message that references the current view. But, either the browser javascript does not act on this, or it does, but the server quietly discards the request for any updates. I think a phase listener should be installed to confirm that JSF lifecycles are happening to bring about the receive-updated-views. Then, debug should be added to the servlet to see if the browser is in fact contacting it for the updates. Maybe port listening software should be used, since I'm not sure the Firebug can differentiate between no server connection having been made, and one that has been made, but hasn't received a response. Server push, one of these every 2 seconds http://localhost:8080/ice-bug/block/receive-updated-views <updated-views>d9dGRkj2QEM5ZGqPWqwe7A:1 </updated-views> File upload, only after done (no progress) http://localhost:8080/ice-bug/block/receive-updated-views <updated-views>d9dGRkj2QEM5ZGqPWqwe7A:1 </updated-views> I was in the process of commenting out all of the JAAS references in the configuration xml files, so that I could verify that the application itself is not causing this problem. I believe I've commented everything out, so the next step would be to completely remove the jboss-web.xml file, since maybe its presence alone is causing problems.

Hide

Permalink

Deryk Sinotte added a comment - 10/Sep/09 12:08 PM

Linking to ~~ICE-3707~~ as work was done to support JAAS as part of the 1.8 DR2 release. The original test case that is attached to ~~ICE-3900~~ and some of the other comments indicate that there were issues up to and including 1.8 DR1.

I ran the case included in ~~ICE-3900~~ and was able to see the problem. That .war file comes with the ICEfaces 1.7.2-SP1 jars. When I upgraded to 1.8.0 (the final release), 1.8.1, or the latest trunk, the problem was no longer present.

I also took the regression test we have for ~~ICE-3707~~ and ran it against both Tomcat and JBoss with JAAS configured. It includes menus, buttons, and file upload components that are protected with different levels of roles. It also runs with Ajax Push and I did not see the exception at all.

Show

Deryk Sinotte added a comment - 10/Sep/09 12:08 PM Linking to ICE-3707 as work was done to support JAAS as part of the 1.8 DR2 release. The original test case that is attached to ICE-3900 and some of the other comments indicate that there were issues up to and including 1.8 DR1. I ran the case included in ICE-3900 and was able to see the problem. That .war file comes with the ICEfaces 1.7.2-SP1 jars. When I upgraded to 1.8.0 (the final release), 1.8.1, or the latest trunk, the problem was no longer present. I also took the regression test we have for ICE-3707 and ran it against both Tomcat and JBoss with JAAS configured. It includes menus, buttons, and file upload components that are protected with different levels of roles. It also runs with Ajax Push and I did not see the exception at all.

Hide

Permalink

Deryk Sinotte added a comment - 10/Sep/09 12:27 PM

Marking as fixed in 1.8.0 (as per ~~ICE-3707~~). Testing of the original case in ~~ICE-3900~~ shows the problem is there in 1.7.2 SP1 but is not there in 1.8+ releases. If there is a different issue related to this case, we'll open a separate JIRA.

Show

Deryk Sinotte added a comment - 10/Sep/09 12:27 PM Marking as fixed in 1.8.0 (as per ICE-3707 ). Testing of the original case in ICE-3900 shows the problem is there in 1.7.2 SP1 but is not there in 1.8+ releases. If there is a different issue related to this case, we'll open a separate JIRA.

Hide

Permalink

Deryk Sinotte added a comment - 10/Sep/09 12:29 PM

Resolving as fixed.

Show

Deryk Sinotte added a comment - 10/Sep/09 12:29 PM Resolving as fixed.

Hide

Permalink

Silvano Maffeis added a comment - 12/Nov/09 3:11 AM

I tested ICEfaces 1.8.2 but file upload doesn't work if the JSF page holding the ice:inputFile
component is protected by JAAS authentication. The moment I press the upload button, the logged user
loses his authentication roles, and the InputFileController uploadFile method is never called.

Show

Silvano Maffeis added a comment - 12/Nov/09 3:11 AM I tested ICEfaces 1.8.2 but file upload doesn't work if the JSF page holding the ice:inputFile component is protected by JAAS authentication. The moment I press the upload button, the logged user loses his authentication roles, and the InputFileController uploadFile method is never called.

People

Assignee:

Deryk Sinotte

Reporter:

Silvano Maffeis

Votes:

3 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

24/Nov/08 9:22 AM

Updated:

07/Jan/10 12:07 PM

Resolved:

10/Sep/09 12:29 PM