[ICE-3680] outputResource label attribute throws EL exception when value bound - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.7.2
Fix Version/s: 1.8RC1, 1.8
Component/s: ICE-Components
Labels:
None
Environment:
All

Workaround Exists:

Yes
Workaround Description:
Hardcode label attribute.

Description

Note from customer:

More issues with outputResource...

This works...

     <ice:outputResource
       resource="#{hc1099rep2008Pdf.resourceMap[hc1099]}" mimeType="application/pdf"
       fileName="#{msg.searchResults_link_view}"
       value="view"
       type="button"
       attachment="false"/>

Also This works..

      <ice:outputResource
       resource="#{hc1099rep2008Pdf.resourceMap[hc1099]}" mimeType="application/pdf"
       fileName="#{msg.searchResults_link_view}"
       label="view"
       value="view"
       attachment="false"/>

This doesn't

      <ice:outputResource
       resource="#{hc1099rep2008Pdf.resourceMap[hc1099]}" mimeType="application/pdf"
       fileName="#{msg.searchResults_link_view}"
       label="#{msg.searchResults_link_view}"
       value="view"
       attachment="false"/>

Note the value binding for label instead of it hard coded that appears to cause problem. hard coding works.....

I get following error

java.lang.NullPointerException
at com.sun.facelets.el.ELAdaptor.getELContext(ELAdaptor.java:47)
at com.sun.facelets.el.LegacyValueBinding.getValue(LegacyValueBinding.java:54)
at com.icesoft.faces.component.outputresource.OutputResource.getLabel(OutputResource.java:189)
at com.icesoft.faces.component.outputresource.OutputResource$1.withOptions(OutputResource.java:89)
at com.icesoft.faces.webapp.http.core.ResourceDispatcher$ResourceServer.respond(ResourceDispatcher.java:100)
at com.icesoft.faces.webapp.http.common.standard.CompressingServer$CompressingRequest$1.respond(CompressingServer.java:65)
at com.icesoft.faces.webapp.http.servlet.ServletRequestResponse.respondWith(ServletRequestResponse.java:167)
at com.icesoft.faces.webapp.http.servlet.ThreadBlockingAdaptingServlet$ThreadBlockingRequestResponse.respondWith(ThreadBlockingAdaptingServlet.java:36)
at com.icesoft.faces.webapp.http.common.standard.CompressingServer$CompressingRequest.respondWith(CompressingServer.java:61)
at com.icesoft.faces.webapp.http.core.ResourceDispatcher$ResourceServer.service(ResourceDispatcher.java:94)
at com.icesoft.faces.webapp.http.common.standard.PathDispatcherServer.service(PathDispatcherServer.java:24)
at com.icesoft.faces.webapp.http.common.standard.CompressingServer.service(CompressingServer.java:44)
at com.icesoft.faces.webapp.http.core.ResourceDispatcher.service(ResourceDispatcher.java:41)
at com.icesoft.faces.webapp.http.common.standard.PathDispatcherServer.service(PathDispatcherServer.java:24)
at com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet.service(MainSessionBoundServlet.java:160)

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
support5311.war

13/Nov/08 10:06 PM

5.06 MB

Sam Xiao
META-INF/MANIFEST.MF 0.0 kB

WEB-INF/lib/backport-util-concurrent.jar 319 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/icefaces-comps.jar 1.71 MB

main.jspx 1 kB

WEB-INF/.../TestBean$ResourceEntry.class 3 kB

WEB-INF/lib/jsf-impl-1.2.jar 813 kB

WEB-INF/lib/commons-el.jar 110 kB

WEB-INF/lib/commons-discovery.jar 70 kB

WEB-INF/lib/jsf-api-1.2.jar 353 kB

WEB-INF/lib/commons-beanutils.jar 184 kB

WEB-INF/lib/jstl.jar 17 kB

WEB-INF/classes/support/TestBean.class 2 kB

WEB-INF/faces-config.xml 0.4 kB

WEB-INF/classes/support/logo.jpg 2 kB

WEB-INF/lib/commons-fileupload.jar 87 kB

index.jsp 0.2 kB

WEB-INF/.../WP_Security_Whitepaper.pdf 209 kB

WEB-INF/lib/icefaces.jar 988 kB

WEB-INF/web.xml 4 kB

WEB-INF/classes/support/TestBean.java 3 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/commons-collections.jar 558 kB

Download Zip
Show

support5311.war

13/Nov/08 10:06 PM

5.06 MB

Sam Xiao

Activity

Ascending order - Click to sort in descending order

Tyler Johnson created issue - 24/Oct/08 3:44 PM

Tyler Johnson made changes - 24/Oct/08 3:44 PM

Field	Original Value	New Value
Assignee		Adnan Durrani [ adnan.durrani ]

Ken Fyten made changes - 24/Oct/08 4:59 PM

Fix Version/s

1.8DR#3 [ 10143 ]

Adnan Durrani made changes - 27/Oct/08 11:36 AM

Status

Open [ 1 ]

In Progress [ 3 ]

Hide

Permalink

Adnan Durrani added a comment - 27/Oct/08 1:06 PM

I have tested the following snippet, and it works fine. Can you please attach a test case which demonstrate the problem.

<ice:dataTable border="1" var="item" value="#

{myBean.dataList}

">
<ice:column>
<f:facet name="header">
<ice:outputText value="Resource" />
</f:facet>
<ice:outputResource shared="false" fileName="#

{item.fileName}"
resource="#{item.fileResource}" label="#{item.fileName}

" />
</ice:column>
</ice:dataTable>

Show

Adnan Durrani added a comment - 27/Oct/08 1:06 PM I have tested the following snippet, and it works fine. Can you please attach a test case which demonstrate the problem. <ice:dataTable border="1" var="item" value="# {myBean.dataList} "> <ice:column> <f:facet name="header"> <ice:outputText value="Resource" /> </f:facet> <ice:outputResource shared="false" fileName="# {item.fileName}" resource="#{item.fileResource}" label="#{item.fileName} " /> </ice:column> </ice:dataTable>

Hide

Permalink

Sam Xiao added a comment - 13/Nov/08 9:59 PM

Same exception is throws when using EL expression for mimeType attribute

Show

Sam Xiao added a comment - 13/Nov/08 9:59 PM Same exception is throws when using EL expression for mimeType attribute

Hide

Permalink

Sam Xiao added a comment - 13/Nov/08 10:06 PM

test app. for "mimeType" should be easily changed to test other attributes

Show

Sam Xiao added a comment - 13/Nov/08 10:06 PM test app. for "mimeType" should be easily changed to test other attributes

Sam Xiao made changes - 13/Nov/08 10:06 PM

Attachment

support5311.war [ 11338 ]

Ken Fyten made changes - 18/Dec/08 7:12 PM

Salesforce Case		[]
Assignee Priority		P1

Ken Fyten made changes - 18/Dec/08 7:12 PM

Salesforce Case		[]
Assignee	Adnan Durrani [ adnan.durrani ]	Yip Ng [ yip.ng ]

Hide

Permalink

yip.ng added a comment - 29/Dec/08 5:48 PM

The value binding works when the link is being rendered, but doesn't work when the rendered link is clicked to download the resource. It seems that when the link is clicked and the resource is served, something has gone wrong with the JSF lifecycle and FacesContext has become null.

Show

yip.ng added a comment - 29/Dec/08 5:48 PM The value binding works when the link is being rendered, but doesn't work when the rendered link is clicked to download the resource. It seems that when the link is clicked and the resource is served, something has gone wrong with the JSF lifecycle and FacesContext has become null.

Sam Xiao made changes - 02/Jan/09 4:09 PM

Salesforce Case

[50070000007C5ah]

Hide

Permalink

yip.ng added a comment - 06/Jan/09 5:07 PM

See also Adnan's comments in ~~ICE-3686~~.

Show

yip.ng added a comment - 06/Jan/09 5:07 PM See also Adnan's comments in ICE-3686 .

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#18162	Thu Jan 08 17:03:30 MST 2009	yip.ng	~~ICE-3680~~ Changed anonymous resource class to a named class to prevent value binding exceptions and memory leaks.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputresource/OutputResource.java

yip.ng made changes - 08/Jan/09 7:10 PM

Status	In Progress [ 3 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Ken Fyten added a comment - 09/Jan/09 12:01 PM

Let's see if we can have the component use the Resource's options if specified. They can be augmented by the component options but the Resource's options should take precedence.

If this isn't readily feasible then we at least need to document the policy in the TLD for the component (in any case the TLD needs to clearly state the policy towards the options behavior).

Show

Ken Fyten added a comment - 09/Jan/09 12:01 PM Let's see if we can have the component use the Resource's options if specified. They can be augmented by the component options but the Resource's options should take precedence. If this isn't readily feasible then we at least need to document the policy in the TLD for the component (in any case the TLD needs to clearly state the policy towards the options behavior).

Ken Fyten made changes - 09/Jan/09 12:01 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#18166	Mon Jan 12 15:38:01 MST 2009	yip.ng	~~ICE-3680~~ Changed to allow the user resource to override some tag attributes using the withOptions() method.
				Files Changed
				MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputresource/OutputResource.java MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-outputresource-props.xml

yip.ng made changes - 12/Jan/09 5:44 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 31/Mar/09 11:57 PM

Fix Version/s		1.8 [ 10161 ]
Assignee Priority	P1

Ken Fyten made changes - 10/Apr/09 11:27 AM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee	Yip Ng [ yip.ng ]

People

Assignee:

Unassigned

Reporter:

Tyler Johnson

Votes:

2 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

24/Oct/08 3:44 PM

Updated:

10/Apr/09 11:27 AM

Resolved:

12/Jan/09 5:44 PM