ICEfaces
  1. ICEfaces
  2. ICE-3574

support for BlackBerry browsers

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8DR#1
    • Fix Version/s: 1.8DR#2, 1.8
    • Component/s: Bridge
    • Labels:
      None
    • Environment:
      BlackBerry Bold

      Description

      Many people are interested in using ICEfaces applications from their BlackBerry devices. The BlackBerry browser is now capable of Ajax functionality, so it should be supported.

        Activity

        Ted Goddard created issue -
        Hide
        Ted Goddard added a comment -

        The following code in submit.js does not finish executing on the BlackBerry:

        in iceSubmitPartial:

        /*
        if (Ice.InputFileIdPreUpload)
        query.add('ice.inputFile.preUpload', Ice.InputFileIdPreUpload);
        if (Ice.InputFileIdPostUpload)
        query.add('ice.inputFile.postUpload', Ice.InputFileIdPostUpload);
        if (Ice.Menu.menuContext != null)
        query.add('ice.menuContext', Ice.Menu.menuContext);
        if(Ice.FCKeditorUtility)
        Ice.FCKeditorUtility.saveAll();
        */

        in iceSubmit:

        /*
        if (Ice.InputFileIdPreUpload)
        query.add('ice.inputFile.preUpload', Ice.InputFileIdPreUpload);
        if (Ice.InputFileIdPostUpload)
        query.add('ice.inputFile.postUpload', Ice.InputFileIdPostUpload);
        if (Ice.Menu.menuContext != null)
        query.add('ice.menuContext', Ice.Menu.menuContext);
        if(Ice.FCKeditorUtility)
        Ice.FCKeditorUtility.saveAll();
        */

        This is puzzling because commenting out the FCKeditorUtility clause is not sufficient. The other clauses appear to do nothing more than add a parameter to the query object.

        Show
        Ted Goddard added a comment - The following code in submit.js does not finish executing on the BlackBerry: in iceSubmitPartial: /* if (Ice.InputFileIdPreUpload) query.add('ice.inputFile.preUpload', Ice.InputFileIdPreUpload); if (Ice.InputFileIdPostUpload) query.add('ice.inputFile.postUpload', Ice.InputFileIdPostUpload); if (Ice.Menu.menuContext != null) query.add('ice.menuContext', Ice.Menu.menuContext); if(Ice.FCKeditorUtility) Ice.FCKeditorUtility.saveAll(); */ in iceSubmit: /* if (Ice.InputFileIdPreUpload) query.add('ice.inputFile.preUpload', Ice.InputFileIdPreUpload); if (Ice.InputFileIdPostUpload) query.add('ice.inputFile.postUpload', Ice.InputFileIdPostUpload); if (Ice.Menu.menuContext != null) query.add('ice.menuContext', Ice.Menu.menuContext); if(Ice.FCKeditorUtility) Ice.FCKeditorUtility.saveAll(); */ This is puzzling because commenting out the FCKeditorUtility clause is not sufficient. The other clauses appear to do nothing more than add a parameter to the query object.
        Hide
        Ted Goddard added a comment -

        Any ideas on why the commented-out code might fail on the BlackBerry? If we need to special-case this, how should that be done?

        Show
        Ted Goddard added a comment - Any ideas on why the commented-out code might fail on the BlackBerry? If we need to special-case this, how should that be done?
        Ted Goddard made changes -
        Field Original Value New Value
        Assignee Mircea Toma [ mircea.toma ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17867 Wed Nov 05 08:53:23 MST 2008 ted.goddard event and Ice.Menu fix for BlackBerry browser (ICE-3574)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/event.js
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/src/submit.js
        Hide
        Ted Goddard added a comment -

        This appears to be caused by Ice.Menu being null, so Ice.Menu.menuContext throws an exception.

        Show
        Ted Goddard added a comment - This appears to be caused by Ice.Menu being null, so Ice.Menu.menuContext throws an exception.
        Hide
        Ted Goddard added a comment -

        Basic fixes are in scope for 1.8DR#2.

        Show
        Ted Goddard added a comment - Basic fixes are in scope for 1.8DR#2.
        Ted Goddard made changes -
        Fix Version/s 1.8DR#2 [ 10142 ]
        Affects Version/s 1.8DR#1 [ 10141 ]
        Affects Version/s 1.7.1 [ 10122 ]
        Hide
        Ted Goddard added a comment -

        Analysis of the commandLink incompatibility with the BlackBerry browser:

        Event has the properties:
        target - the original target of the event
        currentTarget - the target for whom we're currently processing event listeners for

        BlackBerry browser processes target as a node, the target ends up being the "TextNode"
        (which has no id attribute) and the currentTarget is the link element.

        The following code works fine in all browsers:

        <a id="success" href="http://www.icefaces.org"
        onclick="alert(event.currentTarget.id);return false;" >Link ID Test</a>

        Show
        Ted Goddard added a comment - Analysis of the commandLink incompatibility with the BlackBerry browser: Event has the properties: target - the original target of the event currentTarget - the target for whom we're currently processing event listeners for BlackBerry browser processes target as a node, the target ends up being the "TextNode" (which has no id attribute) and the currentTarget is the link element. The following code works fine in all browsers: <a id="success" href="http://www.icefaces.org" onclick="alert(event.currentTarget.id);return false;" >Link ID Test</a>
        Hide
        Ted Goddard added a comment -

        auctionMonitor and component-showcase are now working on the BlackBerry. Please open specific cases for specific bugs (initial support for the BlackBerry can now be considered to be available).

        Show
        Ted Goddard added a comment - auctionMonitor and component-showcase are now working on the BlackBerry. Please open specific cases for specific bugs (initial support for the BlackBerry can now be considered to be available).
        Ted Goddard made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17872 Thu Nov 06 15:06:46 MST 2008 ted.goddard checking window.blackberry for event.currentTarget special case (ICE-3574)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/event.js
        Ken Fyten made changes -
        Fix Version/s 1.8 [ 10161 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Mircea Toma [ mircea.toma ]
        Hide
        Ken Fyten added a comment -

        There is another JIRA (ICE-5697) that documents the known issues with ICEfaces and BlackBerry support.

        Show
        Ken Fyten added a comment - There is another JIRA ( ICE-5697 ) that documents the known issues with ICEfaces and BlackBerry support.

          People

          • Assignee:
            Unassigned
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: