Details
Improvement
Description
I've just spent some time getting ICEfaces working together with Spring Web Flow on a WebSphere Portal server. I've allready mentioned this to Ted Goddard (spoke to him at the recent JSF One conference) and I promised him some code when we were done.....well. Here goes. Hope it's of any use to you.
The first change is in your FacesContextFactoryImpl where I changed the getFacesContext method to include PortletContext as well:
if (context instanceof ServletContext || context instanceof PortletContext) {
The first change is in your FacesContextFactoryImpl where I changed the getFacesContext method to include PortletContext as well:
if (context instanceof ServletContext || context instanceof PortletContext) {
-
Hide
-
-
ICEfacesChanges/Constants.java
-
ICEfacesChanges/FacesContextFactoryImpl.java
-
ICEfacesChanges/FlowExecutionHandler.java
-
ICEfacesChanges/FlowExecutionHandlerFactory.java
-
ICEfacesChanges/MainPortlet.java
-
ICEfacesChanges/portlet.xml
-
ICEfacesChanges/PortletFlowExecutionHandler.java
-
ICEfacesChanges/ServletFlowExecutionHandler.java
-
ICEfacesChanges/SwfLifecycleExecutor.java
-
-
-
Issue Links
- depends on
-
ICE-4095
SwfLifecycleExecutor not working in portlet
-
- Closed
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
This patch looks good and the changes appear to be confined to Portlet/SWF integration. The only concerns would be:
- ensure that no runtime dependency on portal.jar is introduced
- com/icesoft/jasper/Constants.java appears to be used for more than constants relating to the Jasper compiler (however, this use is not specific to this patch, so there is "precedent").
Show
Ted Goddard
added a comment - This patch looks good and the changes appear to be confined to Portlet/SWF integration. The only concerns would be:
ensure that no runtime dependency on portal.jar is introduced
com/icesoft/jasper/Constants.java appears to be used for more than constants relating to the Jasper compiler (however, this use is not specific to this patch, so there is "precedent").
I've merged the changes into the latest code. Just checking to see if we have any regressions in the booking application.
I've checked in this code after running the booking app successfully. There still needs to be some major Spring Portal testing.
Peter,
This has been committed, please verify using WebSphere Portal, etc.
I've downloaded and build ICEfaces 1.8.2-RC1 and it appears to be in order. Great!
Show
Peter Bødskov
added a comment - I've downloaded and build ICEfaces 1.8.2-RC1 and it appears to be in order. Great!
These are the files that I've altered:
FacesContextFactoryImp
SwfLifecycleExecutor
MainPortlet
Constants
and then an example of the portlet.xml file (with an added parameter to get the flow id)